Refactor error handling in plan approval to remove redundant exception logging

Kingshuk-Microsoft · Kingshuk-Microsoft · commit 3646dc2d8574 · 2025-11-28T15:49:16.000+05:30
diff --git a/src/backend/v3/api/router.py b/src/backend/v3/api/router.py
@@ -421,13 +421,7 @@ async def plan_approval(human_feedback: messages.PlanApprovalResponse, request:
                         message_type=WebsocketMessageType.ERROR_MESSAGE,
                     )
 
-                except Exception as e:
-                    # print(f"Error processing plan approval: {e}")
-                    # await connection_config.send_status_update_async(
-                    #     {
-                    #         "type": WebsocketMessageType.ERROR_MESSAGE,
-                    #         "data": {
-                    #             "content": f"Failed to process approval: {str(e)}",
+                except Exception:
                     logger.error("Error processing plan approval", exc_info=True)
                     await connection_config.send_status_update_async(
                         {

Original file line number	Diff line number	Diff line change
`@@ -421,13 +421,7 @@ async def plan_approval(human_feedback: messages.PlanApprovalResponse, request:`
`421`	`421`	`message_type=WebsocketMessageType.ERROR_MESSAGE,`
`422`	`422`	`)`
`423`	`423`
`424`		`- except Exception as e:`
`425`		`- # print(f"Error processing plan approval: {e}")`
`426`		`- # await connection_config.send_status_update_async(`
`427`		`- # {`
`428`		`- # "type": WebsocketMessageType.ERROR_MESSAGE,`
`429`		`- # "data": {`
`430`		`- # "content": f"Failed to process approval: {str(e)}",`
	`424`	`+ except Exception:`
`431`	`425`	`logger.error("Error processing plan approval", exc_info=True)`
`432`	`426`	`await connection_config.send_status_update_async(`
`433`	`427`	`{`