Enhance error handling in OrchestrationManager and PlanPage for improved user feedback

Author: Kingshuk-Microsoft

src/backend/v3/orchestration/orchestration_manager.py

@@ -6,7 +6,7 @@
 from typing import List, Optional
 
 from common.config.app_config import config
-from common.models.messages_kernel import TeamConfiguration
+from common.models.messages_kernel import TeamConfiguration, AgentMessage, AgentType
 from semantic_kernel.agents.orchestration.magentic import MagenticOrchestration
 from semantic_kernel.agents.runtime import InProcessRuntime
 from azure.core.exceptions import ResourceNotFoundError
@@ -22,6 +22,7 @@
 from v3.magentic_agents.magentic_agent_factory import MagenticAgentFactory
 from v3.models.messages import WebsocketMessageType
 from v3.orchestration.human_approval_manager import HumanApprovalMagenticManager
+from common.database.database_factory import DatabaseFactory
 
 
 class OrchestrationManager:
@@ -182,14 +183,41 @@ async def run_orchestration(self, user_id, input_task) -> None:
                 )
                 self.logger.info(f"Final result sent via WebSocket to user {user_id}")
 
+            except ResourceNotFoundError as e:
+                self.logger.error(f"Agent not found: {e}")
+                self.logger.info(f"Error: {e}")
+                self.logger.info(f"Error type: {type(e).__name__}")
+                if hasattr(e, "__dict__"):
+                    self.logger.info(f"Error attributes: {e.__dict__}")
+                self.logger.info("=" * 50)
+
+                error_content = "The agent is currently unavailable. Please check if it was deleted or recreated.\n\nIf yes, please create a new plan from the home page."
+                
+                self.logger.info(f"🔴 Sending error message to user {user_id}: {error_content}")
+
+                await connection_config.send_status_update_async(
+                    {
+                        "type": WebsocketMessageType.ERROR_MESSAGE,
+                        "data": {
+                            "content": error_content,
+                            "status": "error",
+                            "timestamp": asyncio.get_event_loop().time(),
+                        },
+                    },
+                    user_id,
+                    message_type=WebsocketMessageType.ERROR_MESSAGE,
+                )
+                
+                self.logger.info(f"✅ Error message sent via WebSocket to user {user_id}")
+
             except Exception as e:
                 self.logger.error(f"Error processing final result: {e}")
                 # Send error message to user
                 await connection_config.send_status_update_async(
                     {
                         "type": WebsocketMessageType.ERROR_MESSAGE,
                         "data": {
-                            "content": "An error occurred while processing the final response.",
+                            "content": "An error occurred while processing the final response.\n\nPlease try creating a new plan from the home page.",
                             "status": "error",
                             "timestamp": asyncio.get_event_loop().time(),
                         },
@@ -198,26 +226,6 @@ async def run_orchestration(self, user_id, input_task) -> None:
                     message_type=WebsocketMessageType.ERROR_MESSAGE,
                 )
 
-        except ResourceNotFoundError as e:
-            self.logger.error(f"Agent not found: {e}")
-            self.logger.info(f"Error: {e}")
-            self.logger.info(f"Error type: {type(e).__name__}")
-            if hasattr(e, "__dict__"):
-                self.logger.info(f"Error attributes: {e.__dict__}")
-            self.logger.info("=" * 50)
-            await connection_config.send_status_update_async(
-                {
-                    "type": WebsocketMessageType.ERROR_MESSAGE,
-                    "data": {
-                        "content": "The agent is currently unavailable. Please check if it was deleted or recreated.",
-                        "status": "error",
-                        "timestamp": asyncio.get_event_loop().time(),
-                    },
-                },
-                user_id,
-                message_type=WebsocketMessageType.ERROR_MESSAGE,
-            )
-
         except RuntimeError as e:
             if "did not return any response" in str(e):
                 self.logger.error(f"Agent failed: {e}")
@@ -226,7 +234,7 @@ async def run_orchestration(self, user_id, input_task) -> None:
                     {
                         "type": WebsocketMessageType.ERROR_MESSAGE,
                         "data": {
-                            "content": "I'm having trouble connecting to the agent right now. Please try again later.",
+                            "content": "I'm having trouble connecting to the agent right now.\n\nPlease try creating a new plan from the home page or try again later.",
                             "status": "error",
                             "timestamp": asyncio.get_event_loop().time(),
                         },
@@ -246,7 +254,7 @@ async def run_orchestration(self, user_id, input_task) -> None:
                     {
                         "type": WebsocketMessageType.ERROR_MESSAGE,
                         "data": {
-                            "content": "Something went wrong. Please try again later.",
+                            "content": "Something went wrong.\n\nPlease try creating a new plan from the home page or try again later.",
                             "status": "error",
                             "timestamp": asyncio.get_event_loop().time(),
                         },
@@ -262,19 +270,25 @@ async def run_orchestration(self, user_id, input_task) -> None:
             if hasattr(e, "__dict__"):
                 self.logger.info(f"Error attributes: {e.__dict__}")
             self.logger.info("=" * 50)
-            # Always send error to frontend
+
+            error_content = "Something went wrong.\n\nPlease try creating a new plan from the home page or try again later."
+            
+            self.logger.info(f"🔴 Sending error message to user {user_id}: {error_content}")
+
             await connection_config.send_status_update_async(
                 {
                     "type": WebsocketMessageType.ERROR_MESSAGE,
                     "data": {
-                        "content": "Something went wrong. Please try again later.",
+                        "content": error_content,
                         "status": "error",
                         "timestamp": asyncio.get_event_loop().time(),
                     },
                 },
                 user_id,
                 message_type=WebsocketMessageType.ERROR_MESSAGE,
             )
+            
+            self.logger.info(f"✅ Error message sent via WebSocket to user {user_id}")
 
         finally:
             await runtime.stop_when_idle()

src/frontend/src/pages/PlanPage.tsx

@@ -399,7 +399,35 @@ const PlanPage: React.FC = () => {
     useEffect(() => {
         const unsubscribe = webSocketService.on(WebsocketMessageType.ERROR_MESSAGE, (errorMessage: any) => {
             console.log('❌ Received ERROR_MESSAGE:', errorMessage);
-            const errorContent = errorMessage?.data?.content || "Something went wrong. Please try again later.";
+            console.log('❌ Error message data:', errorMessage?.data);
+            
+            // Try multiple ways to extract the error message
+            let errorContent = "An unexpected error occurred. Please try again later.";
+            
+            // Check for double-nested data structure
+            if (errorMessage?.data?.data?.content) {
+                const content = errorMessage.data.data.content.trim();
+                if (content.length > 0) {
+                    errorContent = content;
+                }
+            } else if (errorMessage?.data?.content) {
+                const content = errorMessage.data.content.trim();
+                if (content.length > 0) {
+                    errorContent = content;
+                }
+            } else if (errorMessage?.content) {
+                const content = errorMessage.content.trim();
+                if (content.length > 0) {
+                    errorContent = content;
+                }
+            } else if (typeof errorMessage === 'string') {
+                const content = errorMessage.trim();
+                if (content.length > 0) {
+                    errorContent = content;
+                }
+            }
+
+            console.log('❌ Final error content to display:', errorContent);
 
             const errorAgentMessage: AgentMessageData = {
                 agent: 'system',
@@ -416,6 +444,7 @@ const PlanPage: React.FC = () => {
             setShowBufferingText(false);
             setIsProcessing(false);
             setShowProcessingMessage(false);
+            setSubmittingChatDisableInput(false);
             scrollToBottom();
             showToast(errorContent, "error");
         });
@@ -466,8 +495,8 @@ const PlanPage: React.FC = () => {
 
     // WebSocket connection with proper error handling and v3 backend compatibility
     useEffect(() => {
-        if (planId && continueWithWebsocketFlow) {
-            console.log('🔌 Connecting WebSocket:', { planId, continueWithWebsocketFlow });
+        if (planId) {
+            console.log('🔌 Connecting WebSocket:', { planId });
 
             const connectWebSocket = async () => {
                 try {
@@ -525,7 +554,7 @@ const PlanPage: React.FC = () => {
                 webSocketService.disconnect();
             };
         }
-    }, [planId, loading, continueWithWebsocketFlow]);
+    }, [planId]);
 
     // Force spinner off whenever network error occurs
     useEffect(() => {