RAI validation

Author: blessing-sanusi

src/backend/app_kernel.py

@@ -42,7 +42,7 @@
 from services.json_service import JsonService
 
 # Updated import for KernelArguments
-from utils_kernel import initialize_runtime_and_context, rai_success
+from utils_kernel import initialize_runtime_and_context, rai_success, rai_validate_team_config
 
 
 # Check if the Application Insights Instrumentation Key is set in the environment variables
@@ -1476,6 +1476,34 @@ async def upload_team_config_endpoint(request: Request, file: UploadFile = File(
                 status_code=400, detail=f"Invalid JSON format: {str(e)}"
             )
 
+        # Validate content with RAI before processing
+        rai_valid, rai_error = await rai_validate_team_config(json_data)
+        if not rai_valid:
+            # Track RAI validation failure
+            track_event_if_configured(
+                "Team configuration RAI validation failed",
+                {
+                    "status": "failed",
+                    "user_id": user_id,
+                    "filename": file.filename,
+                    "reason": rai_error,
+                },
+            )
+            raise HTTPException(
+                status_code=400, 
+                detail=rai_error
+            )
+        
+        # Track successful RAI validation
+        track_event_if_configured(
+            "Team configuration RAI validation passed",
+            {
+                "status": "passed",
+                "user_id": user_id,
+                "filename": file.filename,
+            },
+        )
+
         # Initialize memory store and service
         kernel, memory_store = await initialize_runtime_and_context("", user_id)
         json_service = JsonService(memory_store)

src/backend/utils_kernel.py

@@ -293,3 +293,68 @@ async def rai_success(description: str, is_task_creation: bool) -> bool:
         logging.error(f"Error in RAI check: {str(e)}")
         # Default to blocking the operation if RAI check fails for safety
         return False
+
+
+async def rai_validate_team_config(team_config_json: dict) -> tuple[bool, str]:
+    """
+    Validates team configuration JSON content for RAI compliance.
+    
+    Args:
+        team_config_json: The team configuration JSON data to validate
+        
+    Returns:
+        Tuple of (is_valid, error_message)
+        - is_valid: True if content passes RAI checks, False otherwise
+        - error_message: Simple error message if validation fails
+    """
+    try:
+        # Extract all text content from the team configuration
+        text_content = []
+        
+        # Extract team name and description
+        if "name" in team_config_json:
+            text_content.append(team_config_json["name"])
+        if "description" in team_config_json:
+            text_content.append(team_config_json["description"])
+        
+        # Extract agent information
+        if "agents" in team_config_json:
+            for agent in team_config_json["agents"]:
+                if isinstance(agent, dict):
+                    if "name" in agent:
+                        text_content.append(agent["name"])
+                    if "description" in agent:
+                        text_content.append(agent["description"])
+                    if "role" in agent:
+                        text_content.append(agent["role"])
+                    if "capabilities" in agent and isinstance(agent["capabilities"], list):
+                        text_content.extend(agent["capabilities"])
+        
+        # Extract starting tasks
+        if "starting_tasks" in team_config_json:
+            for task in team_config_json["starting_tasks"]:
+                if isinstance(task, str):
+                    text_content.append(task)
+                elif isinstance(task, dict):
+                    if "name" in task:
+                        text_content.append(task["name"])
+                    if "prompt" in task:
+                        text_content.append(task["prompt"])
+        
+        # Combine all text content for validation
+        combined_content = " ".join(text_content)
+        
+        if not combined_content.strip():
+            return False, "Team configuration contains no readable text content"
+        
+        # Use existing RAI validation function
+        rai_result = await rai_success(combined_content, False)
+        
+        if not rai_result:
+            return False, "Team configuration contains inappropriate content and cannot be uploaded."
+        
+        return True, ""
+        
+    except Exception as e:
+        logging.error(f"Error validating team configuration with RAI: {str(e)}")
+        return False, "Unable to validate team configuration content. Please try again."

src/frontend/src/components/common/SettingsButton.tsx

@@ -42,6 +42,7 @@ const SettingsButton: React.FC<SettingsButtonProps> = ({
   const [loading, setLoading] = useState(false);
   const [uploadLoading, setUploadLoading] = useState(false);
   const [error, setError] = useState<string | null>(null);
+  const [uploadMessage, setUploadMessage] = useState<string | null>(null);
   const [tempSelectedTeam, setTempSelectedTeam] = useState<TeamConfig | null>(null);
 
   const loadTeams = async () => {
@@ -67,8 +68,12 @@ const SettingsButton: React.FC<SettingsButtonProps> = ({
     if (open) {
       await loadTeams();
       setTempSelectedTeam(selectedTeam || null);
+      setError(null);
+      setUploadMessage(null);
     } else {
       setTempSelectedTeam(null);
+      setError(null);
+      setUploadMessage(null);
     }
   };
 
@@ -95,27 +100,37 @@ const SettingsButton: React.FC<SettingsButtonProps> = ({
     console.log('SettingsButton: Starting file upload for:', file.name);
     setUploadLoading(true);
     setError(null);
+    setUploadMessage('Uploading and validating team configuration...');
 
     try {
       const result = await TeamService.uploadCustomTeam(file);
       console.log('SettingsButton: Upload result:', result);
+      
       if (result.success) {
         console.log('SettingsButton: Upload successful, reloading teams...');
+        setUploadMessage('Team uploaded successfully! Refreshing teams...');
         // Reload teams to include the new custom team
         await loadTeams();
         console.log('SettingsButton: Teams reloaded after upload');
+        setUploadMessage(null);
         // Notify parent component about the upload
         if (onTeamUpload) {
           console.log('SettingsButton: Notifying parent about upload...');
           await onTeamUpload();
         }
+      } else if (result.raiError) {
+        console.error('SettingsButton: Upload failed due to RAI validation:', result.raiError);
+        setError('Upload failed: Team configuration contains inappropriate content.');
+        setUploadMessage(null);
       } else {
         console.error('SettingsButton: Upload failed:', result.error);
         setError(result.error || 'Failed to upload team configuration');
+        setUploadMessage(null);
       }
     } catch (err: any) {
       console.error('SettingsButton: Upload exception:', err);
       setError(err.message || 'Failed to upload team configuration');
+      setUploadMessage(null);
     } finally {
       setUploadLoading(false);
       // Reset the input
@@ -308,11 +323,35 @@ const SettingsButton: React.FC<SettingsButtonProps> = ({
         <DialogContent style={{ width: '100%', padding: '0' }}>
           <DialogBody style={{ width: '100%', padding: '16px 24px', display: 'block' }}>
             {error && (
-              <div style={{ color: 'red', marginBottom: '16px' }}>
+              <div style={{ 
+                color: '#d13438', 
+                marginBottom: '16px',
+                padding: '12px',
+                backgroundColor: '#fdf2f2',
+                border: '1px solid #f5c6cb',
+                borderRadius: '4px'
+              }}>
                 <Text>{error}</Text>
               </div>
             )}
 
+            {uploadMessage && (
+              <div style={{ 
+                color: '#107c10', 
+                marginBottom: '16px',
+                padding: '12px',
+                backgroundColor: '#f3f9f3',
+                border: '1px solid #c6e7c6',
+                borderRadius: '4px',
+                display: 'flex',
+                alignItems: 'center',
+                gap: '8px'
+              }}>
+                <Spinner size="extra-small" />
+                <Text>{uploadMessage}</Text>
+              </div>
+            )}
+
             {loading ? (
               <div style={{ display: 'flex', justifyContent: 'center', padding: '32px' }}>
                 <Spinner label="Loading teams..." />

src/frontend/src/services/TeamService.ts

@@ -5,7 +5,7 @@ export class TeamService {
     /**
      * Upload a custom team configuration
      */
-    static async uploadCustomTeam(teamFile: File): Promise<{ success: boolean; team?: TeamConfig; error?: string }> {
+    static async uploadCustomTeam(teamFile: File): Promise<{ success: boolean; team?: TeamConfig; error?: string; raiError?: any }> {
         try {
             console.log('TeamService: Starting team upload for file:', teamFile.name);
             const formData = new FormData();
@@ -23,9 +23,31 @@ export class TeamService {
         } catch (error: any) {
             console.error('TeamService: Upload failed:', error);
             console.error('TeamService: Upload error details:', error.response?.data);
+            
+            // Check if this is an RAI validation error
+            const errorDetail = error.response?.data?.detail || error.response?.data;
+            
+            // If the error message contains "inappropriate content", treat it as RAI error
+            if (typeof errorDetail === 'string' && errorDetail.includes('inappropriate content')) {
+                return {
+                    success: false,
+                    raiError: {
+                        error_type: 'RAI_VALIDATION_FAILED',
+                        message: errorDetail,
+                        description: errorDetail
+                    }
+                };
+            }
+            
+            // Get error message from the response
+            let errorMessage = error.message || 'Failed to upload team configuration';
+            if (error.response?.data?.detail) {
+                errorMessage = error.response.data.detail;
+            }
+            
             return {
                 success: false,
-                error: error.message || 'Failed to upload team configuration'
+                error: errorMessage
             };
         }
     }