Improve error handling and logging in agent orchestration

Added print statements for better visibility of agent creation failures in magentic_agent_factory and orchestration_manager. Enhanced error handling in orchestration_manager to log and raise exceptions during agent creation and orchestration initialization. Updated human_approval_manager to ensure correct progress ledger handling when max rounds are exceeded, and removed unused imports. Temporarily disabled file search tool addition in foundry_agent for debugging.

Author: Fr4nc3

src/backend/v4/magentic_agents/foundry_agent.py

@@ -65,10 +65,11 @@ async def _collect_tools(self) -> List:
 
         # File Search tool (RAG)
         if self.search:
-            search_tool = await self._make_file_search_tool()
-            if search_tool:
-                tools.append(search_tool)
-                self.logger.info("Added File Search tool.")
+            print("Adding File Search tool.")
+            # search_tool = await self._make_file_search_tool()
+            # if search_tool:
+            #     tools.append(search_tool)
+            #     self.logger.info("Added File Search tool.")
 
         # Code Interpreter
         if self.enable_code_interpreter:

src/backend/v4/magentic_agents/magentic_agent_factory.py

@@ -160,9 +160,11 @@ async def get_agents(self, user_id: str, team_config_input: TeamConfiguration) -
 
                 except (UnsupportedModelError, InvalidConfigurationError) as e:
                     self.logger.warning(f"Skipped agent {agent_cfg.name}: {e}")
+                    print(f"Skipped agent {agent_cfg.name}: {e}")
                     continue
                 except Exception as e:
                     self.logger.error(f"Failed to create agent {agent_cfg.name}: {e}")
+                    print(f"Failed to create agent {agent_cfg.name}: {e}")
                     continue
 
             self.logger.info(

src/backend/v4/orchestration/human_approval_manager.py

@@ -11,8 +11,6 @@
 from agent_framework import ChatMessage
 from agent_framework._workflows._magentic import (
     MagenticContext,
-    MagenticProgressLedger as ProgressLedger,
-    MagenticProgressLedgerItem as ProgressLedgerItem,
     StandardMagenticManager,
     ORCHESTRATOR_FINAL_ANSWER_PROMPT,
     ORCHESTRATOR_TASK_LEDGER_PLAN_PROMPT,
@@ -75,7 +73,6 @@ def __init__(self, user_id: str, *args, **kwargs):
             ORCHESTRATOR_TASK_LEDGER_PLAN_UPDATE_PROMPT + plan_append
         )
         kwargs["final_answer_prompt"] = ORCHESTRATOR_FINAL_ANSWER_PROMPT + final_append
-        #kwargs["current_user_id"] = user_id  # retained for downstream usage if needed
 
         self.current_user_id = user_id
         super().__init__(*args, **kwargs)
@@ -161,11 +158,12 @@ async def replan(self, magentic_context: MagenticContext) -> Any:
         )
         return replan_message
 
-    async def create_progress_ledger(
-        self, magentic_context: MagenticContext
-    ) -> ProgressLedger:
+    async def create_progress_ledger(self, magentic_context: MagenticContext):
         """
         Check for max rounds exceeded and send final message if so, else defer to base.
+        
+        Returns:
+            Progress ledger object (type depends on agent_framework version)
         """
         if magentic_context.round_count >= orchestration_config.max_rounds:
             final_message = messages.FinalResultMessage(
@@ -180,22 +178,24 @@ async def create_progress_ledger(
                 message_type=messages.WebsocketMessageType.FINAL_RESULT_MESSAGE,
             )
 
-            return ProgressLedger(
-                is_request_satisfied=ProgressLedgerItem(
-                    reason="Maximum rounds exceeded", answer=True
-                ),
-                is_in_loop=ProgressLedgerItem(reason="Terminating", answer=False),
-                is_progress_being_made=ProgressLedgerItem(
-                    reason="Terminating", answer=False
-                ),
-                next_speaker=ProgressLedgerItem(reason="Task complete", answer=""),
-                instruction_or_question=ProgressLedgerItem(
-                    reason="Task complete",
-                    answer="Process terminated due to maximum rounds exceeded",
-                ),
-            )
-
-        # Delegate to base (which creates a MagenticProgressLedger)
+            # Call base class to get the proper ledger type, then raise to terminate
+            ledger = await super().create_progress_ledger(magentic_context)
+            
+            # Override key fields to signal termination
+            ledger.is_request_satisfied.answer = True
+            ledger.is_request_satisfied.reason = "Maximum rounds exceeded"
+            ledger.is_in_loop.answer = False
+            ledger.is_in_loop.reason = "Terminating"
+            ledger.is_progress_being_made.answer = False
+            ledger.is_progress_being_made.reason = "Terminating"
+            ledger.next_speaker.answer = ""
+            ledger.next_speaker.reason = "Task complete"
+            ledger.instruction_or_question.answer = "Process terminated due to maximum rounds exceeded"
+            ledger.instruction_or_question.reason = "Task complete"
+            
+            return ledger
+
+        # Delegate to base for normal progress ledger creation
         return await super().create_progress_ledger(magentic_context)
 
     async def _wait_for_user_approval(
@@ -302,4 +302,4 @@ def plan_to_obj(self, magentic_context: MagenticContext, ledger) -> MPlan:
             task=task_text,
         )
 
-        return return_plan
+        return return_plan

src/backend/v4/orchestration/orchestration_manager.py

@@ -205,14 +205,24 @@ async def get_current_or_new_orchestration(
                                 cls.logger.error("Error closing agent: %s", e)
 
             factory = MagenticAgentFactory()
-            agents = await factory.get_agents(
-                user_id=user_id, team_config_input=team_config
-            )
-            cls.logger.info("Created %d agents for user '%s'", len(agents), user_id)
-            
-            orchestration_config.orchestrations[user_id] = await cls.init_orchestration(
-                agents, user_id
-            )
+            try:
+                agents = await factory.get_agents(
+                    user_id=user_id, team_config_input=team_config
+                )
+                cls.logger.info("Created %d agents for user '%s'", len(agents), user_id)
+            except Exception as e:
+                cls.logger.error("Failed to create agents for user '%s': %s", user_id, e)
+                print(f"Failed to create agents for user '{user_id}': {e}")
+                raise
+            try:
+                cls.logger.info("Initializing new orchestration for user '%s'", user_id)
+                orchestration_config.orchestrations[user_id] = await cls.init_orchestration(
+                    agents, user_id
+                )
+            except Exception as e:
+                cls.logger.error("Failed to initialize orchestration for user '%s': %s", user_id, e)
+                print(f"Failed to initialize orchestration for user '{user_id}': {e}")
+                raise
         return orchestration_config.get_current_orchestration(user_id)
 
     # ---------------------------