Merge branch 'UT-10888-backend' of https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator into UT-10888-backend

Author: Pradheep-Microsoft

src/backend/tests/agents/test_agentutils.py

@@ -1,12 +1,10 @@
 # pylint: disable=import-error, wrong-import-position, missing-module-docstring
-import json
 import os
 import sys
-from unittest.mock import AsyncMock, MagicMock, patch
+from unittest.mock import MagicMock
 import pytest
 from pydantic import ValidationError
 
-
 # Environment and module setup
 sys.modules["azure.monitor.events.extension"] = MagicMock()
 
@@ -18,84 +16,10 @@
 os.environ["AZURE_OPENAI_API_VERSION"] = "2023-01-01"
 os.environ["AZURE_OPENAI_ENDPOINT"] = "https://mock-openai-endpoint"
 
-# noqa: F401 is to ignore unused import warnings (if any)
 from src.backend.agents.agentutils import extract_and_update_transition_states  # noqa: F401, C0413
 from src.backend.models.messages import Step  # noqa: F401, C0413
 
 
-@pytest.mark.asyncio
-async def test_extract_and_update_transition_states_invalid_response():
-    """Test handling of invalid JSON response from model client."""
-    session_id = "test_session"
-    user_id = "test_user"
-    step = Step(
-        data_type="step",
-        plan_id="test_plan",
-        action="test_action",
-        agent="HumanAgent",
-        session_id=session_id,
-        user_id=user_id,
-        agent_reply="test_reply",
-    )
-    model_client = AsyncMock()
-    cosmos_mock = MagicMock()
-
-    model_client.create.return_value = MagicMock(content="invalid_json")
-
-    with patch(
-        "src.backend.context.cosmos_memory.CosmosBufferedChatCompletionContext",
-        cosmos_mock,
-    ):
-        with pytest.raises(json.JSONDecodeError):
-            await extract_and_update_transition_states(
-                step=step,
-                session_id=session_id,
-                user_id=user_id,
-                planner_dynamic_or_workflow="workflow",
-                model_client=model_client,
-            )
-
-    cosmos_mock.update_step.assert_not_called()
-
-
-@pytest.mark.asyncio
-async def test_extract_and_update_transition_states_validation_error():
-    """Test handling of a response missing required fields."""
-    session_id = "test_session"
-    user_id = "test_user"
-    step = Step(
-        data_type="step",
-        plan_id="test_plan",
-        action="test_action",
-        agent="HumanAgent",
-        session_id=session_id,
-        user_id=user_id,
-        agent_reply="test_reply",
-    )
-    model_client = AsyncMock()
-    cosmos_mock = MagicMock()
-
-    invalid_response = {
-        "identifiedTargetState": "state1"
-    }  # Missing 'identifiedTargetTransition'
-    model_client.create.return_value = MagicMock(content=json.dumps(invalid_response))
-
-    with patch(
-        "src.backend.context.cosmos_memory.CosmosBufferedChatCompletionContext",
-        cosmos_mock,
-    ):
-        with pytest.raises(ValidationError):
-            await extract_and_update_transition_states(
-                step=step,
-                session_id=session_id,
-                user_id=user_id,
-                planner_dynamic_or_workflow="workflow",
-                model_client=model_client,
-            )
-
-    cosmos_mock.update_step.assert_not_called()
-
-
 def test_step_initialization():
     """Test Step initialization with valid data."""
     step = Step(
@@ -128,4 +52,3 @@ def test_step_missing_required_fields():
             agent="test_agent",
             session_id="test_session",
         )
-        

src/backend/tests/agents/test_base_agent.py

@@ -22,6 +22,7 @@
 from src.backend.models.messages import ActionRequest, Step, StepStatus
 from autogen_core.base import AgentId
 
+
 # Context manager for setting up mocks
 @contextmanager
 def mock_context():

src/backend/tests/agents/test_group_chat_manager.py

@@ -1,9 +1,12 @@
+"""
+Combined Test cases for GroupChatManager class in the backend agents module.
+"""
+
 import os
 import sys
 from unittest.mock import AsyncMock, patch, MagicMock
 import pytest
 
-
 # Set mock environment variables for Azure and CosmosDB before importing anything else
 os.environ["COSMOSDB_ENDPOINT"] = "https://mock-endpoint"
 os.environ["COSMOSDB_KEY"] = "mock-key"
@@ -13,21 +16,17 @@
 os.environ["AZURE_OPENAI_API_VERSION"] = "2023-01-01"
 os.environ["AZURE_OPENAI_ENDPOINT"] = "https://mock-openai-endpoint"
 
-
 # Mock Azure dependencies
 sys.modules["azure.monitor.events.extension"] = MagicMock()
 
-
 # Import after setting environment variables
 from src.backend.agents.group_chat_manager import GroupChatManager
 from src.backend.models.messages import (
-    HumanFeedback,
     Step,
     StepStatus,
     BAgentType,
-    Plan,
 )
-from autogen_core.base import MessageContext, AgentInstantiationContext, AgentRuntime
+from autogen_core.base import AgentInstantiationContext, AgentRuntime
 from autogen_core.components.models import AzureOpenAIChatCompletionClient
 from src.backend.context.cosmos_memory import CosmosBufferedChatCompletionContext
 from autogen_core.base import AgentId
@@ -98,4 +97,32 @@ async def test_update_step_status(mock_track_event, setup_group_chat_manager):
             "human_feedback": "Feedback message",
             "source": step.agent,
         },
-    )
+    )
+
+
+@pytest.mark.asyncio
+async def test_update_step_invalid_feedback_status(setup_group_chat_manager):
+    """
+    Test `_update_step_status` with invalid feedback status.
+    Covers lines 210-211.
+    """
+    group_chat_manager, mock_memory, session_id, user_id, mock_agent_ids = setup_group_chat_manager
+
+    # Create a mock Step
+    step = Step(
+        id="test_step_id",
+        session_id=session_id,
+        plan_id="test_plan_id",
+        user_id=user_id,
+        action="Test Action",
+        agent=BAgentType.human_agent,
+        status=StepStatus.planned,
+    )
+
+    # Call the method with invalid feedback status
+    await group_chat_manager._update_step_status(step, None, "Feedback message")
+
+    # Assertions
+    step.status = StepStatus.planned  # Status should remain unchanged
+    step.human_feedback = "Feedback message"
+    mock_memory.update_step.assert_called_once_with(step)