Skip to content

Commit 86f6a8f

Browse files
committed
Refactor websocket message type usage
Replaced string literals with WebsocketMessageType enum for agent messages and plan approval events in PlanPage and PlanDataService. This improves type safety and consistency when handling websocket events.
1 parent 91a9aa8 commit 86f6a8f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/frontend/src/pages/PlanPage.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@ const PlanPage: React.FC = () => {
128128
handleConnectionChange(message.data?.connected || false);
129129
});
130130

131-
const unsubscribeStreaming = webSocketService.on('agent_message', handleStreamingMessage);
132-
const unsubscribePlanApproval = webSocketService.on('plan_approval_response', handlePlanApprovalResponse);
133-
const unsubscribePlanApprovalRequest = webSocketService.on('plan_approval_request', handlePlanApprovalRequest);
131+
const unsubscribeStreaming = webSocketService.on(WebsocketMessageType.AGENT_MESSAGE, handleStreamingMessage);
132+
const unsubscribePlanApproval = webSocketService.on(WebsocketMessageType.PLAN_APPROVAL_RESPONSE, handlePlanApprovalResponse);
133+
const unsubscribePlanApprovalRequest = webSocketService.on(WebsocketMessageType.PLAN_APPROVAL_REQUEST, handlePlanApprovalRequest);
134134
const unsubscribeParsedPlanApprovalRequest = webSocketService.on(WebsocketMessageType.PLAN_APPROVAL_REQUEST, handlePlanApprovalRequest);
135135

136136
return () => {

src/frontend/src/services/PlanDataService.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ export class PlanDataService {
379379
} | null {
380380
try {
381381
// Unwrap wrapper
382-
if (rawData && typeof rawData === 'object' && rawData.type === 'agent_message' && typeof rawData.data === 'string') {
382+
if (rawData && typeof rawData === 'object' && rawData.type === WebsocketMessageType.AGENT_MESSAGE && typeof rawData.data === 'string') {
383383
return this.parseAgentMessage(rawData.data);
384384
}
385385

0 commit comments

Comments
 (0)