Skip to content

Commit a95e5e6

Browse files
Merge pull request #383 from microsoft/dev
fix: merging dev changes to main branch
2 parents 2595c2d + ffffd12 commit a95e5e6

14 files changed

+436
-340
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
- name: Run tests with coverage
5252
if: env.skip_tests == 'false'
5353
run: |
54-
pytest --cov=. --cov-report=term-missing --cov-report=xml
54+
pytest --cov=. --cov-report=term-missing --cov-report=xml --ignore=tests/e2e-test/tests
5555
5656
- name: Skip coverage report if no tests
5757
if: env.skip_tests == 'true'

docs/CustomizingAzdParameters.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ By default this template will use the environment name as the prefix to prevent
99
| Name | Type | Default Value | Purpose |
1010
| ------------------------------- | ------ | ----------------- | --------------------------------------------------------------------------------------------------- |
1111
| `AZURE_ENV_NAME` | string | `macae` | Used as a prefix for all resource names to ensure uniqueness across environments. |
12-
| `AZURE_LOCATION` | string | `swedencentral` | Location of the Azure resources. Controls where the infrastructure will be deployed. |
13-
| `AZURE_ENV_OPENAI_LOCATION` | string | `swedencentral` | Specifies the region for OpenAI resource deployment. |
12+
| `AZURE_LOCATION` | string | `<User selects during deployment>` | Location of the Azure resources. Controls where the infrastructure will be deployed. |
13+
| `AZURE_ENV_OPENAI_LOCATION` | string | `<User selects during deployment>` | Specifies the region for OpenAI resource deployment. |
1414
| `AZURE_ENV_MODEL_DEPLOYMENT_TYPE` | string | `GlobalStandard` | Defines the deployment type for the AI model (e.g., Standard, GlobalStandard). |
1515
| `AZURE_ENV_MODEL_NAME` | string | `gpt-4o` | Specifies the name of the GPT model to be deployed. |
1616
| `AZURE_ENV_FOUNDRY_PROJECT_ID` | string | `<Existing Workspace Id>` | Set this if you want to reuse an AI Foundry Project instead of creating a new one. |

docs/DeploymentGuide.md

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ The easiest way to run this accelerator is in a VS Code Dev Containers, which wi
233233

234234
## Detailed Development Container setup instructions
235235

236-
The solution contains a [development container](https://code.visualstudio.com/docs/remote/containers) with all the required tooling to develop and deploy the accelerator. To deploy the Chat With Your Data accelerator using the provided development container you will also need:
236+
The solution contains a [development container](https://code.visualstudio.com/docs/remote/containers) with all the required tooling to develop and deploy the accelerator. To deploy the Multi-Agent solutions accelerator using the provided development container you will also need:
237237

238238
- [Visual Studio Code](https://code.visualstudio.com)
239239
- [Remote containers extension for Visual Studio Code](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers)
@@ -287,7 +287,7 @@ The files for the dev container are located in `/.devcontainer/` folder.
287287

288288
- You can use the Bicep extension for VSCode (Right-click the `.bicep` file, then select "Show deployment plan") or use the Azure CLI:
289289
```bash
290-
az deployment group create -g <resource-group-name> -f deploy/macae-dev.bicep --query 'properties.outputs'
290+
az deployment group create -g <resource-group-name> -f infra/main.bicep --query 'properties.outputs'
291291
```
292292
- **Note**: You will be prompted for a `principalId`, which is the ObjectID of your user in Entra ID. To find it, use the Azure Portal or run:
293293
@@ -301,7 +301,7 @@ The files for the dev container are located in `/.devcontainer/` folder.
301301
302302
**Role Assignments in Bicep Deployment:**
303303
304-
The **macae-dev.bicep** deployment includes the assignment of the appropriate roles to AOAI and Cosmos services. If you want to modify an existing implementation—for example, to use resources deployed as part of the simple deployment for local debugging—you will need to add your own credentials to access the Cosmos and AOAI services. You can add these permissions using the following commands:
304+
The **main.bicep** deployment includes the assignment of the appropriate roles to AOAI and Cosmos services. If you want to modify an existing implementation—for example, to use resources deployed as part of the simple deployment for local debugging—you will need to add your own credentials to access the Cosmos and AOAI services. You can add these permissions using the following commands:
305305
306306
```bash
307307
az cosmosdb sql role assignment create --resource-group <solution-accelerator-rg> --account-name <cosmos-db-account-name> --role-definition-name "Cosmos DB Built-in Data Contributor" --principal-id <aad-user-object-id> --scope /subscriptions/<subscription-id>/resourceGroups/<solution-accelerator-rg>/providers/Microsoft.DocumentDB/databaseAccounts/<cosmos-db-account-name>
@@ -320,11 +320,16 @@ The files for the dev container are located in `/.devcontainer/` folder.
320320
321321
5. **Create a `.env` file:**
322322
323-
- Navigate to the `src` folder and create a `.env` file based on the provided `.env.sample` file.
323+
- Navigate to the `src\backend` folder and create a `.env` file based on the provided `.env.sample` file.
324+
- Update the `.env` file with the required values from your Azure resource group in Azure Portal App Service environment variables.
325+
- Alternatively, if resources were
326+
provisioned using `azd provision` or `azd up`, a `.env` file is automatically generated in the `.azure/<env-name>/.env`
327+
file. To get your `<env-name>` run `azd env list` to see which env is default.
324328
325329
6. **Fill in the `.env` file:**
326330
327331
- Use the output from the deployment or check the Azure Portal under "Deployments" in the resource group.
332+
- Make sure to set APP_ENV to "**dev**" in `.env` file.
328333
329334
7. **(Optional) Set up a virtual environment:**
330335
@@ -337,8 +342,19 @@ The files for the dev container are located in `/.devcontainer/` folder.
337342
```bash
338343
pip install -r requirements.txt
339344
```
345+
346+
9. **Build the frontend (important):**
340347
341-
9. **Run the application:**
348+
- Before running the frontend server, you must build the frontend to generate the necessary `build/assets` directory.
349+
350+
From the `src/frontend` directory, run:
351+
352+
```bash
353+
npm install
354+
npm run build
355+
```
356+
357+
10. **Run the application:**
342358
343359
- From the src/backend directory:
344360

docs/LocalDeployment.md

Lines changed: 0 additions & 164 deletions
This file was deleted.

infra/main.bicep

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ param enableTelemetry bool = true
1818

1919
param existingLogAnalyticsWorkspaceId string = ''
2020

21+
param azureopenaiVersion string = '2025-01-01-preview'
22+
2123
// Restricting deployment to only supported Azure OpenAI regions validated with GPT-4o model
2224
@metadata({
2325
azd : {
@@ -1000,7 +1002,7 @@ module containerApp 'br/public:avm/res/app/container-app:0.14.2' = if (container
10001002
}
10011003
{
10021004
name: 'AZURE_OPENAI_API_VERSION'
1003-
value: '2025-01-01-preview' //TODO: set parameter/variable
1005+
value: azureopenaiVersion
10041006
}
10051007
{
10061008
name: 'APPLICATIONINSIGHTS_INSTRUMENTATION_KEY'
@@ -1718,3 +1720,22 @@ type webSiteConfigurationType = {
17181720
@description('Optional. The tag of the container image to be used by the Web Site.')
17191721
containerImageTag: string?
17201722
}
1723+
1724+
1725+
output COSMOSDB_ENDPOINT string = 'https://${cosmosDbResourceName}.documents.azure.com:443/'
1726+
output COSMOSDB_DATABASE string = cosmosDbDatabaseName
1727+
output COSMOSDB_CONTAINER string = cosmosDbDatabaseMemoryContainerName
1728+
output AZURE_OPENAI_ENDPOINT string = 'https://${aiFoundryAiServicesResourceName}.openai.azure.com/'
1729+
output AZURE_OPENAI_MODEL_NAME string = aiFoundryAiServicesModelDeployment.name
1730+
output AZURE_OPENAI_DEPLOYMENT_NAME string = aiFoundryAiServicesModelDeployment.name
1731+
output AZURE_OPENAI_API_VERSION string = azureopenaiVersion
1732+
// output APPLICATIONINSIGHTS_INSTRUMENTATION_KEY string = applicationInsights.outputs.instrumentationKey
1733+
// output AZURE_AI_PROJECT_ENDPOINT string = aiFoundryAiServices.outputs.aiProjectInfo.apiEndpoint
1734+
output AZURE_AI_SUBSCRIPTION_ID string = subscription().subscriptionId
1735+
output AZURE_AI_RESOURCE_GROUP string = resourceGroup().name
1736+
output AZURE_AI_PROJECT_NAME string = aiFoundryAiProjectName
1737+
output AZURE_AI_MODEL_DEPLOYMENT_NAME string = aiFoundryAiServicesModelDeployment.name
1738+
// output APPLICATIONINSIGHTS_CONNECTION_STRING string = applicationInsights.outputs.connectionString
1739+
output AZURE_AI_AGENT_MODEL_DEPLOYMENT_NAME string = aiFoundryAiServicesModelDeployment.name
1740+
output AZURE_AI_AGENT_ENDPOINT string = aiFoundryAiServices.outputs.aiProjectInfo.apiEndpoint
1741+
output APP_ENV string = 'Prod'

0 commit comments

Comments
 (0)