resolve the pylint

Author: Dhruvkumar-Microsoft

src/backend/common/utils/utils_af.py

@@ -1,14 +1,14 @@
 """Utility functions for agent_framework-based integration and agent management (converted from agent framework )."""
 
 import logging
-from typing import Any, Dict
 
 # Converted import path (agent_framework version of FoundryAgentTemplate)
 from v4.magentic_agents.foundry_agent import FoundryAgentTemplate  # formerly v4.magentic_agents.foundry_agent
 from v4.config.agent_registry import agent_registry
 from common.config.app_config import config
 logging.basicConfig(level=logging.INFO)
 
+
 async def create_RAI_agent() -> FoundryAgentTemplate:
     """Create and initialize a FoundryAgentTemplate for Responsible AI (RAI) checks."""
     agent_name = "RAIAgent"
@@ -42,7 +42,7 @@ async def create_RAI_agent() -> FoundryAgentTemplate:
 
     try:
         agent_registry.register_agent(agent)
-    except Exception as registry_error:  
+    except Exception as registry_error:
         logging.warning(
             "Failed to register agent '%s' with registry: %s",
             agent.agent_name,
@@ -73,7 +73,7 @@ async def _get_agent_response(agent: FoundryAgentTemplate, query: str) -> str:
                     if txt:
                         parts.append(str(txt))
         return "".join(parts) if parts else ""
-    except Exception as e:  
+    except Exception as e:
         logging.error("Error streaming agent response: %s", e)
         return "TRUE"  # Default to blocking on error
 
@@ -93,22 +93,22 @@ async def rai_success(description: str) -> bool:
         response_text = await _get_agent_response(agent, description)
         verdict = response_text.strip().upper()
 
-        if "FALSE" in verdict: # any false in the response
+        if "FALSE" in verdict:  # any false in the response
             logging.info("RAI check passed.")
             return True
         else:
             logging.info("RAI check failed (blocked). Sample: %s...", description[:60])
             return False
 
-    except Exception as e:  
+    except Exception as e:
         logging.error("RAI check error: %s — blocking by default.", e)
         return False
     finally:
         # Ensure we close resources
         if agent:
             try:
                 await agent.close()
-            except Exception:  
+            except Exception:
                 pass
 
 
@@ -161,6 +161,6 @@ async def rai_validate_team_config(team_config_json: dict) -> tuple[bool, str]:
             )
 
         return True, ""
-    except Exception as e:  
+    except Exception as e:
         logging.error("Error validating team configuration content: %s", e)
-        return False, "Unable to validate team configuration content. Please try again."
+        return False, "Unable to validate team configuration content. Please try again."

src/backend/v4/api/router.py

@@ -55,7 +55,7 @@ async def find_first_available_team(team_service: TeamService, user_id: str) ->
         "00000000-0000-0000-0000-000000000002",  # Marketing
         "00000000-0000-0000-0000-000000000001",  # HR
     ]
-    
+
     for team_id in team_priority_order:
         try:
             team_config = await team_service.get_team_configuration(team_id, user_id)
@@ -65,7 +65,7 @@ async def find_first_available_team(team_service: TeamService, user_id: str) ->
         except Exception as e:
             print(f"Error checking team {team_id}: {str(e)}")
             continue
-    
+
     print("No teams found in priority order")
     return None
 
@@ -139,7 +139,7 @@ async def init_team(
         # Initialize memory store and service
         memory_store = await DatabaseFactory.get_database(user_id=user_id)
         team_service = TeamService(memory_store)
-        
+
         # Find the first available team from 4 to 1, or use HR as fallback
         init_team_id = await find_first_available_team(team_service, user_id)
         if not init_team_id:

src/backend/v4/callbacks/response_handlers.py

@@ -75,7 +75,7 @@ def agent_response_callback(
     """
     agent_name = getattr(message, "author_name", None) or agent_id or "Unknown Agent"
     role = getattr(message, "role", "assistant")
-    
+
     # FIX: Properly extract text from ChatMessage
     # ChatMessage has a .text property that concatenates all TextContent items
     text = ""
@@ -84,7 +84,7 @@ def agent_response_callback(
     else:
         # Fallback for non-ChatMessage objects
         text = str(getattr(message, "text", ""))
-    
+
     text = clean_citations(text or "")
 
     if not user_id:
@@ -105,9 +105,10 @@ def agent_response_callback(
             )
         )
         logger.info("%s message (agent=%s): %s", str(role).capitalize(), agent_name, text[:200])
-    except Exception as e:  
+    except Exception as e:
         logger.error("agent_response_callback error sending WebSocket message: %s", e)
 
+
 async def streaming_agent_response_callback(
     agent_id: str,
     update: AgentRunResponseUpdate,
@@ -157,5 +158,5 @@ async def streaming_agent_response_callback(
                 message_type=WebsocketMessageType.AGENT_MESSAGE_STREAMING,
             )
             logger.debug("Streaming chunk (agent=%s final=%s len=%d)", agent_id, is_final, len(cleaned))
-    except Exception as e:  
-        logger.error("streaming_agent_response_callback error: %s", e)
+    except Exception as e:
+        logger.error("streaming_agent_response_callback error: %s", e)

src/backend/v4/config/settings.py

@@ -14,7 +14,7 @@
 
 # agent_framework substitutes
 from agent_framework.azure import AzureOpenAIChatClient
-#from agent_framework_azure_ai import AzureOpenAIChatClient
+# from agent_framework_azure_ai import AzureOpenAIChatClient
 from agent_framework import ChatOptions
 
 from v4.models.messages import MPlan, WebsocketMessageType
@@ -341,4 +341,4 @@ def get_current_team(self, user_id: str) -> TeamConfiguration:
 mcp_config = MCPConfig()
 orchestration_config = OrchestrationConfig()
 connection_config = ConnectionConfig()
-team_config = TeamConfig()
+team_config = TeamConfig()

src/backend/v4/magentic_agents/common/lifecycle.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-import os
 from contextlib import AsyncExitStack
 from typing import Any, Optional
 
@@ -29,7 +28,7 @@ def __init__(self, mcp: MCPConfig | None = None) -> None:
         self._stack: AsyncExitStack | None = None
         self.mcp_cfg: MCPConfig | None = mcp
         self.mcp_tool: HostedMCPTool | None = None
-        self._agent: ChatAgent | None = None  
+        self._agent: ChatAgent | None = None
 
     async def open(self) -> "MCPEnabledBase":
         if self._stack is not None:
@@ -47,12 +46,12 @@ async def close(self) -> None:
             if self._agent and hasattr(self._agent, "close"):
                 try:
                     await self._agent.close()  # AzureAIAgentClient has async close
-                except Exception:  
+                except Exception:
                     pass
             # Unregister from registry if present
             try:
                 agent_registry.unregister_agent(self)
-            except Exception:  
+            except Exception:
                 pass
             await self._stack.aclose()
         finally:
@@ -89,7 +88,7 @@ async def _prepare_mcp_tool(self) -> None:
             )
             await self._stack.enter_async_context(mcp_tool)
             self.mcp_tool = mcp_tool  # Store for later use
-        except Exception:  
+        except Exception:
             self.mcp_tool = None
 
 
@@ -106,7 +105,7 @@ def __init__(self, mcp: MCPConfig | None = None, model_deployment_name: str | No
         super().__init__(mcp=mcp)
         self.creds: Optional[DefaultAzureCredential] = None
         self.client: Optional[AzureAIAgentClient] = None
-       
+
         self._created_ephemeral: bool = (
             False  # reserved if you add ephemeral agent cleanup
         )
@@ -118,7 +117,6 @@ async def open(self) -> "AzureAgentBase":
             return self
         self._stack = AsyncExitStack()
 
-
         # Acquire credential
         self.creds = DefaultAzureCredential()
         await self._stack.enter_async_context(self.creds)
@@ -130,7 +128,7 @@ async def open(self) -> "AzureAgentBase":
         #     async_credential=self.creds,
         # )
 
-        #Create AgentsClient
+        # Create AgentsClient
         self.client = AgentsClient(
             endpoint=self.project_endpoint,
             credential=self.creds,
@@ -146,7 +144,7 @@ async def open(self) -> "AzureAgentBase":
         # Register agent (best effort)
         try:
             agent_registry.register_agent(self)
-        except Exception:  
+        except Exception:
             pass
 
         return self
@@ -170,25 +168,25 @@ async def close(self) -> None:
             if self._agent and hasattr(self._agent, "close"):
                 try:
                     await self._agent.close()
-                except Exception:  
+                except Exception:
                     pass
 
             # Unregister from registry
             try:
                 agent_registry.unregister_agent(self)
-            except Exception:  
+            except Exception:
                 pass
 
             # Close credential and project client
             if self.client:
                 try:
                     await self.client.close()
-                except Exception:  
+                except Exception:
                     pass
             if self.creds:
                 try:
                     await self.creds.close()
-                except Exception:  
+                except Exception:
                     pass
 
         finally:

src/backend/v4/magentic_agents/foundry_agent.py

@@ -69,13 +69,10 @@ def _is_azure_search_requested(self) -> bool:
             return True
         return False
 
-
-
     async def _collect_tools(self) -> List:
         """Collect tool definitions for ChatAgent (MCP path only)."""
         tools: List = []
 
-
         # Code Interpreter (only in MCP path per incompatibility note)
         if self.enable_code_interpreter:
             try:
@@ -114,7 +111,6 @@ async def _create_azure_search_enabled_client(self):
             self.logger.error("Search configuration missing.")
             return None
 
-
         desired_connection_name = getattr(self.search, "connection_name", None)
         index_name = getattr(self.search, "index_name", "")
         query_type = getattr(self.search, "search_query_type", "simple")
@@ -143,7 +139,7 @@ async def _create_azure_search_enabled_client(self):
                     "connection_name=%s",
                     desired_connection_name,
                 )
-              #  return None
+            #  return None
 
             self.logger.info(
                 "Using Azure AI Search connection (id=%s, requested_name=%s).",
@@ -186,7 +182,7 @@ async def _create_azure_search_enabled_client(self):
 
             chat_client = AzureAIAgentClient(
                 project_client=self.project_client,
-                #agents_client=self.client,
+                # agents_client=self.client,
                 agent_id=azure_agent.id,
                 async_credential=self.creds,
             )
@@ -202,6 +198,7 @@ async def _create_azure_search_enabled_client(self):
     # -------------------------
     # Agent lifecycle override
     # -------------------------
+
     async def _after_open(self) -> None:
         """Initialize ChatAgent after connections are established."""
         try:
@@ -311,4 +308,4 @@ async def close(self) -> None:
 
 #     )
 #     await agent.open()
-#     return agent
+#     return agent

src/backend/v4/magentic_agents/magentic_agent_factory.py

@@ -108,7 +108,7 @@ async def create_agent_from_config(self, user_id: str, agent_obj: SimpleNamespac
                 agent_description=getattr(agent_obj, "description", ""),
                 agent_instructions=getattr(agent_obj, "system_message", ""),
                 model_deployment_name=deployment_name,
-                project_endpoint=project_endpoint, # type: ignore
+                project_endpoint=project_endpoint,  # type: ignore
                 search_config=search_config,
                 mcp_config=mcp_config,
             )

src/backend/v4/magentic_agents/models/agent_models.py

@@ -62,14 +62,12 @@ class SearchConfig:
     endpoint: str | None = None
     index_name: str | None = None
 
-
     @classmethod
     def from_env(cls, index_name: str) -> "SearchConfig":
         connection_name = config.AZURE_AI_SEARCH_CONNECTION_NAME
         index_name = index_name or config.AZURE_AI_SEARCH_INDEX_NAME
         endpoint = config.AZURE_AI_SEARCH_ENDPOINT
 
-
         # Raise exception if any required environment variable is missing
         if not all([connection_name, index_name, endpoint]):
             raise ValueError(