Refactor environment variable setup in tests

Author: NirajC-Microsoft

src/backend/tests/test_app.py

@@ -17,9 +17,9 @@
 os.environ["COSMOSDB_KEY"] = "mock-key"
 os.environ["COSMOSDB_DATABASE"] = "mock-database"
 os.environ["COSMOSDB_CONTAINER"] = "mock-container"
-os.environ["APPLICATIONINSIGHTS_CONNECTION_STRING"] = (
-    "InstrumentationKey=mock-instrumentation-key;IngestionEndpoint=https://mock-ingestion-endpoint"
-)
+os.environ[
+    "APPLICATIONINSIGHTS_CONNECTION_STRING"
+] = "InstrumentationKey=mock-instrumentation-key;IngestionEndpoint=https://mock-ingestion-endpoint"
 os.environ["AZURE_OPENAI_DEPLOYMENT_NAME"] = "mock-deployment-name"
 os.environ["AZURE_OPENAI_API_VERSION"] = "2023-01-01"
 os.environ["AZURE_OPENAI_ENDPOINT"] = "https://mock-openai-endpoint"
@@ -30,9 +30,7 @@
     sys.path.insert(0, ROOT_DIR)
 
 # Provide safe defaults for vars that app_config reads at import-time
-os.environ.setdefault(
-    "AZURE_AI_SUBSCRIPTION_ID", "00000000-0000-0000-0000-000000000000"
-)
+os.environ.setdefault("AZURE_AI_SUBSCRIPTION_ID", "00000000-0000-0000-0000-000000000000")
 os.environ.setdefault("AZURE_AI_RESOURCE_GROUP", "rg-test")
 os.environ.setdefault("AZURE_AI_PROJECT_NAME", "proj-test")
 os.environ.setdefault("AZURE_AI_AGENT_ENDPOINT", "https://agents.example.com/")
@@ -45,7 +43,6 @@
     except ModuleNotFoundError:
         # fallback to app_kernel which exists in this repo
         import importlib
-
         mod = importlib.import_module("src.backend.app_kernel")
         app = getattr(mod, "app", None)
         if app is None:
@@ -60,7 +57,6 @@
 
 from fastapi.routing import APIRoute
 
-
 def _find_input_task_path(app):
     for r in app.routes:
         if isinstance(r, APIRoute):
@@ -71,7 +67,6 @@ def _find_input_task_path(app):
                 return r.path
     return "/input_task"  # fallback
 
-
 INPUT_TASK_PATH = _find_input_task_path(app)
 
 
@@ -98,27 +93,27 @@ def test_input_task_invalid_json():
 def test_process_request_endpoint_success():
     """Test the /api/process_request endpoint with valid input."""
     headers = {"Authorization": "Bearer mock-token"}
-
+    
     # Mock the RAI success function
-    with patch("app_kernel.rai_success", return_value=True), patch(
-        "app_kernel.initialize_runtime_and_context"
-    ) as mock_init, patch("app_kernel.track_event_if_configured") as mock_track:
-
+    with patch("app_kernel.rai_success", return_value=True), \
+         patch("app_kernel.initialize_runtime_and_context") as mock_init, \
+         patch("app_kernel.track_event_if_configured") as mock_track:
+        
         # Mock memory store
         mock_memory_store = MagicMock()
         mock_init.return_value = (MagicMock(), mock_memory_store)
-
+        
         test_input = {
             "session_id": "test-session-123",
-            "description": "Create a marketing plan for our new product",
+            "description": "Create a marketing plan for our new product"
         }
-
+        
         response = client.post("/api/process_request", json=test_input, headers=headers)
-
+        
         # Print response details for debugging
         print(f"Response status: {response.status_code}")
         print(f"Response data: {response.json()}")
-
+        
         # Check response
         assert response.status_code == 200
         data = response.json()
@@ -127,27 +122,26 @@ def test_process_request_endpoint_success():
         assert "session_id" in data
         assert data["status"] == "Plan created successfully"
         assert data["session_id"] == "test-session-123"
-
+        
         # Verify memory store was called to add plan
         mock_memory_store.add_plan.assert_called_once()
 
 
 def test_process_request_endpoint_rai_failure():
     """Test the /api/process_request endpoint when RAI check fails."""
     headers = {"Authorization": "Bearer mock-token"}
-
+    
     # Mock the RAI failure
-    with patch("app_kernel.rai_success", return_value=False), patch(
-        "app_kernel.track_event_if_configured"
-    ) as mock_track:
-
+    with patch("app_kernel.rai_success", return_value=False), \
+         patch("app_kernel.track_event_if_configured") as mock_track:
+        
         test_input = {
             "session_id": "test-session-123",
-            "description": "This is an unsafe description",
+            "description": "This is an unsafe description"
         }
-
+        
         response = client.post("/api/process_request", json=test_input, headers=headers)
-
+        
         # Check response
         assert response.status_code == 400
         data = response.json()
@@ -158,23 +152,22 @@ def test_process_request_endpoint_rai_failure():
 def test_process_request_endpoint_harmful_content():
     """Test the /api/process_request endpoint with harmful content that should fail RAI."""
     headers = {"Authorization": "Bearer mock-token"}
-
+    
     # Mock the RAI failure for harmful content
-    with patch("app_kernel.rai_success", return_value=False), patch(
-        "app_kernel.track_event_if_configured"
-    ) as mock_track:
-
+    with patch("app_kernel.rai_success", return_value=False), \
+         patch("app_kernel.track_event_if_configured") as mock_track:
+        
         test_input = {
             "session_id": "test-session-456",
-            "description": "I want to kill my neighbors cat",
+            "description": "I want to kill my neighbors cat"
         }
-
+        
         response = client.post("/api/process_request", json=test_input, headers=headers)
-
+        
         # Print response details for debugging
         print(f"Response status: {response.status_code}")
         print(f"Response data: {response.json()}")
-
+        
         # Check response - should be 400 due to RAI failure
         assert response.status_code == 400
         data = response.json()
@@ -185,27 +178,26 @@ def test_process_request_endpoint_harmful_content():
 def test_process_request_endpoint_real_rai_check():
     """Test the /api/process_request endpoint with real RAI check (no mocking)."""
     headers = {"Authorization": "Bearer mock-token"}
-
+    
     # Don't mock RAI - let it run the real check
-    with patch("app_kernel.initialize_runtime_and_context") as mock_init, patch(
-        "app_kernel.track_event_if_configured"
-    ) as mock_track:
-
+    with patch("app_kernel.initialize_runtime_and_context") as mock_init, \
+         patch("app_kernel.track_event_if_configured") as mock_track:
+        
         # Mock memory store
         mock_memory_store = MagicMock()
         mock_init.return_value = (MagicMock(), mock_memory_store)
-
+        
         test_input = {
             "session_id": "test-session-789",
-            "description": "I want to kill my neighbors cat",
+            "description": "I want to kill my neighbors cat"
         }
-
+        
         response = client.post("/api/process_request", json=test_input, headers=headers)
-
+        
         # Print response details for debugging
         print(f"Real RAI Response status: {response.status_code}")
         print(f"Real RAI Response data: {response.json()}")
-
+        
         # This should fail with real RAI check
         assert response.status_code == 400
         data = response.json()