Refactor Azure config and token handling

Centralizes Azure configuration and access token retrieval in AppConfig, removing duplicate logic from JsonService and v3/config/settings.py. Updates environment sample and settings to use new config properties and methods for improved maintainability and consistency.

Author: Fr4nc3

src/backend/.env.sample

@@ -15,8 +15,11 @@ AZURE_AI_PROJECT_NAME=
 AZURE_AI_MODEL_DEPLOYMENT_NAME=gpt-4o
 APPLICATIONINSIGHTS_CONNECTION_STRING=
 AZURE_AI_AGENT_MODEL_DEPLOYMENT_NAME=gpt-4o
+AZURE_COGNITIVE_SERVICES="https://cognitiveservices.azure.com/.default"
 AZURE_AI_AGENT_ENDPOINT=
-APP_ENV="dev"
+AZURE_BING_CONNECTION_NAME=
+REASONING_MODEL_NAME=o3
+APP_ENV=dev
 
 BACKEND_API_URL=http://localhost:8000
-FRONTEND_SITE_NAME=http://127.0.0.1:3000
+FRONTEND_SITE_NAME=*

src/backend/common/config/app_config.py

@@ -17,6 +17,7 @@ class AppConfig:
 
     def __init__(self):
         """Initialize the application configuration with environment variables."""
+        self.logger = logging.getLogger(__name__)
         # Azure authentication settings
         self.AZURE_TENANT_ID = self._get_optional("AZURE_TENANT_ID")
         self.AZURE_CLIENT_ID = self._get_optional("AZURE_CLIENT_ID")
@@ -31,6 +32,14 @@ def __init__(self):
             "APPLICATIONINSIGHTS_CONNECTION_STRING"
         )
         self.APP_ENV = self._get_required("APP_ENV", "prod")
+        self.AZURE_AI_MODEL_DEPLOYMENT_NAME = self._get_required(
+            "AZURE_AI_MODEL_DEPLOYMENT_NAME", "gpt-4o"
+        )
+
+        self.AZURE_COGNITIVE_SERVICES = self._get_optional(
+            "AZURE_COGNITIVE_SERVICES", "https://cognitiveservices.azure.com/.default"
+        )
+
         # Azure OpenAI settings
         self.AZURE_OPENAI_DEPLOYMENT_NAME = self._get_required(
             "AZURE_OPENAI_DEPLOYMENT_NAME", "gpt-4o"
@@ -39,9 +48,10 @@ def __init__(self):
             "AZURE_OPENAI_API_VERSION", "2024-11-20"
         )
         self.AZURE_OPENAI_ENDPOINT = self._get_required("AZURE_OPENAI_ENDPOINT")
-        self.AZURE_OPENAI_SCOPES = [
-            f"{self._get_optional('AZURE_OPENAI_SCOPE', 'https://cognitiveservices.azure.com/.default')}"
-        ]
+        self.REASONING_MODEL_NAME = self._get_optional("REASONING_MODEL_NAME", "o3")
+        self.AZURE_BING_CONNECTION_NAME = self._get_optional(
+            "AZURE_BING_CONNECTION_NAME"
+        )
 
         # Frontend settings
         self.FRONTEND_SITE_NAME = self._get_optional(
@@ -70,6 +80,16 @@ def get_azure_credentials(self):
             self._azure_credentials = get_azure_credential()
         return self._azure_credentials
 
+    async def get_access_token(self) -> str:
+        """Get Azure access token for API calls."""
+        try:
+            credential = get_azure_credential()
+            token = credential.get_token(self.AZURE_COGNITIVE_SERVICES)
+            return token.token
+        except Exception as e:
+            self.logger.error(f"Failed to get access token: {e}")
+            raise
+
     def _get_required(self, name: str, default: Optional[str] = None) -> str:
         """Get a required configuration value from environment variables.
 

src/backend/common/services/json_service.py

@@ -283,16 +283,6 @@ async def delete_team_configuration(self, team_id: str, user_id: str) -> bool:
     # Model validation methods
     # -----------------------
 
-    async def get_access_token(self) -> str:
-        """Get Azure access token for API calls."""
-        try:
-            credential = get_azure_credential()
-            token = credential.get_token("https://management.azure.com/.default")
-            return token.token
-        except Exception as e:
-            self.logger.error(f"Failed to get access token: {e}")
-            raise
-
     async def list_model_deployments(self) -> List[Dict[str, Any]]:
         """
         List all model deployments in the Azure AI project using the REST API.

src/backend/common/utils/utils_kernel.py

@@ -11,6 +11,7 @@
 
 # Import the credential utility
 from common.auth.azure_credential_utils import get_azure_credential
+from common.config.app_config import config
 
 # Import agent factory and the new AppConfig
 from semantic_kernel.agents.azure_ai.azure_ai_agent import AzureAIAgent
@@ -34,14 +35,11 @@ async def rai_success(description: str, is_task_creation: bool) -> bool:
     """
     try:
         # Use managed identity for authentication to Azure OpenAI
-        credential = get_azure_credential()
-        access_token = credential.get_token(
-            "https://cognitiveservices.azure.com/.default"
-        ).token
-
-        CHECK_ENDPOINT = os.getenv("AZURE_OPENAI_ENDPOINT")
-        API_VERSION = os.getenv("AZURE_OPENAI_API_VERSION")
-        DEPLOYMENT_NAME = os.getenv("AZURE_OPENAI_MODEL_NAME")
+        access_token = await config.get_access_token()
+
+        CHECK_ENDPOINT = config.AZURE_OPENAI_ENDPOINT
+        API_VERSION = config.AZURE_OPENAI_API_VERSION
+        DEPLOYMENT_NAME = config.AZURE_AI_MODEL_DEPLOYMENT_NAME
 
         if not all([CHECK_ENDPOINT, API_VERSION, DEPLOYMENT_NAME]):
             logging.error("Missing required environment variables for RAI check")

src/backend/v3/config/settings.py

@@ -10,33 +10,20 @@
     AzureChatCompletion,
     OpenAIChatPromptExecutionSettings,
 )
-
-# Load environment variables
-load_dotenv()
-
-# Azure configuration
-TENANT_ID = ""
-CLIENT_ID = ""
+from common.config.app_config import config
 
 
 class AzureConfig:
     """Azure OpenAI and authentication configuration."""
 
     def __init__(self):
-        self.endpoint = os.getenv("AZURE_OPENAI_ENDPOINT")
-        self.reasoning_model = os.getenv("REASONING_MODEL_NAME", "o3")
-        self.standard_model = os.getenv("AZURE_OPENAI_DEPLOYMENT_NAME", "gpt-4")
-        self.bing_connection_name = os.getenv("BING_CONNECTION_NAME")
+        self.endpoint = config.AZURE_OPENAI_ENDPOINT
+        self.reasoning_model = config.REASONING_MODEL_NAME
+        self.standard_model = config.AZURE_OPENAI_DEPLOYMENT_NAME
+        self.bing_connection_name = config.AZURE_BING_CONNECTION_NAME
 
         # Create credential
-        self.credential = SyncDefaultAzureCredential()
-
-    def get_azure_token(self):
-        """Get Azure token for authentication."""
-        token = self.credential.get_token(
-            "https://cognitiveservices.azure.com/.default"
-        )
-        return token.token
+        self.credential = config.get_azure_credentials()
 
     def create_chat_completion_service(self, use_reasoning_model=False):
         """Create Azure Chat Completion service."""
@@ -47,7 +34,7 @@ def create_chat_completion_service(self, use_reasoning_model=False):
         return AzureChatCompletion(
             deployment_name=model_name,
             endpoint=self.endpoint,
-            ad_token_provider=self.get_azure_token,
+            ad_token_provider=config.get_access_token(),
         )
 
     def create_execution_settings(self):