Merge pull request #684 from microsoft/psl-macae-rfp-agent-pylint

style: formatting fixes and import cleanup for pylint compliance

Author: Roopan-Microsoft

src/backend/common/database/cosmosdb.py

@@ -495,7 +495,7 @@ async def get_agent_messages(self, plan_id: str) -> List[AgentMessageData]:
 
     async def add_team_agent(self, team_agent: CurrentTeamAgent) -> None:
         """Add an agent message to the database."""
-        await self.delete_team_agent(team_agent.team_id, team_agent.agent_name) # Ensure no duplicates
+        await self.delete_team_agent(team_agent.team_id, team_agent.agent_name)  # Ensure no duplicates
         await self.add_item(team_agent)
 
     async def delete_team_agent(self, team_id: str, agent_name: str) -> None:

src/backend/common/models/messages_af.py

@@ -112,6 +112,7 @@ class UserCurrentTeam(BaseDataModel):
     user_id: str
     team_id: str
 
+
 class CurrentTeamAgent(BaseDataModel):
     """Represents the current agent of a user."""
     data_type: Literal[DataType.current_team_agent] = DataType.current_team_agent
@@ -123,7 +124,6 @@ class CurrentTeamAgent(BaseDataModel):
     agent_foundry_id: str
 
 
-
 class Plan(BaseDataModel):
     """Represents a plan containing multiple steps."""
     data_type: Literal[DataType.plan] = DataType.plan

src/backend/v4/api/router.py

@@ -232,10 +232,10 @@ async def process_request(
     authenticated_user = get_authenticated_user_details(request_headers=request.headers)
     user_id = authenticated_user["user_principal_id"]
     if not user_id:
-      track_event_if_configured(
-          "UserIdNotFound", {"status_code": 400, "detail": "no user"}
-      )
-      raise HTTPException(status_code=400, detail="no user found")
+        track_event_if_configured(
+            "UserIdNotFound", {"status_code": 400, "detail": "no user"}
+        )
+        raise HTTPException(status_code=400, detail="no user found")
     try:
         memory_store = await DatabaseFactory.get_database(user_id=user_id)
         user_current_team = await memory_store.get_current_team(user_id=user_id)
@@ -253,7 +253,7 @@ async def process_request(
             status_code=400,
             detail=f"Error retrieving team configuration: {e}",
         ) from e
-    
+
     if not await rai_success(input_task.description, team, memory_store):
         track_event_if_configured(
             "RAI failed",
@@ -268,7 +268,6 @@ async def process_request(
             detail="Request contains content that doesn't meet our safety guidelines, try again.",
         )
 
-
     if not input_task.session_id:
         input_task.session_id = str(uuid.uuid4())
     try:
@@ -705,10 +704,10 @@ async def upload_team_config(
     authenticated_user = get_authenticated_user_details(request_headers=request.headers)
     user_id = authenticated_user["user_principal_id"]
     if not user_id:
-      track_event_if_configured(
-          "UserIdNotFound", {"status_code": 400, "detail": "no user"}
-      )
-      raise HTTPException(status_code=400, detail="no user found")
+        track_event_if_configured(
+            "UserIdNotFound", {"status_code": 400, "detail": "no user"}
+        )
+        raise HTTPException(status_code=400, detail="no user found")
     try:
         memory_store = await DatabaseFactory.get_database(user_id=user_id)
 

src/backend/v4/magentic_agents/common/lifecycle.py

@@ -1,8 +1,6 @@
 from __future__ import annotations
 
 import logging
-import secrets
-import string
 from contextlib import AsyncExitStack
 from typing import Any, Optional
 

src/backend/v4/magentic_agents/foundry_agent.py

@@ -124,7 +124,7 @@ async def _create_azure_search_enabled_client(self, chatClient=None) -> Optional
         """
         if chatClient:
             return chatClient
-        
+
         if not self.search:
             self.logger.error("Search configuration missing.")
             return None
@@ -229,10 +229,9 @@ async def _after_open(self) -> None:
             self.logger.info("Initializing agent in Foundry mode.")
             temp = 0.1
 
-
         try:
-            chatClient= await self.get_database_team_agent()
-            
+            chatClient = await self.get_database_team_agent()
+
             if self._use_azure_search:
                 # Azure Search mode (skip MCP + Code Interpreter due to incompatibility)
                 self.logger.info(
@@ -272,7 +271,7 @@ async def _after_open(self) -> None:
                 )
 
             self.logger.info("Initialized ChatAgent '%s'", self.agent_name)
-            if not chatClient: # Only save if we didn't load from DB
+            if not chatClient:  # Only save if we didn't load from DB
                 await self.save_database_team_agent()
 
         except Exception as ex:

src/backend/v4/orchestration/orchestration_manager.py

@@ -22,10 +22,7 @@
 from common.models.messages_af import TeamConfiguration
 
 from common.database.database_base import DatabaseBase
-from common.utils.utils_agents import (
-    generate_assistant_id,
-    get_database_team_agent_id,
-)
+
 from v4.common.services.team_service import TeamService
 from v4.callbacks.response_handlers import (
     agent_response_callback,
@@ -76,15 +73,11 @@ async def init_orchestration(
         # Create Azure AI Agent client for orchestration using config
         # This replaces AzureChatCompletion from SK
         agent_name = team_config.name if team_config.name else "OrchestratorAgent"
-        db_agent_id = await get_database_team_agent_id(
-            memory_store, team_config, agent_name
-        )
-        agent_id = db_agent_id or generate_assistant_id()
+
         try:
             chat_client = AzureAIAgentClient(
                 project_endpoint=config.AZURE_AI_PROJECT_ENDPOINT,
                 model_deployment_name=team_config.deployment_name,
-               # agent_id=agent_id,
                 agent_name=agent_name,
                 async_credential=credential,
             )
@@ -312,7 +305,6 @@ async def run_orchestration(self, user_id: str, input_task) -> None:
             final_output: str | None = None
 
             self.logger.info("Starting workflow execution...")
-            thread_id = f"task-{job_id}"
             async for event in workflow.run_stream(task_text):
                 try:
                     # Handle orchestrator messages (task assignments, coordination)