Skip to content

Conversation

@Dhruvkumar-Microsoft
Copy link
Contributor

Purpose

This pull request updates the way plans are retrieved by team and status to require a user_id parameter instead of relying on an internal value. The change ensures that queries for plans are correctly filtered by user, improving data accuracy and consistency across the API and database layers.

Database and API consistency improvements:

  • Updated the abstract method signature in database_base.py to require a user_id parameter for retrieving plans by team and status, ensuring all implementations follow the same contract.
  • Modified the implementation in cosmosdb.py to accept user_id as an argument and use it in the query parameters, rather than relying on an internal instance value.
  • Updated the API endpoint in router.py to pass the user_id argument when retrieving completed plans for a team, aligning the API usage with the updated method signature.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit d099e6a into macae-v3-dev-v2-vip Sep 19, 2025
2 of 3 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Dhruvkumar-Microsoft Dhruvkumar-Microsoft deleted the psl-bug-leftpanelissue branch September 24, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants