Updates tag names for actions/functions operations (#586)

* Update operation tags generation

* Refactor operation tag generation

* Update unit tests

* Update integration test files

* Update release note

* Update src/Microsoft.OpenApi.OData.Reader/Operation/EdmOperationOperationHandler.cs

Co-authored-by: Andrew Omondi <[email protected]>

* Account for nullability

* Remove unnecessary code

---------

Co-authored-by: Andrew Omondi <[email protected]>

Author: 2 people

src/Microsoft.OpenApi.OData.Reader/Microsoft.OpenAPI.OData.Reader.csproj

@@ -21,8 +21,13 @@
     <PackageTags>Microsoft OpenApi OData EDM</PackageTags>
     <RepositoryUrl>https://github.com/Microsoft/OpenAPI.NET.OData</RepositoryUrl>
     <PackageReleaseNotes>
-    - Further fix for generating unique operation ids for navigation property paths with composable overloaded functions #596
-    </PackageReleaseNotes>
+		- Upgraded to Microsoft.Odata.Edm 8.0.0
+		- Cleaned up obsolete APIs
+		- Changed target framework to net8.0
+		- Adds support for retrieving collection of enum values from UpdateMethod property of UpdateRestrictions annotation #564
+		- Adds nullable to double schema conversions #581
+		- Updates tag names for actions/functions operations #585
+	</PackageReleaseNotes>
     <AssemblyName>Microsoft.OpenApi.OData.Reader</AssemblyName>
     <AssemblyOriginatorKeyFile>..\..\tool\Microsoft.OpenApi.OData.snk</AssemblyOriginatorKeyFile>
     <OutputPath Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">..\..\bin\Debug\</OutputPath>

src/Microsoft.OpenApi.OData.Reader/Operation/EdmOperationOperationHandler.cs

@@ -81,7 +81,6 @@ protected override void SetBasicInfo(OpenApiOperation operation)
                 // duplicates in entity vs entityset functions/actions
 
                 List<string> identifiers = new();
-                string pathHash = string.Empty;
                 foreach (ODataSegment segment in Path.Segments)
                 {
                     if (segment is ODataKeySegment keySegment)
@@ -102,18 +101,6 @@ protected override void SetBasicInfo(OpenApiOperation operation)
                             identifiers.Add(keySegment.Identifier);
                         }
                     }
-                    else if (segment is ODataOperationSegment opSegment)
-                    {
-                        if (opSegment.Operation is IEdmFunction function && Context.Model.IsOperationOverload(function))
-                        {
-                            // Hash the segment to avoid duplicate operationIds
-                            pathHash = string.IsNullOrEmpty(pathHash)
-                                ? opSegment.GetPathHash(Context.Settings)
-                                : (pathHash + opSegment.GetPathHash(Context.Settings)).GetHashSHA256().Substring(0, 4);
-                        }
-
-                        identifiers.Add(segment.Identifier);
-                    }
                     else
                     {
                         identifiers.Add(segment.Identifier);
@@ -122,13 +109,21 @@ protected override void SetBasicInfo(OpenApiOperation operation)
 
                 string operationId = string.Join(".", identifiers);
 
-                if (!string.IsNullOrEmpty(pathHash))
+                if (EdmOperation.IsAction())
                 {
-                    operation.OperationId = operationId + "-" + pathHash;
+                    operation.OperationId = operationId;
                 }
                 else
                 {
-                    operation.OperationId = operationId;
+                    if (Path.LastSegment is ODataOperationSegment operationSegment &&
+                        Context.Model.IsOperationOverload(operationSegment.Operation))
+                    {
+                        operation.OperationId = operationId + "-" + Path.LastSegment.GetPathHash(Context.Settings);
+                    }
+                    else
+                    {
+                        operation.OperationId = operationId;
+                    }
                 }
             }
 
@@ -174,7 +169,7 @@ private void GenerateTagName(out string tagName, int skip = 1)
                     break;
                 // ODataNavigationSourceSegment
                 default:
-                    tagName = NavigationSource.Name + "." + NavigationSource.EntityType().Name;
+                    tagName = NavigationSource.Name + "." + NavigationSource.EntityType.Name;
                     break;
             }
         }