fix: copy of extensions for schemas

baywet · baywet · commit 9eea9da9617a · 2024-12-31T14:58:41.000-05:00
Signed-off-by: Vincent Biret &lt;vibiret@microsoft.com&gt;
diff --git a/src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiSchemaGenerator.cs b/src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiSchemaGenerator.cs
@@ -425,7 +425,8 @@ public static IDictionary<string, OpenApiSchema> CreateStructuredTypePropertiesS
             {
                 OpenApiSchema propertySchema = context.CreatePropertySchema(property, document);
                 propertySchema.Description = context.Model.GetDescriptionAnnotation(property);
-                propertySchema.Extensions ??= new Dictionary<string, IOpenApiExtension>();
+                // we always want a new copy because it's a reference
+                propertySchema.Extensions = propertySchema.Extensions is null ? [] : new Dictionary<string, IOpenApiExtension>(propertySchema.Extensions);
                 propertySchema.Extensions.AddCustomAttributesToExtensions(context, property);
                 properties.Add(property.Name, propertySchema);
             }
@@ -435,7 +436,8 @@ public static IDictionary<string, OpenApiSchema> CreateStructuredTypePropertiesS
             {
                 OpenApiSchema propertySchema = context.CreateEdmTypeSchema(property.Type, document);
                 propertySchema.Description = context.Model.GetDescriptionAnnotation(property);
-                propertySchema.Extensions ??= new Dictionary<string, IOpenApiExtension>();
+                // we always want a new copy because it's a reference
+                propertySchema.Extensions = propertySchema.Extensions is null ? [] : new Dictionary<string, IOpenApiExtension>(propertySchema.Extensions);
                 propertySchema.Extensions.AddCustomAttributesToExtensions(context, property);
                 propertySchema.Extensions.Add(Constants.xMsNavigationProperty, new OpenApiAny(true));
                 properties.Add(property.Name, propertySchema);

Original file line number	Diff line number	Diff line change
`@@ -425,7 +425,8 @@ public static IDictionary<string, OpenApiSchema> CreateStructuredTypePropertiesS`
`425`	`425`	`{`
`426`	`426`	`OpenApiSchema propertySchema = context.CreatePropertySchema(property, document);`
`427`	`427`	`propertySchema.Description = context.Model.GetDescriptionAnnotation(property);`
`428`		`- propertySchema.Extensions ??= new Dictionary<string, IOpenApiExtension>();`
	`428`	`+ // we always want a new copy because it's a reference`
	`429`	`+ propertySchema.Extensions = propertySchema.Extensions is null ? [] : new Dictionary<string, IOpenApiExtension>(propertySchema.Extensions);`
`429`	`430`	`propertySchema.Extensions.AddCustomAttributesToExtensions(context, property);`
`430`	`431`	`properties.Add(property.Name, propertySchema);`
`431`	`432`	`}`
`@@ -435,7 +436,8 @@ public static IDictionary<string, OpenApiSchema> CreateStructuredTypePropertiesS`
`435`	`436`	`{`
`436`	`437`	`OpenApiSchema propertySchema = context.CreateEdmTypeSchema(property.Type, document);`
`437`	`438`	`propertySchema.Description = context.Model.GetDescriptionAnnotation(property);`
`438`		`- propertySchema.Extensions ??= new Dictionary<string, IOpenApiExtension>();`
	`439`	`+ // we always want a new copy because it's a reference`
	`440`	`+ propertySchema.Extensions = propertySchema.Extensions is null ? [] : new Dictionary<string, IOpenApiExtension>(propertySchema.Extensions);`
`439`	`441`	`propertySchema.Extensions.AddCustomAttributesToExtensions(context, property);`
`440`	`442`	`propertySchema.Extensions.Add(Constants.xMsNavigationProperty, new OpenApiAny(true));`
`441`	`443`	`properties.Add(property.Name, propertySchema);`