Ensure unique operation ids for composable functions with both overloaded

irvinesunday · irvinesunday · commit e704f822d1cd · 2024-10-11T12:18:52.000+03:00
diff --git a/src/Microsoft.OpenApi.OData.Reader/Operation/EdmOperationOperationHandler.cs b/src/Microsoft.OpenApi.OData.Reader/Operation/EdmOperationOperationHandler.cs
@@ -107,7 +107,9 @@ protected override void SetBasicInfo(OpenApiOperation operation)
                         if (opSegment.Operation is IEdmFunction function && Context.Model.IsOperationOverload(function))
                         {
                             // Hash the segment to avoid duplicate operationIds
-                            pathHash = segment.GetPathHash(Context.Settings);
+                            pathHash = string.IsNullOrEmpty(pathHash)
+                                ? opSegment.GetPathHash(Context.Settings)
+                                : (pathHash + opSegment.GetPathHash(Context.Settings)).GetHashSHA256()[..4];
                         }
 
                         identifiers.Add(segment.Identifier);

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,9 @@ protected override void SetBasicInfo(OpenApiOperation operation)`
`107`	`107`	`if (opSegment.Operation is IEdmFunction function && Context.Model.IsOperationOverload(function))`
`108`	`108`	`{`
`109`	`109`	`// Hash the segment to avoid duplicate operationIds`
`110`		`- pathHash = segment.GetPathHash(Context.Settings);`
	`110`	`+ pathHash = string.IsNullOrEmpty(pathHash)`
	`111`	`+ ? opSegment.GetPathHash(Context.Settings)`
	`112`	`+ : (pathHash + opSegment.GetPathHash(Context.Settings)).GetHashSHA256()[..4];`
`111`	`113`	`}`
`112`	`114`
`113`	`115`	`identifiers.Add(segment.Identifier);`