Code cleanup

Author: MaggieKimani1

src/Microsoft.OpenApi.Tool/OpenApiService.cs

@@ -31,6 +31,10 @@ public static void ProcessOpenApiDocument(
             {
                 throw new ArgumentNullException(nameof(input));
             }
+            if(output == null)
+            {
+                throw new ArgumentException(nameof(output));
+            }
             if (output.Exists)
             {
                 throw new IOException("The file you're writing to already exists. Please input a new output path.");
@@ -123,7 +127,6 @@ internal static void ValidateOpenApiDocument(string input)
 
             document = new OpenApiStreamReader(new OpenApiReaderSettings
             {
-                //ReferenceResolution = resolveExternal == true ? ReferenceResolutionSetting.ResolveAllReferences : ReferenceResolutionSetting.ResolveLocalReferences,
                 RuleSet = ValidationRuleSet.GetDefaultRuleSet()
             }
             ).Read(stream, out var context);

src/Microsoft.OpenApi/Services/OpenApiFilterService.cs

@@ -75,7 +75,7 @@ public static OpenApiDocument CreateFilteredDocument(OpenApiDocument source, Fun
             foreach (var result in results)
             {
                 OpenApiPathItem pathItem;
-                string pathKey = result.CurrentKeys.Path;
+                var pathKey = result.CurrentKeys.Path;
 
                 if (subset.Paths == null)
                 {

src/Microsoft.OpenApi/Services/OperationSearch.cs

@@ -8,13 +8,23 @@
 
 namespace Microsoft.OpenApi.Services
 {
+    /// <summary>
+    /// Visits OpenApi operations and parameters.
+    /// </summary>
     public class OperationSearch : OpenApiVisitorBase
     {
         private readonly Func<OpenApiOperation, bool> _predicate;
         private readonly List<SearchResult> _searchResults = new();
 
+        /// <summary>
+        /// A list of operations from the operation search.
+        /// </summary>
         public IList<SearchResult> SearchResults => _searchResults;
 
+        /// <summary>
+        /// The OperationSearch constructor.
+        /// </summary>
+        /// <param name="predicate">A predicate function.</param>
         public OperationSearch(Func<OpenApiOperation, bool> predicate)
         {
             _predicate = predicate ?? throw new ArgumentNullException(nameof(predicate));

src/Microsoft.OpenApi/Services/SearchResult.cs

@@ -5,9 +5,19 @@
 
 namespace Microsoft.OpenApi.Services
 {
+    /// <summary>
+    /// Defines a search result model for visited operations.
+    /// </summary>
     public class SearchResult
     {
+        /// <summary>
+        /// An object containing contextual information based on where the walker is currently referencing in an OpenApiDocument.
+        /// </summary>
         public CurrentKeys CurrentKeys { get; set; }
+
+        /// <summary>
+        /// An Operation object.
+        /// </summary>
         public OpenApiOperation Operation { get; set; }
     }
 }

test/Microsoft.OpenApi.Tests/Workspaces/OpenApiWorkspaceTests.cs

@@ -1,5 +1,5 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
-// Licensed under the MIT license. 
+// Licensed under the MIT license.
 
 using System;
 using System.Collections.Generic;
@@ -12,7 +12,7 @@
 
 namespace Microsoft.OpenApi.Tests
 {
-    
+
     public class OpenApiWorkspaceTests
     {
         [Fact]
@@ -61,7 +61,7 @@ public void OpenApiWorkspacesAllowDocumentsToReferenceEachOther()
                                 }
                             }
                         }
-                    } 
+                    }
                 }
             });
             workspace.AddDocument("common", new OpenApiDocument() {
@@ -111,7 +111,7 @@ public void OpenApiWorkspacesAllowDocumentsToReferenceEachOther_short()
                       re.CreateContent("application/json", co =>
                           co.Schema = new OpenApiSchema()
                           {
-                              Reference = new OpenApiReference()  // Reference 
+                              Reference = new OpenApiReference()  // Reference
                               {
                                   Id = "test",
                                   Type = ReferenceType.Schema,
@@ -150,6 +150,7 @@ public void OpenApiWorkspacesShouldNormalizeDocumentLocations()
         // Enable Workspace to load from any reader, not just streams.
 
         // Test fragments
+        [Fact]
         public void OpenApiWorkspacesShouldLoadDocumentFragments()
         {
             Assert.True(false);