Update src/Microsoft.OpenApi/Reader/Services/OpenApiRemoteReferenceCollector.cs

MaggieKimani1 · baywet · web-flow · commit 01762349d844 · 2025-03-10T17:25:35.000+03:00
Co-authored-by: Vincent Biret &lt;vibiret@microsoft.com&gt;
diff --git a/src/Microsoft.OpenApi/Reader/Services/OpenApiRemoteReferenceCollector.cs b/src/Microsoft.OpenApi/Reader/Services/OpenApiRemoteReferenceCollector.cs
@@ -37,8 +37,7 @@ public override void Visit(IOpenApiReferenceHolder referenceHolder)
         /// </summary>
         private void AddExternalReferences(OpenApiReference? reference)
         {
-            var externalResource = reference?.ExternalResource;
-            if (reference is {IsExternal: true} && externalResource is not null &&
+            if (reference is {IsExternal: true} && reference.ExternalResource is {} externalResource&&
                 !_references.ContainsKey(externalResource))
             {
                 _references.Add(externalResource, reference);

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,7 @@ public override void Visit(IOpenApiReferenceHolder referenceHolder)`
`37`	`37`	`/// </summary>`
`38`	`38`	`private void AddExternalReferences(OpenApiReference? reference)`
`39`	`39`	`{`
`40`		`- var externalResource = reference?.ExternalResource;`
`41`		`- if (reference is {IsExternal: true} && externalResource is not null &&`
	`40`	`+ if (reference is {IsExternal: true} && reference.ExternalResource is {} externalResource&&`
`42`	`41`	`!_references.ContainsKey(externalResource))`
`43`	`42`	`{`
`44`	`43`	`_references.Add(externalResource, reference);`