Skip to content

Commit 0ed8e45

Browse files
authored
Apply suggestions from code review
1 parent e585f4c commit 0ed8e45

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/Microsoft.OpenApi/Helpers/SchemaSerializerHelper.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ internal static void WriteAsItemsProperties(JsonSchema schema,
1818
IDictionary<string, IOpenApiExtension> extensions,
1919
OpenApiSpecVersion version)
2020
{
21+
Utils.CheckArgumentNull(writer);
2122
// type
2223
if (schema.GetJsonType() != null)
2324
{

src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -592,14 +592,14 @@ public void WriteJsonSchemaWithoutReference(IOpenApiWriter writer, JsonSchema sc
592592
}
593593

594594
/// <inheritdoc />
595-
public void WriteJsonSchemaReference(IOpenApiWriter writer, Uri referenceUri, OpenApiSpecVersion version)
595+
public void WriteJsonSchemaReference(IOpenApiWriter writer, Uri reference, OpenApiSpecVersion version)
596596
{
597-
var reference = version.Equals(OpenApiSpecVersion.OpenApi2_0)
598-
? referenceUri.OriginalString.Replace("components/schemas", "definitions")
599-
: referenceUri.OriginalString;
597+
var referenceItem = version.Equals(OpenApiSpecVersion.OpenApi2_0)
598+
? reference.OriginalString.Replace("components/schemas", "definitions")
599+
: reference.OriginalString;
600600

601601
WriteStartObject();
602-
this.WriteProperty(OpenApiConstants.DollarRef, reference);
602+
this.WriteProperty(OpenApiConstants.DollarRef, referenceItem);
603603
WriteEndObject();
604604
}
605605
}

0 commit comments

Comments
 (0)