- enables all mode analysis

Signed-off-by: Vincent Biret <[email protected]>

Author: baywet

.vscode/settings.json

@@ -5,6 +5,7 @@
         "titleBar.activeForeground": "#F0FCFE"
     },
     "cSpell.words": [
+        "csdl",
         "Hidi"
     ]
 }

src/Microsoft.OpenApi.Hidi/Formatters/PowerShellFormatter.cs

@@ -88,7 +88,7 @@ public override void Visit(OpenApiOperation operation)
         private static string ResolveVerbSegmentInOpertationId(string operationId)
         {
             var charPos = operationId.LastIndexOf('.', operationId.Length - 1);
-            if (operationId.Contains('_') || charPos < 0)
+            if (operationId.Contains('_', StringComparison.OrdinalIgnoreCase) || charPos < 0)
                 return operationId;
             var newOperationId = new StringBuilder(operationId);
             newOperationId[charPos] = '_';
@@ -99,7 +99,7 @@ private static string ResolveVerbSegmentInOpertationId(string operationId)
         private static string ResolvePutOperationId(string operationId)
         {
             return operationId.Contains(DefaultPutPrefix, StringComparison.OrdinalIgnoreCase) ?
-                operationId.Replace(DefaultPutPrefix, PowerShellPutPrefix) : operationId;
+                operationId.Replace(DefaultPutPrefix, PowerShellPutPrefix, StringComparison.Ordinal) : operationId;
         }
 
         private static string ResolveByRefOperationId(string operationId)

src/Microsoft.OpenApi.Hidi/Handlers/PluginCommandHandler.cs

@@ -31,7 +31,7 @@ public async Task<int> InvokeAsync(InvocationContext context)
             var logger = loggerFactory.CreateLogger<PluginCommandHandler>();
             try
             {
-                await OpenApiService.PluginManifest(hidiOptions, logger, cancellationToken);
+                await OpenApiService.PluginManifest(hidiOptions, logger, cancellationToken).ConfigureAwait(false);
 
                 return 0;
             }

src/Microsoft.OpenApi.Hidi/Handlers/ShowCommandHandler.cs

@@ -31,7 +31,7 @@ public async Task<int> InvokeAsync(InvocationContext context)
             var logger = loggerFactory.CreateLogger<ShowCommandHandler>();
             try
             {
-                await OpenApiService.ShowOpenApiDocument(hidiOptions, logger, cancellationToken);
+                await OpenApiService.ShowOpenApiDocument(hidiOptions, logger, cancellationToken).ConfigureAwait(false);
 
                 return 0;
             }

src/Microsoft.OpenApi.Hidi/Handlers/TransformCommandHandler.cs

@@ -31,7 +31,7 @@ public async Task<int> InvokeAsync(InvocationContext context)
             var logger = loggerFactory.CreateLogger<TransformCommandHandler>();
             try
             {
-                await OpenApiService.TransformOpenApiDocument(hidiOptions, logger, cancellationToken);
+                await OpenApiService.TransformOpenApiDocument(hidiOptions, logger, cancellationToken).ConfigureAwait(false);
 
                 return 0;
             }

src/Microsoft.OpenApi.Hidi/Handlers/ValidateCommandHandler.cs

@@ -33,7 +33,7 @@ public async Task<int> InvokeAsync(InvocationContext context)
             try
             {
                 if (hidiOptions.OpenApi is null) throw new InvalidOperationException("OpenApi file is required");
-                await OpenApiService.ValidateOpenApiDocument(hidiOptions.OpenApi, logger, cancellationToken);
+                await OpenApiService.ValidateOpenApiDocument(hidiOptions.OpenApi, logger, cancellationToken).ConfigureAwait(false);
                 return 0;
             }
             catch (Exception ex)

src/Microsoft.OpenApi.Hidi/Logger.cs

@@ -5,7 +5,7 @@
 
 namespace Microsoft.OpenApi.Hidi
 {
-    public class Logger
+    public static class Logger
     {
         public static ILoggerFactory ConfigureLogger(LogLevel logLevel)
         {

src/Microsoft.OpenApi.Hidi/Microsoft.OpenApi.Hidi.csproj

@@ -28,9 +28,10 @@
     <SignAssembly>true</SignAssembly>
     <!-- https://github.com/dotnet/sourcelink/blob/main/docs/README.md#embeduntrackedsources -->
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
-    <NoWarn>NU5048</NoWarn>
+    <NoWarn>NU5048;CA1848;</NoWarn>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <PackageReadmeFile>readme.md</PackageReadmeFile>
+    <AnalysisMode>All</AnalysisMode>
   </PropertyGroup>
 
   <ItemGroup>

src/Microsoft.OpenApi.Hidi/OpenApiService.cs

@@ -17,7 +17,7 @@ static async Task<int> Main(string[] args)
             var rootCommand = CreateRootCommand();
 
             // Parse the incoming args and invoke the handler
-            return await rootCommand.InvokeAsync(args);
+            return await rootCommand.InvokeAsync(args).ConfigureAwait(false);
         }
 
         internal static RootCommand CreateRootCommand()