#319 - changes as per review comments

Author: senthilkumarmohan

src/Microsoft.OpenApi.Readers/V2/OpenApiDocumentDeserializer.cs

@@ -139,7 +139,7 @@ private static void MakeServers(IList<OpenApiServer> servers, ParsingContext con
             //Validate host
             if (host != null && !IsHostValid(host))
             {
-                rootNode.Diagnostic.Errors.Add(new OpenApiError(new OpenApiException("Invalid host")));
+                rootNode.Diagnostic.Errors.Add(new OpenApiError(rootNode.Context.GetLocation(), "Invalid host"));
                 return;
             }
 
@@ -255,22 +255,15 @@ private static void FixRequestBodyReferences(OpenApiDocument doc)
 
         private static bool IsHostValid(string host)
         {
-            try
-            {
-                //Check if the host contains ://
-                if (host.Contains(Uri.SchemeDelimiter))
-                {
-                    return false;
-                }
-                
-                //Check if the host (excluding port number) is a valid dns/ip address.
-                var hostPart = host.Split(':').First();
-                return Uri.CheckHostName(hostPart) != UriHostNameType.Unknown;
-            }
-            catch (Exception)
+            //Check if the host contains :// 
+            if (host.Contains(Uri.SchemeDelimiter))
             {
                 return false;
             }
+                
+            //Check if the host (excluding port number) is a valid dns/ip address.
+            var hostPart = host.Split(':').First();
+            return Uri.CheckHostName(hostPart) != UriHostNameType.Unknown;
         }
     }
 

test/Microsoft.OpenApi.Readers.Tests/V2Tests/OpenApiServerTests.cs

@@ -262,7 +262,7 @@ public void LocalHostWithCustomHost()
         }
 
         [Fact]
-        public void InvalidHostShouldYieldDiagnostic()
+        public void InvalidHostShouldYieldError()
         {
             var input = @"
 swagger: 2.0
@@ -278,13 +278,13 @@ public void InvalidHostShouldYieldDiagnostic()
             });
 
             var doc = reader.Read(input, out var diagnostic);
-            Assert.Equal(0, doc.Servers.Count);
+            doc.Servers.Count.Should().Be(0);
             diagnostic.ShouldBeEquivalentTo(
                 new OpenApiDiagnostic
                 {
                     Errors =
                     {
-                        new OpenApiError(new OpenApiException("Invalid host"))
+                        new OpenApiError("#/", "Invalid host")
                     },
                     SpecificationVersion = OpenApiSpecVersion.OpenApi2_0
                 });