Add test to validate; clean up tests

Author: MaggieKimani1

test/Microsoft.OpenApi.Readers.Tests/OpenApiReaderTests/OpenApiDiagnosticTests.cs

@@ -56,10 +56,7 @@ public async Task DiagnosticReportMergedForExternalReferenceAsync()
 
             Assert.NotNull(result);
             Assert.NotNull(result.OpenApiDocument.Workspace);
-            result.OpenApiDiagnostic.Errors.Should().BeEquivalentTo(new List<OpenApiError>
-            {
-                new OpenApiError("", "[File: ./TodoReference.yaml] Paths is a REQUIRED field at #/")
-            });
+            result.OpenApiDiagnostic.Errors.Should().BeEmpty();
         }
     }
 

test/Microsoft.OpenApi.Readers.Tests/ParseNodeTests.cs

@@ -34,8 +34,7 @@ public void BrokenSimpleList()
             var result = OpenApiDocument.Parse(input, "yaml");
 
             result.OpenApiDiagnostic.Errors.Should().BeEquivalentTo(new List<OpenApiError>() {
-                new OpenApiError(new OpenApiReaderException("Expected a value.")),
-                new OpenApiError("", "Paths is a REQUIRED field at #/")
+                new OpenApiError(new OpenApiReaderException("Expected a value."))
             });
         }
 

test/Microsoft.OpenApi.Readers.Tests/V2Tests/OpenApiDocumentTests.cs

@@ -96,16 +96,7 @@ public void ParseDocumentWithDifferentCultureShouldSucceed(string culture)
                 .Excluding((IMemberInfo memberInfo) =>
                                         memberInfo.Path.EndsWith("Parent"))
                 .Excluding((IMemberInfo memberInfo) =>
-                                        memberInfo.Path.EndsWith("Root")));
-
-            result.OpenApiDiagnostic.Should().BeEquivalentTo(
-                new OpenApiDiagnostic { 
-                    SpecificationVersion = OpenApiSpecVersion.OpenApi2_0,
-                    Errors = new List<OpenApiError>()
-                    {
-                        new OpenApiError("", "Paths is a REQUIRED field at #/")
-                    }
-                });
+                                        memberInfo.Path.EndsWith("Root")));;
         }
 
         [Fact]

test/Microsoft.OpenApi.Readers.Tests/V2Tests/OpenApiServerTests.cs

@@ -310,8 +310,7 @@ public void InvalidHostShouldYieldError()
                 {
                     Errors =
                     {
-                        new OpenApiError("#/", "Invalid host"),
-                        new OpenApiError("", "Paths is a REQUIRED field at #/")
+                        new OpenApiError("#/", "Invalid host")
                     },
                     SpecificationVersion = OpenApiSpecVersion.OpenApi2_0
                 });

test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDocumentTests.cs

@@ -101,11 +101,7 @@ public void ParseDocumentFromInlineStringShouldSucceed()
             result.OpenApiDiagnostic.Should().BeEquivalentTo(
                 new OpenApiDiagnostic()
                 {
-                    SpecificationVersion = OpenApiSpecVersion.OpenApi3_0,
-                    Errors = new List<OpenApiError>()
-                        {
-                            new OpenApiError("", "Paths is a REQUIRED field at #/")
-                        }
+                    SpecificationVersion = OpenApiSpecVersion.OpenApi3_0
                 });
         }
 
@@ -115,16 +111,7 @@ public void ParseBasicDocumentWithMultipleServersShouldSucceed()
             var path = System.IO.Path.Combine(SampleFolderPath, "basicDocumentWithMultipleServers.yaml");
             var result = OpenApiDocument.Load(path);
 
-            result.OpenApiDiagnostic.Should().BeEquivalentTo(
-                new OpenApiDiagnostic()
-                {
-                    SpecificationVersion = OpenApiSpecVersion.OpenApi3_0,
-                    Errors = new List<OpenApiError>()
-                    {
-                        new OpenApiError("", "Paths is a REQUIRED field at #/")
-                    }
-                });
-
+            result.OpenApiDiagnostic.Errors.Should().BeEmpty();
             result.OpenApiDocument.Should().BeEquivalentTo(
                 new OpenApiDocument
                 {
@@ -170,7 +157,6 @@ public void ParseBrokenMinimalDocumentShouldYieldExpectedDiagnostic()
                 {
                     Errors =
                     {
-                            new OpenApiError("", "Paths is a REQUIRED field at #/"),
                             new OpenApiValidatorError(nameof(OpenApiInfoRules.InfoRequiredFields),"#/info/title", "The field 'title' in 'info' object is REQUIRED.")
                     },
                     SpecificationVersion = OpenApiSpecVersion.OpenApi3_0
@@ -196,11 +182,7 @@ public void ParseMinimalDocumentShouldSucceed()
             result.OpenApiDiagnostic.Should().BeEquivalentTo(
                 new OpenApiDiagnostic()
                 {
-                    SpecificationVersion = OpenApiSpecVersion.OpenApi3_0,
-                    Errors = new List<OpenApiError>()
-                    {
-                            new OpenApiError("", "Paths is a REQUIRED field at #/")
-                    }
+                    SpecificationVersion = OpenApiSpecVersion.OpenApi3_0
                 });
         }
 
@@ -1388,11 +1370,7 @@ public void ParseBasicDocumentWithServerVariableShouldSucceed()
             result.OpenApiDiagnostic.Should().BeEquivalentTo(
                 new OpenApiDiagnostic 
                 { 
-                    SpecificationVersion = OpenApiSpecVersion.OpenApi3_0,
-                    Errors = new List<OpenApiError>()
-                    {
-                            new OpenApiError("", "Paths is a REQUIRED field at #/")
-                    }
+                    SpecificationVersion = OpenApiSpecVersion.OpenApi3_0
                 });
 
             result.OpenApiDocument.Should().BeEquivalentTo(expected, options => options.Excluding(x => x.BaseUri));
@@ -1417,5 +1395,12 @@ public void ParseBasicDocumentWithServerVariableAndNoDefaultShouldFail()
 
             result.OpenApiDiagnostic.Errors.Should().NotBeEmpty();
         }
+
+        [Fact]
+        public void ParseDocumentWithEmptyPathsSucceeds()
+        {
+            var result = OpenApiDocument.Load(System.IO.Path.Combine(SampleFolderPath, "docWithEmptyPaths.yaml"));
+            result.OpenApiDiagnostic.Errors.Should().BeEmpty();
+        }
     }
 }

test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiSchemaTests.cs

@@ -241,11 +241,7 @@ public void ParseBasicSchemaWithReferenceShouldSucceed()
             result.OpenApiDiagnostic.Should().BeEquivalentTo(
                 new OpenApiDiagnostic()
                 {
-                    SpecificationVersion = OpenApiSpecVersion.OpenApi3_0,
-                    Errors = new List<OpenApiError>()
-                    {
-                            new OpenApiError("", "Paths is a REQUIRED field at #/")
-                    }
+                    SpecificationVersion = OpenApiSpecVersion.OpenApi3_0
                 });
 
             var expectedComponents = new OpenApiComponents

test/Microsoft.OpenApi.Readers.Tests/V3Tests/Samples/OpenApiDocument/docWithEmptyPaths.yaml

@@ -0,0 +1,5 @@
+openapi: 3.0.0
+info:
+  title: Sample API
+  version: 1.0.0
+paths: {}