Initialize a new Uri instance during copying

Author: MaggieKimani1

src/Microsoft.OpenApi/Models/OpenApiContact.cs

@@ -46,7 +46,7 @@ public OpenApiContact() { }
         public OpenApiContact(OpenApiContact contact)
         {
             Name = contact.Name;
-            Url = contact.Url;
+            Url = new Uri(contact.Url.OriginalString);
             Email = contact.Email;
             Extensions = new Dictionary<string, IOpenApiExtension>(contact.Extensions);
         }

src/Microsoft.OpenApi/Models/OpenApiExternalDocs.cs

@@ -40,7 +40,7 @@ public OpenApiExternalDocs() {}
         public OpenApiExternalDocs(OpenApiExternalDocs externalDocs)
         {
             Description = externalDocs.Description;
-            Url = externalDocs.Url;
+            Url = new Uri(externalDocs.Url.OriginalString);
             Extensions = new Dictionary<string, IOpenApiExtension>(externalDocs.Extensions);
         }
 

src/Microsoft.OpenApi/Models/OpenApiLicense.cs

@@ -40,7 +40,7 @@ public OpenApiLicense() {}
         public OpenApiLicense(OpenApiLicense license)
         {
             Name = license.Name;
-            Url = license.Url;
+            Url = new Uri(license.Url.OriginalString);
             Extensions = new Dictionary<string, IOpenApiExtension>(license.Extensions);
         }
 

src/Microsoft.OpenApi/Models/OpenApiOAuthFlow.cs

@@ -51,9 +51,9 @@ public OpenApiOAuthFlow() {}
         /// </summary>
         public OpenApiOAuthFlow(OpenApiOAuthFlow oAuthFlow)
         {
-            AuthorizationUrl = oAuthFlow.AuthorizationUrl;
-            TokenUrl = oAuthFlow.TokenUrl;
-            RefreshUrl = oAuthFlow.RefreshUrl;
+            AuthorizationUrl = new Uri(oAuthFlow.AuthorizationUrl.OriginalString);
+            TokenUrl = new Uri(oAuthFlow.TokenUrl.OriginalString);
+            RefreshUrl = new Uri(oAuthFlow.RefreshUrl.OriginalString);
             Scopes = new Dictionary<string, string>(oAuthFlow.Scopes);
             Extensions = new Dictionary<string, IOpenApiExtension>(oAuthFlow.Extensions);
         }

src/Microsoft.OpenApi/Models/OpenApiSecurityScheme.cs

@@ -91,7 +91,7 @@ public OpenApiSecurityScheme(OpenApiSecurityScheme securityScheme)
             Scheme = securityScheme.Scheme;
             BearerFormat = securityScheme.BearerFormat;
             Flows = new(securityScheme.Flows);
-            OpenIdConnectUrl = securityScheme.OpenIdConnectUrl;
+            OpenIdConnectUrl = new Uri(securityScheme.OpenIdConnectUrl.OriginalString);
             Extensions = new Dictionary<string, IOpenApiExtension>(securityScheme.Extensions);
             UnresolvedReference = securityScheme.UnresolvedReference;
             Reference = new(securityScheme.Reference);

test/Microsoft.OpenApi.Tests/Models/OpenApiLicenseTests.cs

@@ -108,5 +108,20 @@ public void SerializeAdvanceLicenseAsYamlWorks(OpenApiSpecVersion version)
             expected = expected.MakeLineBreaksEnvironmentNeutral();
             actual.Should().Be(expected);
         }
+
+        [Fact]
+        public void ShouldCopyFromOriginalObjectWithoutMutating()
+        {
+            // Arrange
+            var licenseCopy = new OpenApiLicense(AdvanceLicense);
+
+            // Act
+            licenseCopy.Name = "";
+            licenseCopy.Url = new Uri("https://exampleCopy.com");
+
+            // Assert
+            Assert.NotEqual(AdvanceLicense.Name, licenseCopy.Name);
+            Assert.NotEqual(AdvanceLicense.Url, licenseCopy.Url);
+        }
     }
 }