Address PR feedback

Author: MaggieKimani1

src/Microsoft.OpenApi.Readers/V3/OpenApiSecurityRequirementDeserializer.cs

@@ -15,20 +15,12 @@ internal static partial class OpenApiV3Deserializer
         public static OpenApiSecurityRequirement LoadSecurityRequirement(ParseNode node)
         {
             var mapNode = node.CheckMapNode("security");
-            string description = null;
-            string summary = null;
 
             var securityRequirement = new OpenApiSecurityRequirement();
 
             foreach (var property in mapNode)
             {
-                if (property.Name.Equals("description") || property.Name.Equals("summary"))
-                {
-                    description = node.Context.VersionService.GetReferenceScalarValues(mapNode, OpenApiConstants.Description);
-                    summary = node.Context.VersionService.GetReferenceScalarValues(mapNode, OpenApiConstants.Summary);
-                }
-
-                var scheme = LoadSecuritySchemeByReference(mapNode.Context, property.Name, summary, description);
+                var scheme = LoadSecuritySchemeByReference(mapNode.Context, property.Name);
 
                 var scopes = property.Value.CreateSimpleList(value => value.GetScalarValue());
 
@@ -48,17 +40,13 @@ public static OpenApiSecurityRequirement LoadSecurityRequirement(ParseNode node)
 
         private static OpenApiSecurityScheme LoadSecuritySchemeByReference(
             ParsingContext context,
-            string schemeName,
-            string summary = null,
-            string description = null)
+            string schemeName)
         {
             var securitySchemeObject = new OpenApiSecurityScheme()
             {
                 UnresolvedReference = true,
                 Reference = new OpenApiReference()
                 {
-                    Summary = summary,
-                    Description = description,
                     Id = schemeName,
                     Type = ReferenceType.SecurityScheme
                 }

src/Microsoft.OpenApi.Readers/V31/OpenApiSecurityRequirementDeserializer.cs

@@ -15,20 +15,12 @@ internal static partial class OpenApiV31Deserializer
         public static OpenApiSecurityRequirement LoadSecurityRequirement(ParseNode node)
         {
             var mapNode = node.CheckMapNode("security");
-            string description = null;
-            string summary = null;
 
             var securityRequirement = new OpenApiSecurityRequirement();
 
             foreach (var property in mapNode)
             {
-                if (property.Name.Equals("description") || property.Name.Equals("summary"))
-                {
-                    description = node.Context.VersionService.GetReferenceScalarValues(mapNode, OpenApiConstants.Description);
-                    summary = node.Context.VersionService.GetReferenceScalarValues(mapNode, OpenApiConstants.Summary);
-                }
-
-                var scheme = LoadSecuritySchemeByReference(property.Name, summary, description);
+                var scheme = LoadSecuritySchemeByReference(property.Name);
 
                 var scopes = property.Value.CreateSimpleList(value => value.GetScalarValue());
 
@@ -46,18 +38,13 @@ public static OpenApiSecurityRequirement LoadSecurityRequirement(ParseNode node)
             return securityRequirement;
         }
 
-        private static OpenApiSecurityScheme LoadSecuritySchemeByReference(
-            string schemeName,
-            string summary = null,
-            string description = null)
+        private static OpenApiSecurityScheme LoadSecuritySchemeByReference(string schemeName)
         {
             var securitySchemeObject = new OpenApiSecurityScheme()
             {
                 UnresolvedReference = true,
                 Reference = new OpenApiReference()
                 {
-                    Summary = summary,
-                    Description = description,
                     Id = schemeName,
                     Type = ReferenceType.SecurityScheme
                 }

src/Microsoft.OpenApi/Microsoft.OpenApi.csproj

@@ -36,12 +36,9 @@
     <ItemGroup>
       <PackageReference Include="JsonSchema.Net" Version="4.1.5" />
       <PackageReference Include="JsonSchema.Net.OpenApi" Version="1.1.0" />
-      <PackageReference Include="SharpYaml" Version="2.1.0" />
     </ItemGroup>
     <ItemGroup>
       <PackageReference Include="System.Text.Json" Version="7.0.2" />
-      <PackageReference Include="Yaml2JsonNode" Version="1.1.1" />
-      <PackageReference Include="YamlDotNet" Version="13.1.0" />
     </ItemGroup>
 
     <ItemGroup>

src/Microsoft.OpenApi/Models/OpenApiHeader.cs

@@ -19,7 +19,7 @@ namespace Microsoft.OpenApi.Models
     /// </summary>
     public class OpenApiHeader : IOpenApiSerializable, IOpenApiReferenceable, IOpenApiExtensible, IEffective<OpenApiHeader>
     {
-        protected JsonSchema _schema;
+        private JsonSchema _schema;
 
         /// <summary>
         /// Indicates if object is populated with data or is just a reference to the data

src/Microsoft.OpenApi/Models/OpenApiParameter.cs

@@ -20,7 +20,7 @@ public class OpenApiParameter : IOpenApiSerializable, IOpenApiReferenceable, IEf
     {
         private bool? _explode;
         private ParameterStyle? _style;
-        protected JsonSchema _schema;
+        private JsonSchema _schema;
 
         /// <summary>
         /// Indicates if object is populated with data or is just a reference to the data
@@ -106,7 +106,7 @@ public virtual bool Explode
         public virtual bool AllowReserved { get; set; }
 
         /// <summary>
-        /// The schema defining the type used for the request body.
+        /// The schema defining the type used for the parameter.
         /// </summary>
         public virtual JsonSchema Schema 
         { 

src/Microsoft.OpenApi/Models/References/OpenApiHeaderReference.cs

@@ -73,7 +73,7 @@ public override string Description
         public override bool AllowEmptyValue { get => Target.AllowEmptyValue; set => Target.AllowEmptyValue = value; }
 
         /// <inheritdoc/>
-        public override JsonSchema Schema { get => _schema; set => _schema = value; }
+        public override JsonSchema Schema { get => Target.Schema; set => Target.Schema = value; }
 
         /// <inheritdoc/>
         public override ParameterStyle? Style { get => Target.Style; set => Target.Style = value; }

src/Microsoft.OpenApi/Models/References/OpenApiParameterReference.cs

@@ -84,7 +84,7 @@ public override string Description
         public override bool AllowReserved { get => Target.AllowReserved; set => Target.AllowReserved = value; }
 
         /// <inheritdoc/>
-        public override JsonSchema Schema { get => _schema; set => _schema = value; }
+        public override JsonSchema Schema { get => Target.Schema; set => Target.Schema = value; }
 
         /// <inheritdoc/>
         public override IDictionary<string, OpenApiExample> Examples { get => Target.Examples; set => Target.Examples = value; }

src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs

@@ -13,7 +13,6 @@
 using Microsoft.OpenApi.Models;
 using Microsoft.OpenApi.Properties;
 using Microsoft.OpenApi.Services;
-using YamlDotNet.Serialization.ObjectGraphVisitors;
 
 namespace Microsoft.OpenApi.Writers
 {

test/Microsoft.OpenApi.Readers.Tests/Microsoft.OpenApi.Readers.Tests.csproj

@@ -313,7 +313,6 @@
           <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
         <PackageReference Include="Yaml2JsonNode" Version="1.1.1" />
-        <PackageReference Include="YamlDotNet" Version="13.1.0" />
     </ItemGroup>
 
     <ItemGroup>