Skip to content

Commit 2539576

Browse files
committed
Address PR feedback
1 parent feebffc commit 2539576

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/Microsoft.OpenApi.Readers/OpenApiStreamReader.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33

44
using System;
55
using System.IO;
6-
using System.Security.Cryptography;
7-
using System.Text;
86
using System.Threading.Tasks;
97
using Microsoft.OpenApi.Interfaces;
108
using Microsoft.OpenApi.Models;
@@ -44,7 +42,6 @@ public OpenApiDocument Read(Stream input, out OpenApiDiagnostic diagnostic)
4442
{
4543
var reader = new StreamReader(input);
4644
var result = new OpenApiTextReaderReader(_settings).Read(reader, out diagnostic);
47-
4845
if (!_settings.LeaveStreamOpen)
4946
{
5047
reader.Dispose();

src/Microsoft.OpenApi/Models/OpenApiDocument.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -390,17 +390,16 @@ public IOpenApiReferenceable ResolveReference(OpenApiReference reference)
390390
/// <returns>The hash value.</returns>
391391
public static string GenerateHashValue(OpenApiDocument doc)
392392
{
393-
HashAlgorithm sha = SHA512.Create();
394-
using var memoryStream = new MemoryStream();
395-
396-
using var cryptoStream = new CryptoStream(memoryStream, sha, CryptoStreamMode.Write);
393+
using HashAlgorithm sha = SHA512.Create();
394+
using var cryptoStream = new CryptoStream(Stream.Null, sha, CryptoStreamMode.Write);
397395
using var streamWriter = new StreamWriter(cryptoStream);
398396

399397
var openApiJsonWriter = new OpenApiJsonWriter(streamWriter, new OpenApiJsonWriterSettings { Terse = true });
400398
doc.SerializeAsV3(openApiJsonWriter);
401399
openApiJsonWriter.Flush();
402400

403-
var hash = memoryStream.ToArray();
401+
cryptoStream.FlushFinalBlock();
402+
var hash = sha.Hash;
404403

405404
return ConvertByteArrayToString(hash);
406405
}

0 commit comments

Comments
 (0)