chore: code fixes recommended by sonarqube

Signed-off-by: Vincent Biret <[email protected]>

Author: baywet

src/Microsoft.OpenApi/Models/OpenApiDocument.cs

@@ -371,7 +371,7 @@ private static void WriteHostInfoV2(IOpenApiWriter writer, IList<OpenApiServer>?
 
             // Arbitrarily choose the first server given that V2 only allows
             // one host, port, and base path.
-            var serverUrl = ParseServerUrl(servers.First());
+            var serverUrl = ParseServerUrl(servers[0]);
 
             // Divide the URL in the Url property into host and basePath required in OpenAPI V2
             // The Url property cannot contain path templating to be valid for V2 serialization.

src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs

@@ -123,7 +123,7 @@ public static async Task<ReadResult> LoadAsync(string url, OpenApiReaderSettings
         public static async Task<T> LoadAsync<T>(string url, OpenApiSpecVersion version, OpenApiReaderSettings settings = null) where T : IOpenApiElement
         {
             var result = await RetrieveStreamAndFormatAsync(url);
-            return Load<T>(result.Item1, version, out var diagnostic, result.Item2, settings);
+            return Load<T>(result.Item1, version, out var _, result.Item2, settings);
         }
 
         /// <summary>

test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDocumentTests.cs

@@ -34,46 +34,36 @@ public OpenApiDocumentTests()
 
         public T Clone<T>(T element) where T : IOpenApiSerializable
         {
-            using (var stream = new MemoryStream())
+            using var stream = new MemoryStream();
+            var streamWriter = new FormattingStreamWriter(stream, CultureInfo.InvariantCulture);
+            var writer = new OpenApiJsonWriter(streamWriter, new OpenApiJsonWriterSettings()
             {
-                IOpenApiWriter writer;
-                var streamWriter = new FormattingStreamWriter(stream, CultureInfo.InvariantCulture);
-                writer = new OpenApiJsonWriter(streamWriter, new OpenApiJsonWriterSettings()
-                {
-                    InlineLocalReferences = true
-                });
-                element.SerializeAsV3(writer);
-                writer.Flush();
-                stream.Position = 0;
+                InlineLocalReferences = true
+            });
+            element.SerializeAsV3(writer);
+            writer.Flush();
+            stream.Position = 0;
 
-                using (var streamReader = new StreamReader(stream))
-                {
-                    var result = streamReader.ReadToEnd();
-                    return OpenApiModelFactory.Parse<T>(result, OpenApiSpecVersion.OpenApi3_0, out OpenApiDiagnostic diagnostic4);
-                }
-            }
+            using var streamReader = new StreamReader(stream);
+            var result = streamReader.ReadToEnd();
+            return OpenApiModelFactory.Parse<T>(result, OpenApiSpecVersion.OpenApi3_0, out var _);
         }
 
         public OpenApiSecurityScheme CloneSecurityScheme(OpenApiSecurityScheme element)
         {
-            using (var stream = new MemoryStream())
+            using var stream = new MemoryStream();
+            var streamWriter = new FormattingStreamWriter(stream, CultureInfo.InvariantCulture);
+            var writer = new OpenApiJsonWriter(streamWriter, new OpenApiJsonWriterSettings()
             {
-                IOpenApiWriter writer;
-                var streamWriter = new FormattingStreamWriter(stream, CultureInfo.InvariantCulture);
-                writer = new OpenApiJsonWriter(streamWriter, new OpenApiJsonWriterSettings()
-                {
-                    InlineLocalReferences = true
-                });
-                element.SerializeAsV3(writer);
-                writer.Flush();
-                stream.Position = 0;
+                InlineLocalReferences = true
+            });
+            element.SerializeAsV3(writer);
+            writer.Flush();
+            stream.Position = 0;
 
-                using (var streamReader = new StreamReader(stream))
-                {
-                    var result = streamReader.ReadToEnd();
-                    return OpenApiModelFactory.Parse<OpenApiSecurityScheme>(result, OpenApiSpecVersion.OpenApi3_0, out OpenApiDiagnostic diagnostic4);
-                }
-            }
+            using var streamReader = new StreamReader(stream);
+            var result = streamReader.ReadToEnd();
+            return OpenApiModelFactory.Parse<OpenApiSecurityScheme>(result, OpenApiSpecVersion.OpenApi3_0, out var _);
         }
 
         [Fact]