update dictionary extension

Author: Michael-Wamae

src/Microsoft.OpenApi/Extensions/DictionaryExtensions.cs

@@ -12,34 +12,27 @@ public static class DictionaryExtensions
         /// <summary>
         /// Returns a new dictionary with entries sorted by key using the default comparer.
         /// </summary>
-        public static IDictionary<TKey, TValue> Sort<TKey, TValue>(
+        public static SortedDictionary<TKey, TValue> Sort<TKey, TValue>(
             this IDictionary<TKey, TValue> source)
             where TKey : notnull
         {
-            if (source == null)
-                throw new ArgumentNullException(nameof(source));
+            Utils.CheckArgumentNull(source);
 
-            return source
-                .OrderBy(kvp => kvp.Key)
-                .ToDictionary(kvp => kvp.Key, kvp => kvp.Value);
+            return new SortedDictionary<TKey, TValue>(source);
         }
 
         /// <summary>
         /// Returns a new dictionary with entries sorted by key using a custom comparer.
         /// </summary>
-        public static IDictionary<TKey, TValue> Sort<TKey, TValue>(
+        public static SortedDictionary<TKey, TValue> Sort<TKey, TValue>(
             this IDictionary<TKey, TValue> source,
             IComparer<TKey> comparer)
             where TKey : notnull
         {
-            if (source == null)
-                throw new ArgumentNullException(nameof(source));
-            if (comparer == null)
-                throw new ArgumentNullException(nameof(comparer));
+            Utils.CheckArgumentNull(source);
+            Utils.CheckArgumentNull(comparer);
 
-            return source
-                .OrderBy(kvp => kvp.Key, comparer)
-                .ToDictionary(kvp => kvp.Key, kvp => kvp.Value);
+            return new SortedDictionary<TKey, TValue>(source, comparer);
         }
     }
 }

test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt

@@ -144,9 +144,9 @@ namespace Microsoft.OpenApi.Extensions
 {
     public static class DictionaryExtensions
     {
-        public static System.Collections.Generic.IDictionary<TKey, TValue> Sort<TKey, TValue>(this System.Collections.Generic.IDictionary<TKey, TValue> source)
+        public static System.Collections.Generic.SortedDictionary<TKey, TValue> Sort<TKey, TValue>(this System.Collections.Generic.IDictionary<TKey, TValue> source)
             where TKey :  notnull { }
-        public static System.Collections.Generic.IDictionary<TKey, TValue> Sort<TKey, TValue>(this System.Collections.Generic.IDictionary<TKey, TValue> source, System.Collections.Generic.IComparer<TKey> comparer)
+        public static System.Collections.Generic.SortedDictionary<TKey, TValue> Sort<TKey, TValue>(this System.Collections.Generic.IDictionary<TKey, TValue> source, System.Collections.Generic.IComparer<TKey> comparer)
             where TKey :  notnull { }
     }
     public static class EnumExtensions