Merge pull request #987 from microsoft/mk/fix-multipart-formdata-issue

MaggieKimani1 · web-flow · commit 39a2cc8dca3f · 2022-08-29T17:00:31.000+03:00
Cater for file content transferred with base64 encoding
diff --git a/src/Microsoft.OpenApi/Models/OpenApiOperation.cs b/src/Microsoft.OpenApi/Models/OpenApiOperation.cs
@@ -253,9 +253,11 @@ public void SerializeAsV2(IOpenApiWriter writer)
                 {
                     foreach (var property in RequestBody.Content.First().Value.Schema.Properties)
                     {
-                        var paramName = property.Key;
                         var paramSchema = property.Value;
-                        if (paramSchema.Type == "string" && paramSchema.Format == "binary") {
+                        if ("string".Equals(paramSchema.Type, StringComparison.OrdinalIgnoreCase) 
+                            && ("binary".Equals(paramSchema.Format, StringComparison.OrdinalIgnoreCase) 
+                            || "base64".Equals(paramSchema.Format, StringComparison.OrdinalIgnoreCase)))
+                        {
                             paramSchema.Type = "file";
                             paramSchema.Format = null;
                         }

Original file line number	Diff line number	Diff line change
`@@ -253,9 +253,11 @@ public void SerializeAsV2(IOpenApiWriter writer)`
`253`	`253`	`{`
`254`	`254`	`foreach (var property in RequestBody.Content.First().Value.Schema.Properties)`
`255`	`255`	`{`
`256`		`- var paramName = property.Key;`
`257`	`256`	`var paramSchema = property.Value;`
`258`		`- if (paramSchema.Type == "string" && paramSchema.Format == "binary") {`
	`257`	`+ if ("string".Equals(paramSchema.Type, StringComparison.OrdinalIgnoreCase)`
	`258`	`+ && ("binary".Equals(paramSchema.Format, StringComparison.OrdinalIgnoreCase)`
	`259`	`+ \|\| "base64".Equals(paramSchema.Format, StringComparison.OrdinalIgnoreCase)))`
	`260`	`+ {`
`259`	`261`	`paramSchema.Type = "file";`
`260`	`262`	`paramSchema.Format = null;`
`261`	`263`	`}`