chore: refactoring

Signed-off-by: Vincent Biret <[email protected]>

Author: baywet

src/Microsoft.OpenApi/Reader/Services/OpenApiRemoteReferenceCollector.cs

@@ -26,18 +26,15 @@ public IEnumerable<BaseOpenApiReference> References
         /// <inheritdoc/>
         public override void Visit(IOpenApiReferenceHolder referenceHolder)
         {
-            if (referenceHolder is IOpenApiReferenceHolder<BaseOpenApiReference> { Reference: BaseOpenApiReference reference })
+            var reference = referenceHolder switch
             {
-                AddExternalReferences(reference);
-            }
-            else if (referenceHolder is IOpenApiReferenceHolder<JsonSchemaReference> { Reference: JsonSchemaReference jsonSchemaReference })
-            {
-                AddExternalReferences(jsonSchemaReference);
-            }
-            else if (referenceHolder is IOpenApiReferenceHolder<OpenApiReferenceWithDescriptionAndSummary> { Reference: OpenApiReferenceWithDescriptionAndSummary withSummaryReference })
-            {
-                AddExternalReferences(withSummaryReference);
-            }
+                IOpenApiReferenceHolder<OpenApiReferenceWithDescriptionAndSummary> { Reference: OpenApiReferenceWithDescriptionAndSummary withSummary } => withSummary,
+                IOpenApiReferenceHolder<OpenApiReferenceWithDescription> { Reference: OpenApiReferenceWithDescription withDescription } => withDescription,
+                IOpenApiReferenceHolder<JsonSchemaReference> { Reference: JsonSchemaReference jsonSchemaReference } => jsonSchemaReference,
+                IOpenApiReferenceHolder<BaseOpenApiReference> { Reference: BaseOpenApiReference baseReference } => baseReference,
+                _ => throw new OpenApiException($"Unsupported reference holder type: {referenceHolder.GetType().FullName}")
+            };
+            AddExternalReferences(reference);
         }
 
         /// <summary>

src/Microsoft.OpenApi/Services/ReferenceHostDocumentSetter.cs

@@ -18,18 +18,15 @@ public ReferenceHostDocumentSetter(OpenApiDocument currentDocument)
         /// <inheritdoc/>
         public override void Visit(IOpenApiReferenceHolder referenceHolder)
         {
-            if (referenceHolder is IOpenApiReferenceHolder<BaseOpenApiReference> { Reference: BaseOpenApiReference reference })
+            var reference = referenceHolder switch
             {
-                reference.EnsureHostDocumentIsSet(_currentDocument);
-            }
-            else if (referenceHolder is IOpenApiReferenceHolder<JsonSchemaReference> { Reference: JsonSchemaReference jsonSchemaReference })
-            {
-                jsonSchemaReference.EnsureHostDocumentIsSet(_currentDocument);
-            }
-            else if (referenceHolder is IOpenApiReferenceHolder<OpenApiReferenceWithDescriptionAndSummary> { Reference: OpenApiReferenceWithDescriptionAndSummary withSummaryReference })
-            {
-                withSummaryReference.EnsureHostDocumentIsSet(_currentDocument);
-            }
+                IOpenApiReferenceHolder<OpenApiReferenceWithDescriptionAndSummary> { Reference: OpenApiReferenceWithDescriptionAndSummary withSummary } => withSummary,
+                IOpenApiReferenceHolder<OpenApiReferenceWithDescription> { Reference: OpenApiReferenceWithDescription withDescription } => withDescription,
+                IOpenApiReferenceHolder<JsonSchemaReference> { Reference: JsonSchemaReference jsonSchemaReference } => jsonSchemaReference,
+                IOpenApiReferenceHolder<BaseOpenApiReference> { Reference: BaseOpenApiReference baseReference } => baseReference,
+                _ => throw new OpenApiException($"Unsupported reference holder type: {referenceHolder.GetType().FullName}")
+            };
+            reference.EnsureHostDocumentIsSet(_currentDocument);
         }
     }
 }