Successfully replace SharpYaml dependency with YamlDotNet

Co-authored-by: baywet <[email protected]>

Author: Copilot

src/Microsoft.OpenApi.YamlReader/Microsoft.OpenApi.YamlReader.csproj

@@ -33,7 +33,7 @@
           <PrivateAssets>all</PrivateAssets>
         </PackageReference>
 
-        <PackageReference Include="SharpYaml" Version="2.1.2" />
+        <PackageReference Include="YamlDotNet" Version="16.3.0" />
         <PackageReference Include="System.Text.Json" Version="[8.0.5,)" />
         <NuGetAuditSuppress Include="https://github.com/advisories/GHSA-hh2w-p6rv-4g7w" />
         <NuGetAuditSuppress Include="https://github.com/advisories/GHSA-8g4q-xg66-9fp4" />

src/Microsoft.OpenApi.YamlReader/OpenApiYamlReader.cs

@@ -7,7 +7,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.OpenApi.Reader;
-using SharpYaml.Serialization;
+using YamlDotNet.RepresentationModel;
 using System;
 using System.Linq;
 using System.Text;

src/Microsoft.OpenApi.YamlReader/YamlConverter.cs

@@ -3,8 +3,8 @@
 using System.Globalization;
 using System.Linq;
 using System.Text.Json.Nodes;
-using SharpYaml;
-using SharpYaml.Serialization;
+using YamlDotNet.RepresentationModel;
+using YamlDotNet.Core;
 
 namespace Microsoft.OpenApi.YamlReader
 {
@@ -75,7 +75,7 @@ public static YamlNode ToYamlNode(this JsonNode json)
         public static JsonObject ToJsonObject(this YamlMappingNode yaml)
         {
             var node = new JsonObject();
-            foreach (var keyValuePair in yaml)
+            foreach (var keyValuePair in yaml.Children)
             {
                 var key = ((YamlScalarNode)keyValuePair.Key).Value!;
                 node[key] = keyValuePair.Value.ToJsonNode();
@@ -86,7 +86,8 @@ public static JsonObject ToJsonObject(this YamlMappingNode yaml)
 
         private static YamlMappingNode ToYamlMapping(this JsonObject obj)
         {
-            return new YamlMappingNode(obj.ToDictionary(x => (YamlNode)new YamlScalarNode(x.Key), x => x.Value!.ToYamlNode()));
+            var children = obj.ToDictionary(x => (YamlNode)new YamlScalarNode(x.Key), x => x.Value!.ToYamlNode());
+            return new YamlMappingNode(children);
         }
 
         /// <summary>
@@ -97,7 +98,7 @@ private static YamlMappingNode ToYamlMapping(this JsonObject obj)
         public static JsonArray ToJsonArray(this YamlSequenceNode yaml)
         {
             var node = new JsonArray();
-            foreach (var value in yaml)
+            foreach (var value in yaml.Children)
             {
                 node.Add(value.ToJsonNode());
             }
@@ -107,7 +108,8 @@ public static JsonArray ToJsonArray(this YamlSequenceNode yaml)
 
         private static YamlSequenceNode ToYamlSequence(this JsonArray arr)
         {
-            return new YamlSequenceNode(arr.Select(x => x!.ToYamlNode()));
+            var children = arr.Select(x => x!.ToYamlNode()).ToList();
+            return new YamlSequenceNode(children);
         }
 
         private static JsonValue ToJsonValue(this YamlScalarNode yaml)

src/Microsoft.OpenApi/Models/BaseOpenApiReference.cs

@@ -316,10 +316,10 @@ internal void SetJsonPointerPath(string pointer, string nodeLocation)
         private static string ResolveRelativePointer(string nodeLocation, string relativeRef)
         {
             // Convert nodeLocation to path segments
-            var segments = nodeLocation.TrimStart('#').Split(['/'], StringSplitOptions.RemoveEmptyEntries).ToList();
+            var segments = nodeLocation.TrimStart('#').Split(new char[] { '/' }, StringSplitOptions.RemoveEmptyEntries).ToList();
 
             // Convert relativeRef to dynamic segments
-            var relativeSegments = relativeRef.TrimStart('#').Split(['/'], StringSplitOptions.RemoveEmptyEntries);
+            var relativeSegments = relativeRef.TrimStart('#').Split(new char[] { '/' }, StringSplitOptions.RemoveEmptyEntries);
 
             // Locate the first occurrence of relativeRef segments in the full path
             for (int i = 0; i <= segments.Count - relativeSegments.Length; i++)

src/Microsoft.OpenApi/Models/OpenApiDocument.cs

@@ -589,7 +589,7 @@ private static string ConvertByteArrayToString(byte[] hash)
                     // Enables setting the complete JSON path for nested subschemas e.g. #/components/schemas/person/properties/address
                     if (useExternal)
                     {
-                        var relPathSegment = referenceV3.Split(['#'], StringSplitOptions.RemoveEmptyEntries)[1];
+                        var relPathSegment = referenceV3.Split(new char[] { '#' }, StringSplitOptions.RemoveEmptyEntries)[1];
                         relativePath = $"#{relPathSegment}";
                     }
                     else
@@ -625,7 +625,7 @@ private static bool IsSubComponent(string reference)
 
             if (fragment.StartsWith("/components/schemas/", StringComparison.OrdinalIgnoreCase))
             {
-                var segments = fragment.Split(['/'], StringSplitOptions.RemoveEmptyEntries);
+                var segments = fragment.Split(new char[] { '/' }, StringSplitOptions.RemoveEmptyEntries);
 
                 // Expect exactly 3 segments for root-level schema: ["components", "schemas", "person"]
                 // Anything longer means it's a subcomponent.

src/Microsoft.OpenApi/Services/OpenApiWorkspace.cs

@@ -347,7 +347,7 @@ public bool Contains(string location)
 
             if (uri is not null)
             {
-                pathSegments = uri.Fragment.Split(['/'], StringSplitOptions.RemoveEmptyEntries);
+                pathSegments = uri.Fragment.Split(new char[] { '/' }, StringSplitOptions.RemoveEmptyEntries);
 
                 // Build the base path for the root schema: "#/components/schemas/person"
                 var fragment = OpenApiConstants.ComponentsSegment + ReferenceType.Schema.GetDisplayName() + ComponentSegmentSeparator + pathSegments[3];

test/Microsoft.OpenApi.Readers.Tests/Microsoft.OpenApi.Readers.Tests.csproj

@@ -19,7 +19,7 @@
         <PackageReference Include="coverlet.msbuild" Version="6.0.4" PrivateAssets="all" />
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
         <PackageReference Include="FluentAssertions" Version="7.2.0" />
-        <PackageReference Include="SharpYaml" Version="2.1.2" />
+        <PackageReference Include="YamlDotNet" Version="16.3.0" />
         <PackageReference Include="xunit" Version="2.9.3" />
         <PackageReference Include="xunit.runner.visualstudio" Version="3.1.1" PrivateAssets="all" />
     </ItemGroup>

test/Microsoft.OpenApi.Readers.Tests/TestHelper.cs

@@ -4,7 +4,7 @@
 using System.IO;
 using Microsoft.OpenApi.Reader;
 using Microsoft.OpenApi.YamlReader;
-using SharpYaml.Serialization;
+using YamlDotNet.RepresentationModel;
 
 namespace Microsoft.OpenApi.Readers.Tests
 {

test/Microsoft.OpenApi.Readers.Tests/V2Tests/OpenApiSecuritySchemeTests.cs

@@ -7,7 +7,7 @@
 using Microsoft.OpenApi.Reader;
 using Microsoft.OpenApi.Reader.V2;
 using Microsoft.OpenApi.YamlReader;
-using SharpYaml.Serialization;
+using YamlDotNet.RepresentationModel;
 using Xunit;
 
 namespace Microsoft.OpenApi.Readers.Tests.V2Tests

test/Microsoft.OpenApi.Readers.Tests/V31Tests/OpenApiInfoTests.cs

@@ -3,7 +3,7 @@
 using Microsoft.OpenApi.Reader;
 using Microsoft.OpenApi.Reader.V31;
 using Microsoft.OpenApi.YamlReader;
-using SharpYaml.Serialization;
+using YamlDotNet.RepresentationModel;
 using Xunit;
 
 namespace Microsoft.OpenApi.Readers.Tests.V31Tests