Skip to content

Commit 4b8c697

Browse files
committed
Clean up tests
1 parent 6bf026f commit 4b8c697

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+3183
-1523
lines changed

test/Microsoft.OpenApi.Hidi.Tests/Formatters/PowerShellFormatterTests.cs

Lines changed: 51 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
using Json.Schema;
2-
using Microsoft.OpenApi.Any;
1+
using Microsoft.OpenApi.Any;
32
using Microsoft.OpenApi.Hidi.Formatters;
43
using Microsoft.OpenApi.Interfaces;
54
using Microsoft.OpenApi.Models;
65
using Microsoft.OpenApi.Services;
76
using Xunit;
8-
using Microsoft.OpenApi.Extensions;
97

108
namespace Microsoft.OpenApi.Hidi.Tests.Formatters
119
{
@@ -60,18 +58,18 @@ public void RemoveAnyOfAndOneOfFromSchema()
6058
walker.Walk(openApiDocument);
6159

6260
var testSchema = openApiDocument.Components.Schemas["TestSchema"];
63-
var averageAudioDegradationProperty = testSchema.GetProperties()?.GetValueOrDefault("averageAudioDegradation");
64-
var defaultPriceProperty = testSchema.GetProperties()?.GetValueOrDefault("defaultPrice");
61+
var averageAudioDegradationProperty = testSchema.Properties["averageAudioDegradation"];
62+
var defaultPriceProperty = testSchema.Properties["defaultPrice"];
6563

6664
// Assert
67-
Assert.Null(averageAudioDegradationProperty?.GetAnyOf());
68-
Assert.Equal(SchemaValueType.Number, averageAudioDegradationProperty?.GetJsonType());
69-
Assert.Equal("float", averageAudioDegradationProperty?.GetFormat()?.Key);
70-
Assert.True(averageAudioDegradationProperty?.GetNullable());
71-
Assert.Null(defaultPriceProperty?.GetOneOf());
72-
Assert.Equal(SchemaValueType.Number, defaultPriceProperty?.GetJsonType());
73-
Assert.Equal("double", defaultPriceProperty?.GetFormat()?.Key);
74-
Assert.NotNull(testSchema.GetAdditionalProperties());
65+
Assert.Null(averageAudioDegradationProperty.AnyOf);
66+
Assert.Equal("number", averageAudioDegradationProperty.Type);
67+
Assert.Equal("float", averageAudioDegradationProperty.Format);
68+
Assert.True(averageAudioDegradationProperty.Nullable);
69+
Assert.Null(defaultPriceProperty.OneOf);
70+
Assert.Equal("number", defaultPriceProperty.Type);
71+
Assert.Equal("double", defaultPriceProperty.Format);
72+
Assert.NotNull(testSchema.AdditionalProperties);
7573
}
7674

7775
[Fact]
@@ -90,7 +88,7 @@ public void ResolveFunctionParameters()
9088
// Assert
9189
Assert.Null(idsParameter?.Content);
9290
Assert.NotNull(idsParameter?.Schema);
93-
Assert.Equal(SchemaValueType.Array, idsParameter?.Schema.GetJsonType());
91+
Assert.Equal("array", idsParameter?.Schema.Type);
9492
}
9593

9694
private static OpenApiDocument GetSampleOpenApiDocument()
@@ -120,10 +118,14 @@ private static OpenApiDocument GetSampleOpenApiDocument()
120118
"application/json",
121119
new OpenApiMediaType
122120
{
123-
Schema = new JsonSchemaBuilder()
124-
.Type(SchemaValueType.Array)
125-
.Items(new JsonSchemaBuilder()
126-
.Type(SchemaValueType.String))
121+
Schema = new()
122+
{
123+
Type = "array",
124+
Items = new()
125+
{
126+
Type = "string"
127+
}
128+
}
127129
}
128130
}
129131
}
@@ -143,22 +145,38 @@ private static OpenApiDocument GetSampleOpenApiDocument()
143145
},
144146
Components = new()
145147
{
146-
Schemas = new Dictionary<string, JsonSchema>
148+
Schemas = new Dictionary<string, OpenApiSchema>
147149
{
148-
{ "TestSchema", new JsonSchemaBuilder()
149-
.Type(SchemaValueType.Object)
150-
.Properties(("averageAudioDegradation", new JsonSchemaBuilder()
151-
.AnyOf(
152-
new JsonSchemaBuilder().Type(SchemaValueType.Number),
153-
new JsonSchemaBuilder().Type(SchemaValueType.String))
154-
.Format("float")
155-
.Nullable(true)),
156-
157-
("defaultPrice", new JsonSchemaBuilder()
158-
.OneOf(
159-
new JsonSchemaBuilder().Type(SchemaValueType.Number).Format("double"),
160-
new JsonSchemaBuilder().Type(SchemaValueType.String))))
161-
}
150+
{ "TestSchema", new OpenApiSchema
151+
{
152+
Type = "object",
153+
Properties = new Dictionary<string, OpenApiSchema>
154+
{
155+
{
156+
"averageAudioDegradation", new OpenApiSchema
157+
{
158+
AnyOf = new List<OpenApiSchema>
159+
{
160+
new() { Type = "number" },
161+
new() { Type = "string" }
162+
},
163+
Format = "float",
164+
Nullable = true
165+
}
166+
},
167+
{
168+
"defaultPrice", new OpenApiSchema
169+
{
170+
OneOf = new List<OpenApiSchema>
171+
{
172+
new() { Type = "number", Format = "double" },
173+
new() { Type = "string" }
174+
}
175+
}
176+
}
177+
}
178+
}
179+
}
162180
}
163181
}
164182
};

0 commit comments

Comments
 (0)