Add a terseOutput parameter to the OpenApiJsonWriter and refactor code

Author: MaggieKimani1

src/Microsoft.OpenApi.Hidi/OpenApiService.cs

@@ -189,17 +189,15 @@ CancellationToken cancellationToken
                     using var outputStream = output?.Create();
                     var textWriter = outputStream != null ? new StreamWriter(outputStream) : Console.Out;
 
-                    var settings = new OpenApiWriterSettings();
-                    if (terseOutput)
+                    var settings = new OpenApiWriterSettings()
                     {
-                        settings.Terse = terseOutput;
-                    }
-                    settings.InlineLocalReferences = inlineLocal;
-                    settings.InlineExternalReferences = inlineExternal;
+                        InlineLocalReferences = inlineLocal,
+                        InlineExternalReferences = inlineExternal
+                    };
 
                     IOpenApiWriter writer = openApiFormat switch
                     {
-                        OpenApiFormat.Json => new OpenApiJsonWriter(textWriter, settings),
+                        OpenApiFormat.Json => terseOutput ? new OpenApiJsonWriter(textWriter, settings, terseOutput) : new OpenApiJsonWriter(textWriter, settings, false),
                         OpenApiFormat.Yaml => new OpenApiYamlWriter(textWriter, settings),
                         _ => throw new ArgumentException("Unknown format"),
                     };

src/Microsoft.OpenApi/Extensions/OpenApiSerializableExtensions.cs

@@ -83,20 +83,14 @@ public static void Serialize<T>(
                 throw Error.ArgumentNull(nameof(stream));
             }
 
-            IOpenApiWriter writer;
             var streamWriter = new FormattingStreamWriter(stream, CultureInfo.InvariantCulture);
-            switch (format)
-            {
-                case OpenApiFormat.Json:
-                    writer = new OpenApiJsonWriter(streamWriter,settings);
-                    break;
-                case OpenApiFormat.Yaml:
-                    writer = new OpenApiYamlWriter(streamWriter, settings);
-                    break;
-                default:
-                    throw new OpenApiException(string.Format(SRResource.OpenApiFormatNotSupported, format));
-            }
 
+            IOpenApiWriter writer = format switch
+            {
+                OpenApiFormat.Json => new OpenApiJsonWriter(streamWriter, settings, false),
+                OpenApiFormat.Yaml => new OpenApiYamlWriter(streamWriter, settings),
+                _ => throw new OpenApiException(string.Format(SRResource.OpenApiFormatNotSupported, format)),
+            };
             element.Serialize(writer, specVersion);
         }
 

src/Microsoft.OpenApi/Writers/OpenApiJsonWriter.cs

@@ -33,12 +33,10 @@ public OpenApiJsonWriter(TextWriter textWriter, OpenApiJsonWriterSettings settin
         /// </summary>
         /// <param name="textWriter">The text writer.</param>
         /// <param name="settings">Settings for controlling how the OpenAPI document will be written out.</param>
-        public OpenApiJsonWriter(TextWriter textWriter, OpenApiWriterSettings settings) : base(textWriter, settings)
+        /// <param name="terseOutput"> Setting for allowing the JSON emitted to be in terse format.</param>
+        public OpenApiJsonWriter(TextWriter textWriter, OpenApiWriterSettings settings, bool terseOutput = false) : base(textWriter, settings)
         {
-            if (settings != null)
-            {
-                _produceTerseOutput = settings.Terse;
-            }
+            _produceTerseOutput = terseOutput;
         }
 
         /// <summary>