Skip to content

Commit 543da26

Browse files
authored
Merge pull request #1408 from SimonCropp/remove-duplicate-dictionary-lookups-in-ValidationRuleSet.Add
remove duplicate dictionary lookups in ValidationRuleSet.Add
2 parents a184a8f + 88bb6b9 commit 543da26

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,17 +123,18 @@ public IList<ValidationRule> Rules
123123
/// <param name="rule">The rule.</param>
124124
public void Add(ValidationRule rule)
125125
{
126-
if (!_rules.ContainsKey(rule.ElementType))
126+
if (!_rules.TryGetValue(rule.ElementType, out var item))
127127
{
128-
_rules[rule.ElementType] = new List<ValidationRule>();
128+
_rules[rule.ElementType] = new List<ValidationRule> {rule};
129+
return;
129130
}
130131

131-
if (_rules[rule.ElementType].Contains(rule))
132+
if (item.Contains(rule))
132133
{
133134
throw new OpenApiException(SRResource.Validation_RuleAddTwice);
134135
}
135136

136-
_rules[rule.ElementType].Add(rule);
137+
item.Add(rule);
137138
}
138139

139140
/// <summary>

0 commit comments

Comments
 (0)