Addessing PR comments

Author: darrelmiller

src/Microsoft.OpenApi/Extensions/OpenApiElementExtensions.cs

@@ -20,7 +20,8 @@ public static class OpenApiElementExtensions
         /// <param name="element">Element to validate</param>
         /// <param name="ruleSet">Optional set of rules to use for validation</param>
         /// <returns>An IEnumerable of errors.  This function will never return null.</returns>
-        public static IEnumerable<OpenApiError> Validate(this IOpenApiElement element, ValidationRuleSet ruleSet = null)         {
+        public static IEnumerable<OpenApiError> Validate(this IOpenApiElement element, ValidationRuleSet ruleSet = null)
+        {
             var validator = new OpenApiValidator(ruleSet);
             var walker = new OpenApiWalker(validator);
             walker.Walk(element);

src/Microsoft.OpenApi/Models/OpenApiError.cs

@@ -15,8 +15,6 @@ public class OpenApiError
         /// </summary>
         public OpenApiError(OpenApiException exception) : this(exception.Pointer, exception.Message)
         {
-            Message = exception.Message;
-            Pointer = exception.Pointer;
         }
 
         /// <summary>

src/Microsoft.OpenApi/Validations/IValidationContext.cs

@@ -19,7 +19,7 @@ public interface IValidationContext
         /// Register an error with the validation context.
         /// </summary>
         /// <param name="error">Error to register.</param>
-        void AddError(OpenApiError error);
+        void AddError(OpenApiValidatorError error);
 
 
         /// <summary>

src/Microsoft.OpenApi/Validations/OpenApiValidator.cs

@@ -16,7 +16,7 @@ namespace Microsoft.OpenApi.Validations
     public class OpenApiValidator : OpenApiVisitorBase, IValidationContext 
     {
         private readonly ValidationRuleSet _ruleSet;
-        private readonly IList<OpenApiError> _errors = new List<OpenApiError>();
+        private readonly IList<OpenApiValidatorError> _errors = new List<OpenApiValidatorError>();
 
         /// <summary>
         /// Create a vistor that will validate an OpenAPIDocument
@@ -42,7 +42,7 @@ public IEnumerable<OpenApiError> Errors
         /// Register an error with the validation context.
         /// </summary>
         /// <param name="error">Error to register.</param>
-        public void AddError(OpenApiError error)
+        public void AddError(OpenApiValidatorError error)
         {
             if (error == null)
             {

src/Microsoft.OpenApi/Validations/OpenApiValidatorError.cs

@@ -11,7 +11,7 @@
 namespace Microsoft.OpenApi.Validations
 {
     /// <summary>
-    /// Errors detected when validating a OpenAPI Element
+    /// Errors detected when validating an OpenAPI Element
     /// </summary>
     public class OpenApiValidatorError : OpenApiError
     {
@@ -20,8 +20,6 @@ public class OpenApiValidatorError : OpenApiError
         /// </summary>
         public OpenApiValidatorError(string ruleName, string pointer, string message) : base(pointer, message)
         {
-            Pointer = pointer;
-            Message = message;
             RuleName = ruleName;
         }
 

src/Microsoft.OpenApi/Validations/Rules/OpenApiResponsesRules.cs

@@ -41,7 +41,6 @@ public static class OpenApiResponsesRules
                         if (key != "default" && !Regex.IsMatch(key, "^[1-5]([0-9][0-9]|XX)$"))
                         {
                             context.CreateError(nameof(ResponsesMustBeIdentifiedByDefaultOrStatusCode), 
-                                    
                                     "Responses key must be 'default', an HTTP status code, " +
                                     "or one of the following strings representing a range of HTTP status codes: " +
                                     "'1XX', '2XX', '3XX', '4XX', '5XX'");