Fixed more smells

Author: darrelmiller

src/Microsoft.OpenApi.Hidi/Formatters/PowerShellFormatter.cs

@@ -64,7 +64,7 @@ public override void Visit(OpenApiPathItem pathItem)
         public override void Visit(OpenApiOperation operation)
         {
             if (string.IsNullOrWhiteSpace(operation.OperationId))
-                throw new ArgumentNullException(nameof(operation.OperationId), $"OperationId is required {PathString}");
+                throw new ArgumentException(nameof(operation), $"OperationId is required {PathString}");
 
             var operationId = operation.OperationId;
             var operationTypeExtension = operation.Extensions.GetExtension("x-ms-docs-operation-type");
@@ -90,7 +90,6 @@ private static string ResolveVerbSegmentInOpertationId(string operationId)
             var charPos = operationId.LastIndexOf('.', operationId.Length - 1);
             if (operationId.Contains('_') || charPos < 0)
                 return operationId;
-            // TODO: Optimize this call.
             var newOperationId = new StringBuilder(operationId);
             newOperationId[charPos] = '_';
             operationId = newOperationId.ToString();

src/Microsoft.OpenApi.Hidi/Handlers/PluginCommandHandler.cs

@@ -37,10 +37,10 @@ public async Task<int> InvokeAsync(InvocationContext context)
             catch (Exception ex)
             {
 #if DEBUG
-                logger.LogCritical(ex, ex.Message);
+                logger.LogCritical(ex, "Command failed");
                 throw; // so debug tools go straight to the source of the exception when attached
 #else
-                logger.LogCritical( ex.Message);
+                logger.LogCritical(ex.Message);
                 return 1;
 #endif
             }

src/Microsoft.OpenApi.Hidi/Handlers/ShowCommandHandler.cs

@@ -37,7 +37,7 @@ public async Task<int> InvokeAsync(InvocationContext context)
             catch (Exception ex)
             {
 #if DEBUG
-                logger.LogCritical(ex, ex.Message);
+                logger.LogCritical(ex,  "Command failed");
                 throw; // so debug tools go straight to the source of the exception when attached
 #else
                 logger.LogCritical( ex.Message);

src/Microsoft.OpenApi.Hidi/Handlers/TransformCommandHandler.cs

@@ -37,7 +37,7 @@ public async Task<int> InvokeAsync(InvocationContext context)
             catch (Exception ex)
             {
 #if DEBUG
-                logger.LogCritical(ex, ex.Message);
+                logger.LogCritical(ex,  "Command failed");
                 throw; // so debug tools go straight to the source of the exception when attached
 #else
                 logger.LogCritical( ex.Message);

src/Microsoft.OpenApi.Hidi/Handlers/ValidateCommandHandler.cs

@@ -37,7 +37,7 @@ public async Task<int> InvokeAsync(InvocationContext context)
             catch (Exception ex)
             {
 #if DEBUG
-                logger.LogCritical(ex, ex.Message);
+                logger.LogCritical(ex, "Command failed");
                 throw; // so debug tools go straight to the source of the exception when attached
 #else
                 logger.LogCritical( ex.Message);

src/Microsoft.OpenApi.Hidi/OpenApiService.cs

@@ -214,7 +214,7 @@ private static async Task<OpenApiDocument> GetOpenApi(HidiOptions options, ILogg
             if (!string.IsNullOrEmpty(options.Csdl))
             {
                 var stopwatch = new Stopwatch();
-                using (logger.BeginScope($"Convert CSDL: {options.Csdl}", options.Csdl))
+                using (logger.BeginScope("Convert CSDL: {csdl}", options.Csdl))
                 {
                     stopwatch.Start();
                     stream = await GetStream(options.Csdl, logger, cancellationToken);
@@ -356,7 +356,7 @@ private static async Task<ReadResult> ParseOpenApi(string openApiFile, bool inli
         {
             ReadResult result;
             Stopwatch stopwatch = Stopwatch.StartNew();
-            using (logger.BeginScope($"Parsing OpenAPI: {openApiFile}", openApiFile))
+            using (logger.BeginScope("Parsing OpenAPI: {openApiFile}", openApiFile))
             {
                 stopwatch.Start();
 
@@ -621,7 +621,7 @@ private static void LogErrors(ILogger logger, ReadResult result)
                 {
                     foreach (var error in context.Errors)
                     {
-                        logger.LogError($"Detected error during parsing: {error}", error.ToString());
+                        logger.LogError("Detected error during parsing: {error}", error.ToString());
                     }
                 }
             }