More code/test cleanup

Author: MaggieKimani1

src/Microsoft.OpenApi.Readers/YamlConverter.cs

@@ -5,8 +5,6 @@
 using SharpYaml.Serialization;
 using SharpYaml;
 using System.Globalization;
-//using YamlDotNet.Core;
-//using YamlDotNet.RepresentationModel;
 
 namespace Microsoft.OpenApi.Readers
 {

src/Microsoft.OpenApi/Helpers/JsonNodeCloneHelper.cs

@@ -7,7 +7,7 @@
 
 namespace Microsoft.OpenApi.Helpers
 {
-    internal class JsonNodeCloneHelper
+    internal static class JsonNodeCloneHelper
     {
         internal static OpenApiAny Clone(OpenApiAny value)
         {

src/Microsoft.OpenApi/Validations/Rules/RuleHelpers.cs

@@ -85,11 +85,9 @@ public static void ValidateDataTypeMismatch(
                     return;
                 }
 
-                var anyObject = value as JsonObject;
-                
-                foreach (var property in anyObject)
+                if (value is JsonObject anyObject)
                 {
-                    if (anyObject != null)
+                    foreach (var property in anyObject)
                     {
                         context.Enter(property.Key);
                         if (schema.Properties.TryGetValue(property.Key, out var propertyValue))
@@ -102,7 +100,7 @@ public static void ValidateDataTypeMismatch(
                         }
 
                         context.Exit();
-                    }                    
+                    }
                 }
 
                 return;

test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDocumentTests.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. 
 
 using System;
@@ -1314,7 +1314,8 @@ public void HeaderParameterShouldAllowExample()
                             Type = ReferenceType.Header,
                             Id = "example-header"
                         }
-                    }, options => options.IgnoringCyclicReferences());
+                    }, options => options.IgnoringCyclicReferences()
+                    .Excluding(e => e.Example.Node.Parent));
 
                 var examplesHeader = openApiDoc.Components?.Headers?["examples-header"];
                 Assert.NotNull(examplesHeader);
@@ -1351,7 +1352,9 @@ public void HeaderParameterShouldAllowExample()
                             Type = ReferenceType.Header,
                             Id = "examples-header"
                         }
-                    }, options => options.IgnoringCyclicReferences());
+                    }, options => options.IgnoringCyclicReferences()
+                    .Excluding(e => e.Examples["uuid1"].Value.Node.Parent)
+                    .Excluding(e => e.Examples["uuid2"].Value.Node.Parent));
             }
         }