Refactor failing test

Author: MaggieKimani1

test/Microsoft.OpenApi.Readers.Tests/V31Tests/OpenApiDocumentTests.cs

@@ -7,6 +7,7 @@
 using Microsoft.OpenApi.Models;
 using Microsoft.OpenApi.Writers;
 using Xunit;
+using static System.Net.Mime.MediaTypeNames;
 
 namespace Microsoft.OpenApi.Readers.Tests.V31Tests
 {
@@ -69,7 +70,7 @@ public void ParseDocumentWithWebhooksShouldSucceed()
             {
                 Schemas =
                 {
-                    ["pet"] = petSchema,
+                    ["pet1"] = petSchema,
                     ["newPet"] = newPetSchema
                 }
             };
@@ -175,6 +176,7 @@ public void ParseDocumentWithWebhooksShouldSucceed()
             };
 
             // Assert
+            var schema = actual.Webhooks["/pets"].Operations[OperationType.Get].Responses["200"].Content["application/json"].Schema;
             diagnostic.Should().BeEquivalentTo(new OpenApiDiagnostic() { SpecificationVersion = OpenApiSpecVersion.OpenApi3_1 });
             actual.Should().BeEquivalentTo(expected);
         }
@@ -190,7 +192,7 @@ public void ParseDocumentsWithReusablePathItemInWebhooksSucceeds()
             {
                 Schemas = new Dictionary<string, JsonSchema>
                 {
-                    ["pet"] = new JsonSchemaBuilder()
+                    ["petSchema"] = new JsonSchemaBuilder()
                                 .Type(SchemaValueType.Object)
                                 .Required("id", "name")
                                 .Properties(
@@ -208,7 +210,7 @@ public void ParseDocumentsWithReusablePathItemInWebhooksSucceeds()
             };
 
             // Create a clone of the schema to avoid modifying things in components.
-            var petSchema = components.Schemas["pet"];
+            var petSchema = components.Schemas["petSchema"];
             var newPetSchema = components.Schemas["newPet"];
 
             components.PathItems = new Dictionary<string, OpenApiPathItem>
@@ -321,7 +323,6 @@ public void ParseDocumentsWithReusablePathItemInWebhooksSucceeds()
             actual.Should().BeEquivalentTo(expected);
             context.Should().BeEquivalentTo(
     new OpenApiDiagnostic() { SpecificationVersion = OpenApiSpecVersion.OpenApi3_1 });
-
         }
 
         [Fact]

test/Microsoft.OpenApi.Readers.Tests/V31Tests/Samples/OpenApiDocument/documentWithReusablePaths.yaml

@@ -8,7 +8,7 @@ webhooks:
     "$ref": '#/components/pathItems/pets'
 components:
   schemas:
-    pet:
+    petSchema:
         type: object
         required:
         - id
@@ -62,12 +62,12 @@ components:
                    schema:
                      type: array
                      items:
-                       "$ref": '#/components/schemas/pet'
+                       "$ref": '#/components/schemas/petSchema'
                  application/xml:
                    schema:
                      type: array
                      items:
-                       "$ref": '#/components/schemas/pet'
+                       "$ref": '#/components/schemas/petSchema'
         post:
           requestBody:
             description: Information about a new pet in the system
@@ -82,4 +82,4 @@ components:
               content:
                 application/json:
                   schema:
-                    $ref: '#/components/schemas/pet'
+                    $ref: '#/components/schemas/petSchema'

test/Microsoft.OpenApi.Readers.Tests/V31Tests/Samples/OpenApiDocument/documentWithWebhooks.yaml

@@ -31,12 +31,12 @@ webhooks:
                    schema:
                        type: array
                        items:
-                         "$ref": '#/components/schemas/pet'
+                         "$ref": '#/components/schemas/pet1'
                application/xml:
                    schema:
                        type: array
                        items:
-                         "$ref": '#/components/schemas/pet'
+                         "$ref": '#/components/schemas/pet1'
       post:
         requestBody:
           description: Information about a new pet in the system
@@ -51,10 +51,10 @@ webhooks:
             content:
               application/json:
                 schema:
-                  $ref: '#/components/schemas/pet'
+                  $ref: '#/components/schemas/pet1'
 components:
   schemas:
-    pet:
+    pet1:
         type: object
         required:
         - id

test/Microsoft.OpenApi.Tests/Workspaces/OpenApiWorkspaceTests.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
 using System;
@@ -77,7 +77,7 @@ public void OpenApiWorkspacesCanResolveExternalReferences()
             var workspace = new OpenApiWorkspace();
             var doc = CreateCommonDocument();
             var location = "common";
-
+            
             workspace.AddDocument(location, doc);
 
             var schema = workspace.ResolveJsonSchemaReference(new Uri("http://everything.json/common#/components/schemas/test"));
@@ -144,13 +144,10 @@ public void OpenApiWorkspacesCanResolveReferencesToDocumentFragments()
             // Arrange
             var workspace = new OpenApiWorkspace();
             var schemaFragment = new JsonSchemaBuilder().Type(SchemaValueType.String).Description("Schema from a fragment").Build();
-            //workspace.AddFragment("fragment", schemaFragment);
+            workspace.AddSchemaFragment("fragment", schemaFragment);
 
             // Act
-            var schema = workspace.ResolveReference(new OpenApiReference()
-            {
-                ExternalResource = "fragment"
-            }) as JsonSchema;
+            var schema = workspace.ResolveJsonSchemaReference(new Uri("http://everything.json/common#/components/schemas/test"));
 
             // Assert
             Assert.NotNull(schema);