fix: additional async APIs

Signed-off-by: Vincent Biret <[email protected]>

Author: baywet

test/Microsoft.OpenApi.Tests/Writers/OpenApiWriterAnyExtensionsTests.cs

@@ -23,12 +23,12 @@ public class OpenApiWriterAnyExtensionsTests
         [Theory]
         [InlineData(true)]
         [InlineData(false)]
-        public void WriteOpenApiNullAsJsonWorks(bool produceTerseOutput)
+        public async Task WriteOpenApiNullAsJsonWorksAsync(bool produceTerseOutput)
         {
             // Arrange
             var nullValue = new OpenApiNull();
 
-            var json = WriteAsJson(nullValue, produceTerseOutput);
+            var json = await WriteAsJsonAsync(nullValue, produceTerseOutput);
 
             // Assert
             json.Should().Be("null");
@@ -51,12 +51,12 @@ from shouldBeTerse in shouldProduceTerseOutputValues
 
         [Theory]
         [MemberData(nameof(IntInputs))]
-        public void WriteOpenApiIntegerAsJsonWorks(int input, bool produceTerseOutput)
+        public async Task WriteOpenApiIntegerAsJsonWorksAsync(int input, bool produceTerseOutput)
         {
             // Arrange
             var intValue = new OpenApiInteger(input);
 
-            var json = WriteAsJson(intValue, produceTerseOutput);
+            var json = await WriteAsJsonAsync(intValue, produceTerseOutput);
 
             // Assert
             json.Should().Be(input.ToString());
@@ -79,12 +79,12 @@ from shouldBeTerse in shouldProduceTerseOutputValues
 
         [Theory]
         [MemberData(nameof(LongInputs))]
-        public void WriteOpenApiLongAsJsonWorks(long input, bool produceTerseOutput)
+        public async Task WriteOpenApiLongAsJsonWorksAsync(long input, bool produceTerseOutput)
         {
             // Arrange
             var longValue = new OpenApiLong(input);
 
-            var json = WriteAsJson(longValue, produceTerseOutput);
+            var json = await WriteAsJsonAsync(longValue, produceTerseOutput);
 
             // Assert
             json.Should().Be(input.ToString());
@@ -107,12 +107,12 @@ from shouldBeTerse in shouldProduceTerseOutputValues
 
         [Theory]
         [MemberData(nameof(FloatInputs))]
-        public void WriteOpenApiFloatAsJsonWorks(float input, bool produceTerseOutput)
+        public async Task WriteOpenApiFloatAsJsonWorksAsync(float input, bool produceTerseOutput)
         {
             // Arrange
             var floatValue = new OpenApiFloat(input);
 
-            var json = WriteAsJson(floatValue, produceTerseOutput);
+            var json = await WriteAsJsonAsync(floatValue, produceTerseOutput);
 
             // Assert
             json.Should().Be(input.ToString());
@@ -135,12 +135,12 @@ from shouldBeTerse in shouldProduceTerseOutputValues
 
         [Theory]
         [MemberData(nameof(DoubleInputs))]
-        public void WriteOpenApiDoubleAsJsonWorks(double input, bool produceTerseOutput)
+        public async Task WriteOpenApiDoubleAsJsonWorksAsync(double input, bool produceTerseOutput)
         {
             // Arrange
             var doubleValue = new OpenApiDouble(input);
 
-            var json = WriteAsJson(doubleValue, produceTerseOutput);
+            var json = await WriteAsJsonAsync(doubleValue, produceTerseOutput);
 
             // Assert
             json.Should().Be(input.ToString());
@@ -164,13 +164,13 @@ from shouldBeTerse in shouldProduceTerseOutputValues
 
         [Theory]
         [MemberData(nameof(StringifiedDateTimes))]
-        public void WriteOpenApiDateTimeAsJsonWorks(string inputString, bool produceTerseOutput)
+        public async Task WriteOpenApiDateTimeAsJsonWorksAsync(string inputString, bool produceTerseOutput)
         {
             // Arrange
             var input = DateTimeOffset.Parse(inputString, CultureInfo.InvariantCulture);
             var dateTimeValue = new OpenApiDateTime(input);
 
-            var json = WriteAsJson(dateTimeValue, produceTerseOutput);
+            var json = await WriteAsJsonAsync(dateTimeValue, produceTerseOutput);
             var expectedJson = "\"" + input.ToString("o") + "\"";
 
             // Assert
@@ -187,12 +187,12 @@ from shouldBeTerse in shouldProduceTerseOutputValues
 
         [Theory]
         [MemberData(nameof(BooleanInputs))]
-        public void WriteOpenApiBooleanAsJsonWorks(bool input, bool produceTerseOutput)
+        public async Task WriteOpenApiBooleanAsJsonWorksAsync(bool input, bool produceTerseOutput)
         {
             // Arrange
             var boolValue = new OpenApiBoolean(input);
 
-            var json = WriteAsJson(boolValue, produceTerseOutput);
+            var json = await WriteAsJsonAsync(boolValue, produceTerseOutput);
 
             // Assert
             json.Should().Be(input.ToString().ToLower());
@@ -217,7 +217,7 @@ public async Task WriteOpenApiObjectAsJsonWorksAsync(bool produceTerseOutput)
                 }
             };
 
-            var actualJson = WriteAsJson(openApiObject, produceTerseOutput);
+            var actualJson = WriteAsJsonAsync(openApiObject, produceTerseOutput);
 
             // Assert
             await Verifier.Verify(actualJson).UseParameters(produceTerseOutput);
@@ -249,17 +249,17 @@ public async Task WriteOpenApiArrayAsJsonWorksAsync(bool produceTerseOutput)
                 new OpenApiString("stringValue2")
             };
 
-            var actualJson = WriteAsJson(array, produceTerseOutput);
+            var actualJson = WriteAsJsonAsync(array, produceTerseOutput);
 
             // Assert
             await Verifier.Verify(actualJson).UseParameters(produceTerseOutput);
         }
 
-        private static string WriteAsJson(IOpenApiAny any, bool produceTerseOutput = false)
+        private static async Task<string> WriteAsJsonAsync(IOpenApiAny any, bool produceTerseOutput = false)
         {
             // Arrange (continued)
-            var stream = new MemoryStream();
-            IOpenApiWriter writer = new OpenApiJsonWriter(
+            using var stream = new MemoryStream();
+            var writer = new OpenApiJsonWriter(
                 new StreamWriter(stream),
                 new() { Terse = produceTerseOutput });
 
@@ -268,7 +268,8 @@ private static string WriteAsJson(IOpenApiAny any, bool produceTerseOutput = fal
             stream.Position = 0;
 
             // Act
-            var value = new StreamReader(stream).ReadToEnd();
+            using var sr = new StreamReader(stream);
+            var value = await sr.ReadToEndAsync();
 
             if (any.AnyType is AnyType.Primitive or AnyType.Null)
             {