Code cleanup and refactoring

Author: MaggieKimani1

src/Microsoft.OpenApi.Readers/V2/OpenApiResponseDeserializer.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
 using System;
@@ -42,7 +42,7 @@ internal static partial class OpenApiV2Deserializer
         private static readonly PatternFieldMap<OpenApiResponse> _responsePatternFields =
             new()
             {
-                {s => s.StartsWith("x-") && !s.Equals(OpenApiConstants.ExamplesExtension), (o, p, n) => o.AddExtension(p, LoadExtension(p, n))}
+                {s => s.StartsWith("x-") && !s.Equals(OpenApiConstants.ExamplesExtension, StringComparison.OrdinalIgnoreCase), (o, p, n) => o.AddExtension(p, LoadExtension(p, n))}
             };
 
         private static readonly AnyFieldMap<OpenApiMediaType> _mediaTypeAnyFields =
@@ -125,7 +125,7 @@ private static void LoadExamplesExtension(OpenApiResponse response, ParseNode no
                             example.Description = valueNode.Value.GetScalarValue();
                             break;
                         case "value":
-                            example.Value = valueNode.Value.CreateAny();
+                            example.Value = OpenApiAnyConverter.GetSpecificOpenApiAny(valueNode.Value.CreateAny());
                             break;
                         case "externalValue":
                             example.ExternalValue = valueNode.Value.GetScalarValue();

src/Microsoft.OpenApi/Models/OpenApiParameter.cs

@@ -1,8 +1,9 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using Microsoft.OpenApi.Any;
 using Microsoft.OpenApi.Extensions;
 using Microsoft.OpenApi.Interfaces;

src/Microsoft.OpenApi/Models/OpenApiRequestBody.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
 using System;
@@ -145,7 +145,7 @@ internal OpenApiBodyParameter ConvertToBodyParameter()
                 // V2 spec actually allows the body to have custom name.
                 // To allow round-tripping we use an extension to hold the name
                 Name = "body",
-                Schema = Content.Values.FirstOrDefault()?.Schema ?? new JsonSchemaBuilder().Build(),
+                Schema = Content.Values.FirstOrDefault()?.Schema ?? new OpenApiSchema(),
                 Examples = Content.Values.FirstOrDefault()?.Examples,
                 Required = Required,
                 Extensions = Extensions.ToDictionary(static k => k.Key, static v => v.Value)  // Clone extensions so we can remove the x-bodyName extensions from the output V2 model.
@@ -179,7 +179,7 @@ internal IEnumerable<OpenApiFormDataParameter> ConvertToFormDataParameters()
                     Name = property.Key,
                     Schema = property.Value,
                     Examples = Content.Values.FirstOrDefault()?.Examples,
-                    Required = Content.First().Value.Schema.GetRequired()?.Contains(property.Key) ?? false
+                    Required = Content.First().Value.Schema.Required?.Contains(property.Key) ?? false
                 };
             }
         }

src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs

@@ -1,10 +1,11 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
 using System;
 using System.Collections.Generic;
 using System.IO;
 using Microsoft.OpenApi.Exceptions;
+using Microsoft.OpenApi.Models;
 using Microsoft.OpenApi.Properties;
 
 namespace Microsoft.OpenApi.Writers

test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.SerializeParameterWithSchemaReferenceAsV2JsonWorksAsync_produceTerseOutput=False.verified.txt

@@ -3,5 +3,11 @@
   "name": "name1",
   "description": "description1",
   "required": true,
-  "type": "string"
+  "type": "string",
+  "x-examples": {
+    "test": {
+      "summary": "summary3",
+      "description": "description3"
+    }
+  }
 }

test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.SerializeParameterWithSchemaReferenceAsV2JsonWorksAsync_produceTerseOutput=True.verified.txt

@@ -1 +1 @@
-{"in":"header","name":"name1","description":"description1","required":true,"type":"string"}
+{"in":"header","name":"name1","description":"description1","required":true,"type":"string","x-examples":{"test":{"summary":"summary3","description":"description3"}}}