Merge branch 'main' into fix/revert-to-IDictionary-and-allow-sorting

Author: MaggieKimani1

.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "2.0.0-preview.20"
+  ".": "2.0.0-preview.21"
 }

CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [2.0.0-preview.21](https://github.com/microsoft/OpenAPI.NET/compare/v2.0.0-preview.20...v2.0.0-preview.21) (2025-05-21)
+
+
+### Bug Fixes
+
+* do not throw when operation tag is missing matching global tag ([fe133f2](https://github.com/microsoft/OpenAPI.NET/commit/fe133f2604e9b65cc1c7011aab7c62f44e649d19))
+* do not throw when operation tag is missing matching global tag ([2c5aa40](https://github.com/microsoft/OpenAPI.NET/commit/2c5aa40cbb8bf1e96c1ccce6273579e70b69ade2))
+
 ## [2.0.0-preview.20](https://github.com/microsoft/OpenAPI.NET/compare/v2.0.0-preview.19...v2.0.0-preview.20) (2025-05-20)
 
 

Directory.Build.props

@@ -12,7 +12,7 @@
     <PackageProjectUrl>https://github.com/Microsoft/OpenAPI.NET</PackageProjectUrl>
     <Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
     <PackageTags>OpenAPI .NET</PackageTags>
-    <Version>2.0.0-preview.20</Version>
+    <Version>2.0.0-preview.21</Version>
   </PropertyGroup>
   <!-- https://github.com/clairernovotny/DeterministicBuilds#deterministic-builds -->
   <PropertyGroup Condition="'$(TF_BUILD)' == 'true'">

src/Microsoft.OpenApi/Models/OpenApiOperation.cs

@@ -183,7 +183,7 @@ private void SerializeInternal(IOpenApiWriter writer, OpenApiSpecVersion version
             // tags
             writer.WriteOptionalCollection(
                 OpenApiConstants.Tags,
-                VerifyTagReferences(Tags),
+                Tags,
                 callback);
 
             // summary
@@ -237,7 +237,7 @@ public virtual void SerializeAsV2(IOpenApiWriter writer)
             // tags
             writer.WriteOptionalCollection(
                 OpenApiConstants.Tags,
-                VerifyTagReferences(Tags),
+                Tags,
                 (w, t) => t.SerializeAsV2(w));
 
             // summary
@@ -356,21 +356,5 @@ public virtual void SerializeAsV2(IOpenApiWriter writer)
 
             writer.WriteEndObject();
         }
-
-        private static ISet<OpenApiTagReference>? VerifyTagReferences(ISet<OpenApiTagReference>? tags)
-        {
-            if (tags?.Count > 0)
-            {
-                foreach (var tag in tags)
-                {
-                    if (tag.Target is null)
-                    {
-                        throw new OpenApiException($"The OpenAPI tag reference '{tag.Reference.Id}' does not reference a valid tag.");
-                    }
-                }
-            }
-
-            return tags;
-        }
     }
 }

src/Microsoft.OpenApi/Models/References/OpenApiTagReference.cs

@@ -59,7 +59,7 @@ public string? Description
         public IDictionary<string, IOpenApiExtension>? Extensions { get => Target?.Extensions; }
 
         /// <inheritdoc/>
-        public string? Name { get => Target?.Name; }
+        public string? Name { get => Target?.Name ?? Reference?.Id; }
         /// <inheritdoc/>
         public override IOpenApiTag CopyReferenceAsTargetElementWithOverrides(IOpenApiTag source)
         {

test/Microsoft.OpenApi.Tests/Models/OpenApiOperationTests.cs

@@ -860,34 +860,5 @@ public void OpenApiOperationCopyConstructorWithAnnotationsSucceeds()
 
             Assert.NotEqual(baseOperation.Metadata["key1"], actualOperation.Metadata["key1"]);
         }
-
-        [Theory]
-        [InlineData(OpenApiSpecVersion.OpenApi2_0)]
-        [InlineData(OpenApiSpecVersion.OpenApi3_0)]
-        [InlineData(OpenApiSpecVersion.OpenApi3_1)]
-        public async Task SerializeAsJsonAsyncThrowsIfTagReferenceIsUnresolved(OpenApiSpecVersion version)
-        {
-            var document = new OpenApiDocument()
-            {
-                Tags = new HashSet<OpenApiTag>
-                {
-                    new() { Name = "one" },
-                    new() { Name = "three" }
-                }
-            };
-
-            var operation = new OpenApiOperation()
-            {
-                Tags = new HashSet<OpenApiTagReference>
-                {
-                    new("one", document),
-                    new("two", document),
-                    new("three", document)
-                }
-            };
-
-            var exception = await Assert.ThrowsAsync<OpenApiException>(() => operation.SerializeAsJsonAsync(version));
-            Assert.Equal("The OpenAPI tag reference 'two' does not reference a valid tag.", exception.Message);
-        }
     }
 }