Clean up tests and update public API

Author: MaggieKimani1

test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.cs

@@ -110,6 +110,20 @@ public class OpenApiParameterTests
             }
 
         };
+        
+        public static OpenApiParameter QueryParameterWithMissingStyle = new OpenApiParameter
+        {            
+            Name = "id",
+            In = ParameterLocation.Query,
+            Schema = new OpenApiSchema
+            {
+                Type = "object",
+                AdditionalProperties = new OpenApiSchema
+                {
+                    Type = "integer"
+                }                
+            }
+        };    
 
         public static OpenApiParameter AdvancedHeaderParameterWithSchemaReference = new OpenApiParameter
         {
@@ -186,7 +200,7 @@ public void WhenStyleIsFormTheDefaultValueOfExplodeShouldBeTrueOtherwiseFalse(Pa
 
             // Act & Assert
             parameter.Explode.Should().Be(expectedExplode);
-        }
+        }        
 
         [Theory]
         [InlineData(ParameterLocation.Path, ParameterStyle.Simple)]
@@ -197,16 +211,39 @@ public void WhenStyleIsFormTheDefaultValueOfExplodeShouldBeTrueOtherwiseFalse(Pa
         public void WhenStyleAndInIsNullTheDefaultValueOfStyleShouldBeSimple(ParameterLocation? inValue, ParameterStyle expectedStyle)
         {
             // Arrange
+            var outputStringWriter = new StringWriter(CultureInfo.InvariantCulture);
+            var writer = new OpenApiJsonWriter(outputStringWriter, new OpenApiJsonWriterSettings { Terse = false });
             var parameter = new OpenApiParameter
             {
                 Name = "name1",
                 In = inValue,
             };
 
             // Act & Assert
+            parameter.SerializeAsV3(writer);
+            writer.Flush();
+            
             parameter.Style.Should().Be(expectedStyle);
         }
 
+        [Fact]
+        public void SerializeQueryParameterWithMissingStyleSucceeds()
+        {
+            // Arrange
+            var expected = @"name: id
+in: query
+schema:
+  type: object
+  additionalProperties:
+    type: integer";
+
+            // Act
+            var actual = QueryParameterWithMissingStyle.SerializeAsYaml(OpenApiSpecVersion.OpenApi3_0);
+
+            // Assert
+            actual.MakeLineBreaksEnvironmentNeutral().Should().Be(expected.MakeLineBreaksEnvironmentNeutral());
+        }
+
         [Fact]
         public void SerializeBasicParameterAsV3JsonWorks()
         {

test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt

@@ -729,7 +729,6 @@ namespace Microsoft.OpenApi.Models
     }
     public class OpenApiParameter : Microsoft.OpenApi.Interfaces.IEffective<Microsoft.OpenApi.Models.OpenApiParameter>, Microsoft.OpenApi.Interfaces.IOpenApiElement, Microsoft.OpenApi.Interfaces.IOpenApiExtensible, Microsoft.OpenApi.Interfaces.IOpenApiReferenceable, Microsoft.OpenApi.Interfaces.IOpenApiSerializable
     {
-        public Microsoft.OpenApi.Models.ParameterStyle? _style;
         public OpenApiParameter() { }
         public OpenApiParameter(Microsoft.OpenApi.Models.OpenApiParameter parameter) { }
         public bool AllowEmptyValue { get; set; }