Simplify using statement, add tests, test file and cleanup

Author: MaggieKimani1

src/Microsoft.OpenApi.Readers/OpenApiYamlDocumentReader.cs

@@ -79,7 +79,6 @@ public OpenApiDocument Read(YamlDocument input, out OpenApiDiagnostic diagnostic
                 {
                     diagnostic.Warnings.Add(item);
                 }
-
             }
 
             return document;

test/Microsoft.OpenApi.Readers.Tests/Microsoft.OpenApi.Readers.Tests.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <TargetFrameworks>net6.0</TargetFrameworks>
         <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
@@ -137,6 +137,9 @@
       <EmbeddedResource Include="V3Tests\Samples\OpenApiDocument\minimalDocument.yaml">
         <CopyToOutputDirectory>Never</CopyToOutputDirectory>
       </EmbeddedResource>
+      <EmbeddedResource Include="V3Tests\Samples\OpenApiDocument\minimalDocumentWithWhitespace.yaml">
+        <CopyToOutputDirectory>Never</CopyToOutputDirectory>
+      </EmbeddedResource>
       <EmbeddedResource Include="V3Tests\Samples\OpenApiDocument\apiWithFullHeaderComponent.yaml">
         <CopyToOutputDirectory>Never</CopyToOutputDirectory>
       </EmbeddedResource>

test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDocumentTests.cs

@@ -243,26 +243,55 @@ public void ParseBrokenMinimalDocumentShouldYieldExpectedDiagnostic()
         [Fact]
         public void ParseMinimalDocumentShouldSucceed()
         {
-            using (var stream = Resources.GetStream(Path.Combine(SampleFolderPath, "minimalDocument.yaml")))
-            {
-                var openApiDoc = new OpenApiStreamReader().Read(stream, out var diagnostic);
+            using var stream = Resources.GetStream(Path.Combine(SampleFolderPath, "minimalDocument.yaml"));
+            var openApiDoc = new OpenApiStreamReader().Read(stream, out var diagnostic);
 
-                openApiDoc.Should().BeEquivalentTo(
-                    new OpenApiDocument
+            openApiDoc.Should().BeEquivalentTo(
+                new OpenApiDocument
+                {
+                    Info = new OpenApiInfo
                     {
-                        Info = new OpenApiInfo
-                        {
-                            Title = "Simple Document",
-                            Version = "0.9.1"
-                        },
-                        Paths = new OpenApiPaths()
-                    });
+                        Title = "Simple Document",
+                        Version = "0.9.1"
+                    },
+                    Paths = new OpenApiPaths()
+                });
 
-                diagnostic.Should().BeEquivalentTo(
-                    new OpenApiDiagnostic() { SpecificationVersion = OpenApiSpecVersion.OpenApi3_0 });
-            }
+            diagnostic.Should().BeEquivalentTo(
+                new OpenApiDiagnostic() { SpecificationVersion = OpenApiSpecVersion.OpenApi3_0 });
         }
 
+        [Fact]
+        public void TestHashCodesForSimilarOpenApiDocuments()
+        {
+            // Arrange
+            using var stream1 = Resources.GetStream(Path.Combine(SampleFolderPath, "minimalDocument.yaml"));
+            using var stream2 = Resources.GetStream(Path.Combine(SampleFolderPath, "minimalDocument.yaml"));
+            using var stream3 = Resources.GetStream(Path.Combine(SampleFolderPath, "minimalDocumentWithWhitespace.yaml"));
+
+            // Act
+            /*
+             Test whether reading in the same document twice yields the same hash code,
+             And reading in similar documents but one has a whitespace yields the same hash code
+            */
+            var openApiDoc1 = new OpenApiStreamReader().Read(stream1, out var diagnostic1);
+            var openApiDoc2 = new OpenApiStreamReader().Read(stream2, out var diagnostic2);
+            var openApiDoc3 = new OpenApiStreamReader().Read(stream3, out var diagnostic3);
+
+            // Assert
+            /* The assumption is, if doc1.Equals(doc2), then doc1.GetHashCode().Equals(doc2.GetHashCode())*/
+            if (openApiDoc1.Equals(openApiDoc2) && openApiDoc2.Equals(openApiDoc3))
+            {
+                Assert.Equal(diagnostic1.HashCode, diagnostic2.HashCode);
+                Assert.Equal(diagnostic2.HashCode, diagnostic3.HashCode);
+            }
+
+            /*Adding a server object to the original doc to check whether the hash code changes*/
+            openApiDoc1.Servers = new List<OpenApiServer>();
+            var hash = openApiDoc1.GetHashCode();
+            Assert.NotEqual(diagnostic1.HashCode, hash);
+        }        
+
         [Fact]
         public void ParseStandardPetStoreDocumentShouldSucceed()
         {

test/Microsoft.OpenApi.Readers.Tests/V3Tests/Samples/OpenApiDocument/minimalDocumentWithWhitespace.yaml

@@ -0,0 +1,9 @@
+openapi : 3.0.0
+info:
+    title: Simple Document
+    version: 0.9.1
+    
+paths: {}
+
+
+