Assign to a backing property in copy constructor instead of the virtual property

Author: MaggieKimani1

src/Microsoft.OpenApi/Models/OpenApiHeader.cs

@@ -19,6 +19,8 @@ namespace Microsoft.OpenApi.Models
     /// </summary>
     public class OpenApiHeader : IOpenApiSerializable, IOpenApiReferenceable, IOpenApiExtensible, IEffective<OpenApiHeader>
     {
+        private JsonSchema _schema;
+
         /// <summary>
         /// Indicates if object is populated with data or is just a reference to the data
         /// </summary>
@@ -66,9 +68,13 @@ public class OpenApiHeader : IOpenApiSerializable, IOpenApiReferenceable, IOpenA
         public virtual bool AllowReserved { get; set; }
 
         /// <summary>
-        /// The schema defining the type used for the header.
+        /// The schema defining the type used for the request body.
         /// </summary>
-        public virtual JsonSchema Schema { get; set; }
+        public virtual JsonSchema Schema 
+        { 
+            get => _schema; 
+            set => _schema = value;  
+        }
 
         /// <summary>
         /// Example of the media type.
@@ -109,7 +115,7 @@ public OpenApiHeader(OpenApiHeader header)
             Style = header?.Style ?? Style;
             Explode = header?.Explode ?? Explode;
             AllowReserved = header?.AllowReserved ?? AllowReserved;
-            Schema = InitializeSchema(header?.Schema);
+            _schema = JsonNodeCloneHelper.CloneJsonSchema(header?.Schema);
             Example = JsonNodeCloneHelper.Clone(header?.Example);
             Examples = header?.Examples != null ? new Dictionary<string, OpenApiExample>(header.Examples) : null;
             Content = header?.Content != null ? new Dictionary<string, OpenApiMediaType>(header.Content) : null;
@@ -299,14 +305,5 @@ public void SerializeAsV2WithoutReference(IOpenApiWriter writer)
 
             writer.WriteEndObject();
         }
-
-        /// <summary>
-        /// Clone a JSON schema instance
-        /// </summary>
-        /// <returns></returns>
-        protected JsonSchema InitializeSchema(JsonSchema schema)
-        {
-            return JsonNodeCloneHelper.CloneJsonSchema(Schema);
-        }
     }
 }

src/Microsoft.OpenApi/Models/OpenApiMediaType.cs

@@ -17,10 +17,16 @@ namespace Microsoft.OpenApi.Models
     /// </summary>
     public class OpenApiMediaType : IOpenApiSerializable, IOpenApiExtensible
     {
+        private JsonSchema _schema;
+
         /// <summary>
         /// The schema defining the type used for the request body.
         /// </summary>
-        public virtual JsonSchema Schema { get; set; }
+        public virtual JsonSchema Schema
+        {
+            get => _schema;
+            set => _schema = value;
+        }
 
         /// <summary>
         /// Example of the media type.
@@ -57,7 +63,7 @@ public OpenApiMediaType() { }
         /// </summary>
         public OpenApiMediaType(OpenApiMediaType mediaType)
         {
-            Schema = InitializeSchema(mediaType?.Schema);
+            _schema = JsonNodeCloneHelper.CloneJsonSchema(mediaType?.Schema);
             Example = JsonNodeCloneHelper.Clone(mediaType?.Example);
             Examples = mediaType?.Examples != null ? new Dictionary<string, OpenApiExample>(mediaType.Examples) : null;
             Encoding = mediaType?.Encoding != null ? new Dictionary<string, OpenApiEncoding>(mediaType.Encoding) : null;
@@ -115,14 +121,5 @@ public void SerializeAsV2(IOpenApiWriter writer)
         {
             // Media type does not exist in V2.
         }
-
-        /// <summary>
-        /// Clones a JSON schema instance
-        /// </summary>
-        /// <returns></returns>
-        protected JsonSchema InitializeSchema(JsonSchema schema)
-        {
-            return JsonNodeCloneHelper.CloneJsonSchema(Schema);
-        }
     }
 }

src/Microsoft.OpenApi/Models/OpenApiParameter.cs

@@ -20,6 +20,7 @@ public class OpenApiParameter : IOpenApiSerializable, IOpenApiReferenceable, IEf
     {
         private bool? _explode;
         private ParameterStyle? _style;
+        private JsonSchema _schema;
 
         /// <summary>
         /// Indicates if object is populated with data or is just a reference to the data
@@ -107,7 +108,11 @@ public virtual bool Explode
         /// <summary>
         /// The schema defining the type used for the request body.
         /// </summary>
-        public virtual JsonSchema Schema { get; set; }
+        public virtual JsonSchema Schema 
+        { 
+            get => _schema; 
+            set => _schema = value;  
+        }
 
         /// <summary>
         /// Examples of the media type. Each example SHOULD contain a value
@@ -163,7 +168,7 @@ public OpenApiParameter(OpenApiParameter parameter)
             Style = parameter?.Style ?? Style;
             Explode = parameter?.Explode ?? Explode;
             AllowReserved = parameter?.AllowReserved ?? AllowReserved;
-            Schema = InitializeSchema(parameter?.Schema);
+            _schema = JsonNodeCloneHelper.CloneJsonSchema(parameter?.Schema);
             Examples = parameter?.Examples != null ? new Dictionary<string, OpenApiExample>(parameter.Examples) : null;
             Example = JsonNodeCloneHelper.Clone(parameter?.Example);
             Content = parameter?.Content != null ? new Dictionary<string, OpenApiMediaType>(parameter.Content) : null;
@@ -447,15 +452,6 @@ public void SerializeAsV2WithoutReference(IOpenApiWriter writer)
 
             return Style;
         }
-
-        /// <summary>
-        /// Clones an instance of a JSON schema
-        /// </summary>
-        /// <returns></returns>
-        protected JsonSchema InitializeSchema(JsonSchema schema)
-        {
-            return JsonNodeCloneHelper.CloneJsonSchema(schema);
-        }
     }
 
     /// <summary>