Clean up and add copy constructors

Author: MaggieKimani1

src/Microsoft.OpenApi/Any/IOpenApiAny.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. 
 
-using System;
 using Microsoft.OpenApi.Interfaces;
 
 namespace Microsoft.OpenApi.Any

src/Microsoft.OpenApi/Any/CloneHelper.cs renamed to src/Microsoft.OpenApi/Any/OpenApiAnyCloneHelper.cs

@@ -8,7 +8,7 @@ namespace Microsoft.OpenApi.Any
     /// <summary>
     /// Contains logic for cloning objects through copy constructors.
     /// </summary>
-    public class CloneHelper
+    public class OpenApiAnyCloneHelper
     {
         /// <summary>
         /// Clones an instance of <see cref="IOpenApiAny"/> object from the copy constructor

src/Microsoft.OpenApi/Any/OpenApiArray.cs

@@ -17,6 +17,19 @@ public class OpenApiArray : List<IOpenApiAny>, IOpenApiAny
         /// </summary>
         public AnyType AnyType { get; } = AnyType.Array;
 
+        /// <summary>
+        /// Parameterless constructor
+        /// </summary>
+        public OpenApiArray() { }
+
+        /// <summary>
+        /// Initializes a copy of <see cref="OpenApiArray"/> object
+        /// </summary>
+        public OpenApiArray(OpenApiArray array)
+        {
+            AnyType = array.AnyType;
+        }
+
         /// <summary>
         /// Write out contents of OpenApiArray to passed writer
         /// </summary>

src/Microsoft.OpenApi/Any/OpenApiNull.cs

@@ -15,6 +15,19 @@ public class OpenApiNull : IOpenApiAny
         /// </summary>
         public AnyType AnyType { get; } = AnyType.Null;
 
+        /// <summary>
+        /// Parameterless constructor
+        /// </summary>
+        public OpenApiNull() { }
+
+        /// <summary>
+        /// Initializes a copy of <see cref="OpenApiNull"/> object
+        /// </summary>
+        public OpenApiNull(OpenApiNull openApiNull)
+        {
+            AnyType = openApiNull.AnyType;
+        }
+
         /// <summary>
         /// Write out null representation
         /// </summary>

src/Microsoft.OpenApi/Any/OpenApiObject.cs

@@ -16,6 +16,19 @@ public class OpenApiObject : Dictionary<string, IOpenApiAny>, IOpenApiAny
         /// </summary>
         public AnyType AnyType { get; } = AnyType.Object;
 
+        /// <summary>
+        /// Parameterless constructor
+        /// </summary>
+        public OpenApiObject() { }
+
+        /// <summary>
+        /// Initializes a copy of <see cref="OpenApiObject"/> object
+        /// </summary>
+        public OpenApiObject(OpenApiObject obj)
+        {
+            AnyType = obj.AnyType;
+        }
+
         /// <summary>
         /// Serialize OpenApiObject to writer
         /// </summary>

src/Microsoft.OpenApi/Models/OpenApiExample.cs

@@ -66,7 +66,7 @@ public OpenApiExample(OpenApiExample example)
         {
             Summary = example.Summary;
             Description = example.Description;
-            Value = CloneHelper.CloneFromCopyConstructor(example.Value);
+            Value = OpenApiAnyCloneHelper.CloneFromCopyConstructor(example.Value);
             ExternalValue = example.ExternalValue;
             Extensions = new Dictionary<string, IOpenApiExtension>(example.Extensions);
             Reference = new(example.Reference);

src/Microsoft.OpenApi/Models/OpenApiHeader.cs

@@ -106,7 +106,7 @@ public OpenApiHeader(OpenApiHeader header)
             Explode = header.Explode;
             AllowReserved = header.AllowReserved;
             Schema = new(header.Schema);
-            Example = CloneHelper.CloneFromCopyConstructor(header.Example);
+            Example = OpenApiAnyCloneHelper.CloneFromCopyConstructor(header.Example);
             Examples = new Dictionary<string, OpenApiExample>(header.Examples);
             Content = new Dictionary<string, OpenApiMediaType>(header.Content);
             Extensions = new Dictionary<string, IOpenApiExtension>(header.Extensions);

src/Microsoft.OpenApi/Models/OpenApiMediaType.cs

@@ -54,7 +54,7 @@ public OpenApiMediaType() {}
         public OpenApiMediaType(OpenApiMediaType mediaType)
         {
             Schema = new(mediaType.Schema);
-            Example = CloneHelper.CloneFromCopyConstructor(mediaType.Example);
+            Example = OpenApiAnyCloneHelper.CloneFromCopyConstructor(mediaType.Example);
             Examples = new Dictionary<string, OpenApiExample>(mediaType.Examples);
             Encoding = new Dictionary<string, OpenApiEncoding>(mediaType.Encoding);
             Extensions = new Dictionary<string, IOpenApiExtension>(mediaType.Extensions);

src/Microsoft.OpenApi/Models/OpenApiParameter.cs

@@ -157,7 +157,7 @@ public OpenApiParameter(OpenApiParameter parameter)
             AllowReserved = parameter.AllowReserved;
             Schema = new(parameter.Schema);
             Examples = new Dictionary<string, OpenApiExample>(parameter.Examples);
-            Example = CloneHelper.CloneFromCopyConstructor(parameter.Example);
+            Example = OpenApiAnyCloneHelper.CloneFromCopyConstructor(parameter.Example);
             Content = new Dictionary<string, OpenApiMediaType>(parameter.Content);
             Extensions = new Dictionary<string, IOpenApiExtension>(parameter.Extensions);
             AllowEmptyValue = parameter.AllowEmptyValue;

src/Microsoft.OpenApi/Models/OpenApiSchema.cs

@@ -264,7 +264,7 @@ public OpenApiSchema(OpenApiSchema schema)
             MinLength = schema.MinLength;
             Pattern = schema.Pattern;
             MultipleOf = schema.MultipleOf;
-            Default = CloneHelper.CloneFromCopyConstructor(schema.Default);
+            Default = OpenApiAnyCloneHelper.CloneFromCopyConstructor(schema.Default);
             ReadOnly = schema.ReadOnly;
             WriteOnly = schema.WriteOnly;
             AllOf = new List<OpenApiSchema>(schema.AllOf);
@@ -282,7 +282,7 @@ public OpenApiSchema(OpenApiSchema schema)
             AdditionalPropertiesAllowed = schema.AdditionalPropertiesAllowed;
             AdditionalProperties = new(schema.AdditionalProperties);
             Discriminator = new(schema.Discriminator);
-            Example = CloneHelper.CloneFromCopyConstructor(schema.Example);
+            Example = OpenApiAnyCloneHelper.CloneFromCopyConstructor(schema.Example);
             Enum = new List<IOpenApiAny>(schema.Enum);
             Nullable = schema.Nullable;
             ExternalDocs = new(schema.ExternalDocs);