fix: makes target field read only

baywet · baywet · commit 89881fd5fa28 · 2025-02-04T12:32:27.000-05:00
Signed-off-by: Vincent Biret &lt;vibiret@microsoft.com&gt;
diff --git a/src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs b/src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs
@@ -13,14 +13,14 @@ public abstract class BaseOpenApiReferenceHolder<T, V> : IOpenApiReferenceHolder
     /// <summary>
     /// The resolved target object.
     /// </summary>
-    protected T _target;
+    protected readonly T _target;
     /// <inheritdoc/>
     public virtual T Target
     {
         get
         {
-            _target ??= Reference.HostDocument?.ResolveReferenceTo<T>(Reference);
-            return _target;
+            if (_target is not null) return _target;
+            return Reference.HostDocument?.ResolveReferenceTo<T>(Reference);
         }
     }
     /// <summary>
@@ -36,6 +36,7 @@ protected BaseOpenApiReferenceHolder(BaseOpenApiReferenceHolder<T, V> source)
     }
     private protected BaseOpenApiReferenceHolder(T target, string referenceId, ReferenceType referenceType)
     {
+        Utils.CheckArgumentNull(target);
         _target = target;
 
         Reference = new OpenApiReference()
diff --git a/src/Microsoft.OpenApi/Models/References/OpenApiTagReference.cs b/src/Microsoft.OpenApi/Models/References/OpenApiTagReference.cs
@@ -21,8 +21,8 @@ public override OpenApiTag Target
         {
             get
             {
-                _target ??= Reference.HostDocument?.Tags.FirstOrDefault(t => StringComparer.Ordinal.Equals(t.Name, Reference.Id));
-                return _target;
+                if (_target is not null) return _target;
+                return Reference.HostDocument?.Tags.FirstOrDefault(t => StringComparer.Ordinal.Equals(t.Name, Reference.Id));
             }
         }
 
diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiCallbackTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiCallbackTests.cs
@@ -16,7 +16,7 @@ namespace Microsoft.OpenApi.Tests.Models
     [Collection("DefaultSettings")]
     public class OpenApiCallbackTests
     {
-        public static OpenApiCallback AdvancedCallback = new()
+        private static OpenApiCallback AdvancedCallback => new()
         {
             PathItems =
             {
@@ -54,9 +54,9 @@ public class OpenApiCallbackTests
             }
         };
 
-        public static OpenApiCallbackReference CallbackProxy = new(ReferencedCallback, "simpleHook");
+        private static OpenApiCallbackReference CallbackProxy => new(ReferencedCallback, "simpleHook");
 
-        public static OpenApiCallback ReferencedCallback = new()
+        private static OpenApiCallback ReferencedCallback => new()
         {
             PathItems =
             {
diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiExampleTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiExampleTests.cs
@@ -19,7 +19,7 @@ namespace Microsoft.OpenApi.Tests.Models
     [Collection("DefaultSettings")]
     public class OpenApiExampleTests
     {
-        public static OpenApiExample AdvancedExample = new()
+        private static OpenApiExample AdvancedExample => new()
         {
             Value = new JsonObject
             {
@@ -57,8 +57,8 @@ public class OpenApiExampleTests
             }
         };
 
-        public static OpenApiExampleReference OpenApiExampleReference = new(ReferencedExample, "example1");
-        public static OpenApiExample ReferencedExample = new()
+        private static OpenApiExampleReference OpenApiExampleReference => new(ReferencedExample, "example1");
+        private static OpenApiExample ReferencedExample => new()
         {
             Value = new JsonObject
             {
diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiHeaderTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiHeaderTests.cs
@@ -15,7 +15,7 @@ namespace Microsoft.OpenApi.Tests.Models
     [Collection("DefaultSettings")]
     public class OpenApiHeaderTests
     {
-        public static OpenApiHeader AdvancedHeader = new()
+        private static OpenApiHeader AdvancedHeader => new()
         {
             Description = "sampleHeader",
             Schema = new OpenApiSchema()
@@ -25,9 +25,9 @@ public class OpenApiHeaderTests
             }
         };
 
-        public static OpenApiHeaderReference OpenApiHeaderReference = new(ReferencedHeader, "example1");
+        private static OpenApiHeaderReference OpenApiHeaderReference => new(ReferencedHeader, "example1");
 
-        public static OpenApiHeader ReferencedHeader = new()
+        private static OpenApiHeader ReferencedHeader => new()
         {
             Description = "sampleHeader",
             Schema = new OpenApiSchema()
diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiLinkTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiLinkTests.cs
@@ -18,7 +18,7 @@ namespace Microsoft.OpenApi.Tests.Models
     [Collection("DefaultSettings")]
     public class OpenApiLinkTests
     {
-        public static readonly OpenApiLink AdvancedLink = new()
+        private static OpenApiLink AdvancedLink => new()
         {
             OperationId = "operationId1",
             Parameters =
@@ -42,8 +42,8 @@ public class OpenApiLinkTests
             }
         };
 
-        public static readonly OpenApiLinkReference LinkReference = new(ReferencedLink, "example1");
-        public static readonly OpenApiLink ReferencedLink = new()
+        private static OpenApiLinkReference LinkReference => new(ReferencedLink, "example1");
+        private static OpenApiLink ReferencedLink => new()
         {
             OperationId = "operationId1",
             Parameters =
diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.cs
@@ -19,20 +19,20 @@ namespace Microsoft.OpenApi.Tests.Models
     [Collection("DefaultSettings")]
     public class OpenApiParameterTests
     {
-        public static OpenApiParameter BasicParameter = new()
+        private static OpenApiParameter BasicParameter => new()
         {
             Name = "name1",
             In = ParameterLocation.Path
         };
 
-        public static OpenApiParameterReference OpenApiParameterReference = new(ReferencedParameter, "example1");
-        public static OpenApiParameter ReferencedParameter = new()
+        private static OpenApiParameterReference OpenApiParameterReference => new(ReferencedParameter, "example1");
+        private static OpenApiParameter ReferencedParameter => new()
         {
             Name = "name1",
             In = ParameterLocation.Path
         };
 
-        public static OpenApiParameter AdvancedPathParameterWithSchema = new()
+        private static OpenApiParameter AdvancedPathParameterWithSchema => new()
         {
             Name = "name1",
             In = ParameterLocation.Path,
@@ -61,7 +61,7 @@ public class OpenApiParameterTests
             }
         };
 
-        public static OpenApiParameter ParameterWithFormStyleAndExplodeFalse = new()
+        private static OpenApiParameter ParameterWithFormStyleAndExplodeFalse => new()
         {
             Name = "name1",
             In = ParameterLocation.Query,
@@ -82,7 +82,7 @@ public class OpenApiParameterTests
             }
         };
 
-        public static OpenApiParameter ParameterWithFormStyleAndExplodeTrue = new()
+        private static OpenApiParameter ParameterWithFormStyleAndExplodeTrue => new()
         {
             Name = "name1",
             In = ParameterLocation.Query,
@@ -103,7 +103,7 @@ public class OpenApiParameterTests
             }
         };
 
-        public static OpenApiParameter QueryParameterWithMissingStyle = new OpenApiParameter
+        private static OpenApiParameter QueryParameterWithMissingStyle => new OpenApiParameter
         {
             Name = "id",
             In = ParameterLocation.Query,
@@ -117,7 +117,7 @@ public class OpenApiParameterTests
             }
         };
 
-        public static OpenApiParameter AdvancedHeaderParameterWithSchemaTypeObject = new()
+        private static OpenApiParameter AdvancedHeaderParameterWithSchemaTypeObject => new()
         {
             Name = "name1",
             In = ParameterLocation.Header,
diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiRequestBodyTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiRequestBodyTests.cs
@@ -15,7 +15,7 @@ namespace Microsoft.OpenApi.Tests.Models
     [Collection("DefaultSettings")]
     public class OpenApiRequestBodyTests
     {
-        public static OpenApiRequestBody AdvancedRequestBody = new()
+        private static OpenApiRequestBody AdvancedRequestBody => new()
         {
             Description = "description",
             Required = true,
@@ -31,8 +31,8 @@ public class OpenApiRequestBodyTests
             }
         };
 
-        public static OpenApiRequestBodyReference OpenApiRequestBodyReference = new(ReferencedRequestBody, "example1");
-        public static OpenApiRequestBody ReferencedRequestBody = new()
+        private static OpenApiRequestBodyReference OpenApiRequestBodyReference => new(ReferencedRequestBody, "example1");
+        private static OpenApiRequestBody ReferencedRequestBody => new()
         {
             Description = "description",
             Required = true,
diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiResponseTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiResponseTests.cs
@@ -20,9 +20,9 @@ namespace Microsoft.OpenApi.Tests.Models
     [Collection("DefaultSettings")]
     public class OpenApiResponseTests
     {
-        public static OpenApiResponse BasicResponse = new OpenApiResponse();
+        private static OpenApiResponse BasicResponse => new OpenApiResponse();
 
-        public static OpenApiResponse AdvancedV2Response = new OpenApiResponse
+        private static OpenApiResponse AdvancedV2Response => new OpenApiResponse
         {
             Description = "A complex object array response",
             Content =
@@ -61,7 +61,7 @@ public class OpenApiResponseTests
                 },
             }
         };
-        public static OpenApiResponse AdvancedV3Response = new OpenApiResponse
+        private static OpenApiResponse AdvancedV3Response => new OpenApiResponse
         {
             Description = "A complex object array response",
             Content =
@@ -101,8 +101,8 @@ public class OpenApiResponseTests
             }
         };
 
-        public static OpenApiResponseReference V2OpenApiResponseReference = new OpenApiResponseReference(ReferencedV2Response, "example1");
-        public static OpenApiResponse ReferencedV2Response = new OpenApiResponse
+        private static OpenApiResponseReference V2OpenApiResponseReference => new OpenApiResponseReference(ReferencedV2Response, "example1");
+        private static OpenApiResponse ReferencedV2Response => new OpenApiResponse
         {
             Description = "A complex object array response",
             Content =
@@ -136,9 +136,9 @@ public class OpenApiResponseTests
                 },
             }
         };
-        public static OpenApiResponseReference V3OpenApiResponseReference = new OpenApiResponseReference(ReferencedV3Response, "example1");
+        private static OpenApiResponseReference V3OpenApiResponseReference => new OpenApiResponseReference(ReferencedV3Response, "example1");
 
-        public static OpenApiResponse ReferencedV3Response = new OpenApiResponse
+        private static OpenApiResponse ReferencedV3Response => new OpenApiResponse
         {
             Description = "A complex object array response",
             Content =
diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiSecuritySchemeTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiSecuritySchemeTests.cs
@@ -17,30 +17,30 @@ namespace Microsoft.OpenApi.Tests.Models
     [Collection("DefaultSettings")]
     public class OpenApiSecuritySchemeTests
     {
-        public static OpenApiSecurityScheme ApiKeySecurityScheme = new()
+        private static OpenApiSecurityScheme ApiKeySecurityScheme => new()
         {
             Description = "description1",
             Name = "parameterName",
             Type = SecuritySchemeType.ApiKey,
             In = ParameterLocation.Query,
         };
 
-        public static OpenApiSecurityScheme HttpBasicSecurityScheme = new()
+        private static OpenApiSecurityScheme HttpBasicSecurityScheme => new()
         {
             Description = "description1",
             Type = SecuritySchemeType.Http,
             Scheme = OpenApiConstants.Basic
         };
 
-        public static OpenApiSecurityScheme HttpBearerSecurityScheme = new()
+        private static OpenApiSecurityScheme HttpBearerSecurityScheme => new()
         {
             Description = "description1",
             Type = SecuritySchemeType.Http,
             Scheme = OpenApiConstants.Bearer,
             BearerFormat = OpenApiConstants.Jwt
         };
 
-        public static OpenApiSecurityScheme OAuth2SingleFlowSecurityScheme = new()
+        private static OpenApiSecurityScheme OAuth2SingleFlowSecurityScheme => new()
         {
             Description = "description1",
             Type = SecuritySchemeType.OAuth2,
@@ -58,7 +58,7 @@ public class OpenApiSecuritySchemeTests
             }
         };
 
-        public static OpenApiSecurityScheme OAuth2MultipleFlowSecurityScheme = new()
+        private static OpenApiSecurityScheme OAuth2MultipleFlowSecurityScheme => new()
         {
             Description = "description1",
             Type = SecuritySchemeType.OAuth2,
@@ -96,16 +96,16 @@ public class OpenApiSecuritySchemeTests
             }
         };
 
-        public static OpenApiSecurityScheme OpenIdConnectSecurityScheme = new()
+        private static OpenApiSecurityScheme OpenIdConnectSecurityScheme => new()
         {
             Description = "description1",
             Type = SecuritySchemeType.OpenIdConnect,
             Scheme = OpenApiConstants.Bearer,
             OpenIdConnectUrl = new("https://example.com/openIdConnect")
         };
 
-        public static OpenApiSecuritySchemeReference OpenApiSecuritySchemeReference = new(ReferencedSecurityScheme, "sampleSecurityScheme");
-        public static OpenApiSecurityScheme ReferencedSecurityScheme = new()
+        private static OpenApiSecuritySchemeReference OpenApiSecuritySchemeReference => new(ReferencedSecurityScheme, "sampleSecurityScheme");
+        private static OpenApiSecurityScheme ReferencedSecurityScheme => new()
         {
             Description = "description1",
             Type = SecuritySchemeType.OpenIdConnect,
diff --git a/test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt b/test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt
@@ -1240,7 +1240,7 @@ namespace Microsoft.OpenApi.Models.References
         where T :  class, Microsoft.OpenApi.Interfaces.IOpenApiReferenceable, V
         where V : Microsoft.OpenApi.Interfaces.IOpenApiSerializable
     {
-        protected T _target;
+        protected readonly T _target;
         protected BaseOpenApiReferenceHolder(Microsoft.OpenApi.Models.References.BaseOpenApiReferenceHolder<T, V> source) { }
         protected BaseOpenApiReferenceHolder(string referenceId, Microsoft.OpenApi.Models.OpenApiDocument hostDocument, Microsoft.OpenApi.Models.ReferenceType referenceType, string externalResource = null) { }
         public Microsoft.OpenApi.Models.OpenApiReference Reference { get; set; }

Original file line number	Diff line number	Diff line change
`@@ -13,14 +13,14 @@ public abstract class BaseOpenApiReferenceHolder<T, V> : IOpenApiReferenceHolder`
`13`	`13`	`/// <summary>`
`14`	`14`	`/// The resolved target object.`
`15`	`15`	`/// </summary>`
`16`		`- protected T _target;`
	`16`	`+ protected readonly T _target;`
`17`	`17`	`/// <inheritdoc/>`
`18`	`18`	`public virtual T Target`
`19`	`19`	`{`
`20`	`20`	`get`
`21`	`21`	`{`
`22`		`- _target ??= Reference.HostDocument?.ResolveReferenceTo<T>(Reference);`
`23`		`- return _target;`
	`22`	`+ if (_target is not null) return _target;`
	`23`	`+ return Reference.HostDocument?.ResolveReferenceTo<T>(Reference);`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`	`/// <summary>`
`@@ -36,6 +36,7 @@ protected BaseOpenApiReferenceHolder(BaseOpenApiReferenceHolder<T, V> source)`
`36`	`36`	`}`
`37`	`37`	`private protected BaseOpenApiReferenceHolder(T target, string referenceId, ReferenceType referenceType)`
`38`	`38`	`{`
	`39`	`+ Utils.CheckArgumentNull(target);`
`39`	`40`	`_target = target;`
`40`	`41`
`41`	`42`	`Reference = new OpenApiReference()`
Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,8 @@ public override OpenApiTag Target`
`21`	`21`	`{`
`22`	`22`	`get`
`23`	`23`	`{`
`24`		`- _target ??= Reference.HostDocument?.Tags.FirstOrDefault(t => StringComparer.Ordinal.Equals(t.Name, Reference.Id));`
`25`		`- return _target;`
	`24`	`+ if (_target is not null) return _target;`
	`25`	`+ return Reference.HostDocument?.Tags.FirstOrDefault(t => StringComparer.Ordinal.Equals(t.Name, Reference.Id));`
`26`	`26`	`}`
`27`	`27`	`}`
`28`	`28`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ namespace Microsoft.OpenApi.Tests.Models`
`16`	`16`	`[Collection("DefaultSettings")]`
`17`	`17`	`public class OpenApiCallbackTests`
`18`	`18`	`{`
`19`		`- public static OpenApiCallback AdvancedCallback = new()`
	`19`	`+ private static OpenApiCallback AdvancedCallback => new()`
`20`	`20`	`{`
`21`	`21`	`PathItems =`
`22`	`22`	`{`
`@@ -54,9 +54,9 @@ public class OpenApiCallbackTests`
`54`	`54`	`}`
`55`	`55`	`};`
`56`	`56`
`57`		`- public static OpenApiCallbackReference CallbackProxy = new(ReferencedCallback, "simpleHook");`
	`57`	`+ private static OpenApiCallbackReference CallbackProxy => new(ReferencedCallback, "simpleHook");`
`58`	`58`
`59`		`- public static OpenApiCallback ReferencedCallback = new()`
	`59`	`+ private static OpenApiCallback ReferencedCallback => new()`
`60`	`60`	`{`
`61`	`61`	`PathItems =`
`62`	`62`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ namespace Microsoft.OpenApi.Tests.Models`
`19`	`19`	`[Collection("DefaultSettings")]`
`20`	`20`	`public class OpenApiExampleTests`
`21`	`21`	`{`
`22`		`- public static OpenApiExample AdvancedExample = new()`
	`22`	`+ private static OpenApiExample AdvancedExample => new()`
`23`	`23`	`{`
`24`	`24`	`Value = new JsonObject`
`25`	`25`	`{`
`@@ -57,8 +57,8 @@ public class OpenApiExampleTests`
`57`	`57`	`}`
`58`	`58`	`};`
`59`	`59`
`60`		`- public static OpenApiExampleReference OpenApiExampleReference = new(ReferencedExample, "example1");`
`61`		`- public static OpenApiExample ReferencedExample = new()`
	`60`	`+ private static OpenApiExampleReference OpenApiExampleReference => new(ReferencedExample, "example1");`
	`61`	`+ private static OpenApiExample ReferencedExample => new()`
`62`	`62`	`{`
`63`	`63`	`Value = new JsonObject`
`64`	`64`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ namespace Microsoft.OpenApi.Tests.Models`
`15`	`15`	`[Collection("DefaultSettings")]`
`16`	`16`	`public class OpenApiHeaderTests`
`17`	`17`	`{`
`18`		`- public static OpenApiHeader AdvancedHeader = new()`
	`18`	`+ private static OpenApiHeader AdvancedHeader => new()`
`19`	`19`	`{`
`20`	`20`	`Description = "sampleHeader",`
`21`	`21`	`Schema = new OpenApiSchema()`
`@@ -25,9 +25,9 @@ public class OpenApiHeaderTests`
`25`	`25`	`}`
`26`	`26`	`};`
`27`	`27`
`28`		`- public static OpenApiHeaderReference OpenApiHeaderReference = new(ReferencedHeader, "example1");`
	`28`	`+ private static OpenApiHeaderReference OpenApiHeaderReference => new(ReferencedHeader, "example1");`
`29`	`29`
`30`		`- public static OpenApiHeader ReferencedHeader = new()`
	`30`	`+ private static OpenApiHeader ReferencedHeader => new()`
`31`	`31`	`{`
`32`	`32`	`Description = "sampleHeader",`
`33`	`33`	`Schema = new OpenApiSchema()`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ namespace Microsoft.OpenApi.Tests.Models`
`18`	`18`	`[Collection("DefaultSettings")]`
`19`	`19`	`public class OpenApiLinkTests`
`20`	`20`	`{`
`21`		`- public static readonly OpenApiLink AdvancedLink = new()`
	`21`	`+ private static OpenApiLink AdvancedLink => new()`
`22`	`22`	`{`
`23`	`23`	`OperationId = "operationId1",`
`24`	`24`	`Parameters =`
`@@ -42,8 +42,8 @@ public class OpenApiLinkTests`
`42`	`42`	`}`
`43`	`43`	`};`
`44`	`44`
`45`		`- public static readonly OpenApiLinkReference LinkReference = new(ReferencedLink, "example1");`
`46`		`- public static readonly OpenApiLink ReferencedLink = new()`
	`45`	`+ private static OpenApiLinkReference LinkReference => new(ReferencedLink, "example1");`
	`46`	`+ private static OpenApiLink ReferencedLink => new()`
`47`	`47`	`{`
`48`	`48`	`OperationId = "operationId1",`
`49`	`49`	`Parameters =`
Original file line number	Diff line number	Diff line change
`@@ -19,20 +19,20 @@ namespace Microsoft.OpenApi.Tests.Models`
`19`	`19`	`[Collection("DefaultSettings")]`
`20`	`20`	`public class OpenApiParameterTests`
`21`	`21`	`{`
`22`		`- public static OpenApiParameter BasicParameter = new()`
	`22`	`+ private static OpenApiParameter BasicParameter => new()`
`23`	`23`	`{`
`24`	`24`	`Name = "name1",`
`25`	`25`	`In = ParameterLocation.Path`
`26`	`26`	`};`
`27`	`27`
`28`		`- public static OpenApiParameterReference OpenApiParameterReference = new(ReferencedParameter, "example1");`
`29`		`- public static OpenApiParameter ReferencedParameter = new()`
	`28`	`+ private static OpenApiParameterReference OpenApiParameterReference => new(ReferencedParameter, "example1");`
	`29`	`+ private static OpenApiParameter ReferencedParameter => new()`
`30`	`30`	`{`
`31`	`31`	`Name = "name1",`
`32`	`32`	`In = ParameterLocation.Path`
`33`	`33`	`};`
`34`	`34`
`35`		`- public static OpenApiParameter AdvancedPathParameterWithSchema = new()`
	`35`	`+ private static OpenApiParameter AdvancedPathParameterWithSchema => new()`
`36`	`36`	`{`
`37`	`37`	`Name = "name1",`
`38`	`38`	`In = ParameterLocation.Path,`
`@@ -61,7 +61,7 @@ public class OpenApiParameterTests`
`61`	`61`	`}`
`62`	`62`	`};`
`63`	`63`
`64`		`- public static OpenApiParameter ParameterWithFormStyleAndExplodeFalse = new()`
	`64`	`+ private static OpenApiParameter ParameterWithFormStyleAndExplodeFalse => new()`
`65`	`65`	`{`
`66`	`66`	`Name = "name1",`
`67`	`67`	`In = ParameterLocation.Query,`
`@@ -82,7 +82,7 @@ public class OpenApiParameterTests`
`82`	`82`	`}`
`83`	`83`	`};`
`84`	`84`
`85`		`- public static OpenApiParameter ParameterWithFormStyleAndExplodeTrue = new()`
	`85`	`+ private static OpenApiParameter ParameterWithFormStyleAndExplodeTrue => new()`
`86`	`86`	`{`
`87`	`87`	`Name = "name1",`
`88`	`88`	`In = ParameterLocation.Query,`
`@@ -103,7 +103,7 @@ public class OpenApiParameterTests`
`103`	`103`	`}`
`104`	`104`	`};`
`105`	`105`
`106`		`- public static OpenApiParameter QueryParameterWithMissingStyle = new OpenApiParameter`
	`106`	`+ private static OpenApiParameter QueryParameterWithMissingStyle => new OpenApiParameter`
`107`	`107`	`{`
`108`	`108`	`Name = "id",`
`109`	`109`	`In = ParameterLocation.Query,`
`@@ -117,7 +117,7 @@ public class OpenApiParameterTests`
`117`	`117`	`}`
`118`	`118`	`};`
`119`	`119`
`120`		`- public static OpenApiParameter AdvancedHeaderParameterWithSchemaTypeObject = new()`
	`120`	`+ private static OpenApiParameter AdvancedHeaderParameterWithSchemaTypeObject => new()`
`121`	`121`	`{`
`122`	`122`	`Name = "name1",`
`123`	`123`	`In = ParameterLocation.Header,`
Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,9 @@ namespace Microsoft.OpenApi.Tests.Models`
`20`	`20`	`[Collection("DefaultSettings")]`
`21`	`21`	`public class OpenApiResponseTests`
`22`	`22`	`{`
`23`		`- public static OpenApiResponse BasicResponse = new OpenApiResponse();`
	`23`	`+ private static OpenApiResponse BasicResponse => new OpenApiResponse();`
`24`	`24`
`25`		`- public static OpenApiResponse AdvancedV2Response = new OpenApiResponse`
	`25`	`+ private static OpenApiResponse AdvancedV2Response => new OpenApiResponse`
`26`	`26`	`{`
`27`	`27`	`Description = "A complex object array response",`
`28`	`28`	`Content =`
`@@ -61,7 +61,7 @@ public class OpenApiResponseTests`
`61`	`61`	`},`
`62`	`62`	`}`
`63`	`63`	`};`
`64`		`- public static OpenApiResponse AdvancedV3Response = new OpenApiResponse`
	`64`	`+ private static OpenApiResponse AdvancedV3Response => new OpenApiResponse`
`65`	`65`	`{`
`66`	`66`	`Description = "A complex object array response",`
`67`	`67`	`Content =`
`@@ -101,8 +101,8 @@ public class OpenApiResponseTests`
`101`	`101`	`}`
`102`	`102`	`};`
`103`	`103`
`104`		`- public static OpenApiResponseReference V2OpenApiResponseReference = new OpenApiResponseReference(ReferencedV2Response, "example1");`
`105`		`- public static OpenApiResponse ReferencedV2Response = new OpenApiResponse`
	`104`	`+ private static OpenApiResponseReference V2OpenApiResponseReference => new OpenApiResponseReference(ReferencedV2Response, "example1");`
	`105`	`+ private static OpenApiResponse ReferencedV2Response => new OpenApiResponse`
`106`	`106`	`{`
`107`	`107`	`Description = "A complex object array response",`
`108`	`108`	`Content =`
`@@ -136,9 +136,9 @@ public class OpenApiResponseTests`
`136`	`136`	`},`
`137`	`137`	`}`
`138`	`138`	`};`
`139`		`- public static OpenApiResponseReference V3OpenApiResponseReference = new OpenApiResponseReference(ReferencedV3Response, "example1");`
	`139`	`+ private static OpenApiResponseReference V3OpenApiResponseReference => new OpenApiResponseReference(ReferencedV3Response, "example1");`
`140`	`140`
`141`		`- public static OpenApiResponse ReferencedV3Response = new OpenApiResponse`
	`141`	`+ private static OpenApiResponse ReferencedV3Response => new OpenApiResponse`
`142`	`142`	`{`
`143`	`143`	`Description = "A complex object array response",`
`144`	`144`	`Content =`