Add logger class for easy reuse and clean up code

Author: MaggieKimani1

src/Microsoft.OpenApi.Hidi/Logger.cs

@@ -0,0 +1,35 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license.
+
+using Microsoft.Extensions.Logging;
+
+namespace Microsoft.OpenApi.Hidi
+{
+    public class Logger
+    {
+        public static ILogger<OpenApiService> ConfigureLogger(LogLevel logLevel)
+        {
+            // Configure logger options
+#if DEBUG
+            logLevel = logLevel > LogLevel.Debug ? LogLevel.Debug : logLevel;
+#endif
+
+            using var loggerFactory = LoggerFactory.Create((builder) =>
+            {
+                builder
+                    .AddSimpleConsole(c =>
+                    {
+                        c.IncludeScopes = true;
+                    })
+#if DEBUG   
+                    .AddDebug()
+#endif
+                    .SetMinimumLevel(logLevel);
+            });
+
+            var logger = loggerFactory.CreateLogger<OpenApiService>();
+
+            return logger;
+        }
+    }
+}

src/Microsoft.OpenApi.Hidi/OpenApiService.cs

@@ -26,7 +26,6 @@
 using System.Threading;
 using System.Xml.Xsl;
 using System.Xml;
-using System.Runtime.CompilerServices;
 using System.Reflection;
 
 namespace Microsoft.OpenApi.Hidi
@@ -36,7 +35,7 @@ public class OpenApiService
         /// <summary>
         /// Implementation of the transform command
         /// </summary>
-        public static async Task<int> TransformOpenApiDocument(
+        public static async Task TransformOpenApiDocument(
             string openapi,
             string csdl,
             string csdlFilter,
@@ -54,8 +53,7 @@ public static async Task<int> TransformOpenApiDocument(
             CancellationToken cancellationToken
            )
         {
-            using var loggerFactory = ConfigureLoggerInstance(loglevel);
-            var logger = loggerFactory.CreateLogger<OpenApiService>();
+            var logger = Logger.ConfigureLogger(loglevel);
 
             try
             {
@@ -212,18 +210,11 @@ CancellationToken cancellationToken
                     logger.LogTrace($"Finished serializing in {stopwatch.ElapsedMilliseconds}ms");
                     textWriter.Flush();
                 }
-                return 0;
             }
             catch (Exception ex)
             {
-#if DEBUG  
-                logger.LogCritical(ex, ex.Message);               
-#else
-                logger.LogCritical(ex.Message);
-                
-#endif
-                return 1;
-            }            
+                throw new InvalidOperationException($"Could not transform the document, reason: {ex.Message}", ex);
+            }
         }
 
         private static XslCompiledTransform GetFilterTransform()
@@ -249,18 +240,15 @@ private static Stream ApplyFilter(string csdl, string entitySetOrSingleton, XslC
             return stream;
         }
 
-
-
         /// <summary>
         /// Implementation of the validate command
         /// </summary>
-        public static async Task<int> ValidateOpenApiDocument(
+        public static async Task ValidateOpenApiDocument(
             string openapi, 
             LogLevel loglevel, 
             CancellationToken cancellationToken)
         {
-            using var loggerFactory = ConfigureLoggerInstance(loglevel);
-            var logger = loggerFactory.CreateLogger<OpenApiService>();
+            var logger = Logger.ConfigureLogger(loglevel);
 
             try
             {
@@ -308,19 +296,11 @@ public static async Task<int> ValidateOpenApiDocument(
                     logger.LogTrace("Finished walking through the OpenApi document. Generating a statistics report..");
                     logger.LogInformation(statsVisitor.GetStatisticsReport());
                 }
-
-                return 0;
             }
             catch (Exception ex)
             {
-#if DEBUG
-                logger.LogCritical(ex, ex.Message);
-#else
-                logger.LogCritical(ex.Message);
-#endif
-                return 1;
+                throw new InvalidOperationException($"Could not validate the document, reason: {ex.Message}", ex);
             }
-
         }
 
         /// <summary>