Skip to content

Commit 8bbb3dd

Browse files
committed
Guard against null references
1 parent a2f70ae commit 8bbb3dd

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Microsoft.OpenApi.Readers/OpenApiYamlReader.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public ReadResult Read(MemoryStream input,
4848
// Parse the YAML text in the TextReader into a sequence of JsonNodes
4949
try
5050
{
51-
using var stream = new StreamReader(input, default, true, -1, settings.LeaveStreamOpen);
51+
using var stream = new StreamReader(input, default, true, -1, settings?.LeaveStreamOpen);
5252
jsonNode = LoadJsonNodesFromYamlDocument(stream);
5353
}
5454
catch (JsonException ex)

src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ private static async Task<ReadResult> InternalLoadAsync(Stream input, string for
210210
var reader = OpenApiReaderRegistry.GetReader(format);
211211
var readResult = await reader.ReadAsync(input, settings, cancellationToken);
212212

213-
if (settings.LoadExternalRefs)
213+
if (settings is not null && settings.LoadExternalRefs)
214214
{
215215
var diagnosticExternalRefs = await LoadExternalRefsAsync(readResult.OpenApiDocument, cancellationToken, settings, format);
216216
// Merge diagnostics of external reference
@@ -239,7 +239,7 @@ private static async Task<OpenApiDiagnostic> LoadExternalRefsAsync(OpenApiDocume
239239
private static ReadResult InternalLoad(MemoryStream input, string format, OpenApiReaderSettings settings = null)
240240
{
241241
Utils.CheckArgumentNull(format, nameof(format));
242-
if (settings.LoadExternalRefs)
242+
if (settings is not null && settings.LoadExternalRefs)
243243
{
244244
throw new InvalidOperationException("Loading external references are not supported when using synchronous methods.");
245245
}

0 commit comments

Comments
 (0)