clean up tests

Author: MaggieKimani1

test/Microsoft.OpenApi.Readers.Tests/V31Tests/OpenApiDocumentTests.cs

@@ -22,24 +22,6 @@ public OpenApiDocumentTests()
             OpenApiReaderRegistry.RegisterReader(OpenApiConstants.Yaml, new OpenApiYamlReader());
         }
 
-        public static T Clone<T>(T element) where T : IOpenApiSerializable
-        {
-            using var stream = new MemoryStream();
-            IOpenApiWriter writer;
-            var streamWriter = new FormattingStreamWriter(stream, CultureInfo.InvariantCulture);
-            writer = new OpenApiJsonWriter(streamWriter, new OpenApiJsonWriterSettings()
-            {
-                InlineLocalReferences = true
-            });
-            element.SerializeAsV31(writer);
-            writer.Flush();
-            stream.Position = 0;
-
-            using var streamReader = new StreamReader(stream);
-            var result = streamReader.ReadToEnd();
-            return OpenApiModelFactory.Parse<T>(result, OpenApiSpecVersion.OpenApi3_1, out OpenApiDiagnostic diagnostic4);
-        }
-
         [Fact]
         public void ParseDocumentWithWebhooksShouldSucceed()
         {
@@ -408,6 +390,11 @@ public void ParseDocumentsWithReusablePathItemInWebhooksSucceeds()
             .Excluding(y => y.BaseUri));
             actual.OpenApiDiagnostic.Should().BeEquivalentTo(
     new OpenApiDiagnostic() { SpecificationVersion = OpenApiSpecVersion.OpenApi3_1 });
+
+            var outputWriter = new StringWriter(CultureInfo.InvariantCulture);
+            var writer = new OpenApiJsonWriter(outputWriter, new() { InlineLocalReferences = true } );
+            actual.OpenApiDocument.SerializeAsV31(writer);
+            var serialized = outputWriter.ToString();
         }
 
         [Fact]

test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDocumentTests.cs

@@ -63,7 +63,7 @@ public OpenApiSecurityScheme CloneSecurityScheme(OpenApiSecurityScheme element)
                 {
                     InlineLocalReferences = true
                 });
-                element.SerializeAsV3WithoutReference(writer);
+                element.SerializeAsV3(writer);
                 writer.Flush();
                 stream.Position = 0;
 

test/Microsoft.OpenApi.Tests/Models/OpenApiCallbackTests.cs

@@ -138,7 +138,7 @@ public async Task SerializeReferencedCallbackAsV3JsonWithoutReferenceWorks(bool
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ReferencedCallback.SerializeAsV3WithoutReference(writer);
+            ReferencedCallback.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert

test/Microsoft.OpenApi.Tests/Models/OpenApiExampleTests.cs

@@ -141,7 +141,7 @@ public async Task SerializeReferencedExampleAsV3JsonWithoutReferenceWorks(bool p
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ReferencedExample.SerializeAsV3WithoutReference(writer);
+            ReferencedExample.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert

test/Microsoft.OpenApi.Tests/Models/OpenApiHeaderTests.cs

@@ -81,7 +81,7 @@ public async Task SerializeReferencedHeaderAsV3JsonWithoutReferenceWorks(bool pr
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ReferencedHeader.SerializeAsV3WithoutReference(writer);
+            ReferencedHeader.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert
@@ -132,7 +132,7 @@ public async Task SerializeReferencedHeaderAsV2JsonWithoutReferenceWorks(bool pr
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ReferencedHeader.SerializeAsV2WithoutReference(writer);
+            ReferencedHeader.SerializeAsV2(writer);
             writer.Flush();
 
             // Assert

test/Microsoft.OpenApi.Tests/Models/OpenApiLinkTests.cs

@@ -116,7 +116,7 @@ public async Task SerializeReferencedLinkAsV3JsonWithoutReferenceWorksAsync(bool
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ReferencedLink.SerializeAsV3WithoutReference(writer);
+            ReferencedLink.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert

test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.cs

@@ -352,7 +352,7 @@ public async Task SerializeReferencedParameterAsV3JsonWithoutReferenceWorksAsync
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ReferencedParameter.SerializeAsV3WithoutReference(writer);
+            ReferencedParameter.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert
@@ -386,7 +386,7 @@ public async Task SerializeReferencedParameterAsV2JsonWithoutReferenceWorksAsync
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ReferencedParameter.SerializeAsV2WithoutReference(writer);
+            ReferencedParameter.SerializeAsV2(writer);
             writer.Flush();
 
             // Assert
@@ -420,7 +420,7 @@ public async Task SerializeParameterWithFormStyleAndExplodeFalseWorksAsync(bool
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ParameterWithFormStyleAndExplodeFalse.SerializeAsV3WithoutReference(writer);
+            ParameterWithFormStyleAndExplodeFalse.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert
@@ -437,7 +437,7 @@ public async Task SerializeParameterWithFormStyleAndExplodeTrueWorksAsync(bool p
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ParameterWithFormStyleAndExplodeTrue.SerializeAsV3WithoutReference(writer);
+            ParameterWithFormStyleAndExplodeTrue.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert

test/Microsoft.OpenApi.Tests/Models/OpenApiRequestBodyTests.cs

@@ -92,7 +92,7 @@ public async Task SerializeReferencedRequestBodyAsV3JsonWithoutReferenceWorksAsy
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ReferencedRequestBody.SerializeAsV3WithoutReference(writer);
+            ReferencedRequestBody.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert

test/Microsoft.OpenApi.Tests/Models/OpenApiResponseTests.cs

@@ -374,7 +374,7 @@ public async Task SerializeReferencedResponseAsV3JsonWithoutReferenceWorksAsync(
             var writer = new OpenApiJsonWriter(outputStringWriter, new OpenApiJsonWriterSettings { Terse = produceTerseOutput });
 
             // Act
-            ReferencedV3Response.SerializeAsV3WithoutReference(writer);
+            ReferencedV3Response.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert
@@ -408,7 +408,7 @@ public async Task SerializeReferencedResponseAsV2JsonWithoutReferenceWorksAsync(
             var writer = new OpenApiJsonWriter(outputStringWriter, new OpenApiJsonWriterSettings { Terse = produceTerseOutput });
 
             // Act
-            ReferencedV2Response.SerializeAsV2WithoutReference(writer);
+            ReferencedV2Response.SerializeAsV2(writer);
             writer.Flush();
 
             // Assert

test/Microsoft.OpenApi.Tests/Models/OpenApiSecuritySchemeTests.cs

@@ -333,7 +333,7 @@ public async Task SerializeReferencedSecuritySchemeAsV3JsonWithoutReferenceWorks
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            ReferencedSecurityScheme.SerializeAsV3WithoutReference(writer);
+            ReferencedSecurityScheme.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert