PR review related fixes

Author: darrelmiller

src/Microsoft.OpenApi/Models/OpenApiError.cs

@@ -13,7 +13,7 @@ public class OpenApiError
         /// <summary>
         /// Initializes the <see cref="OpenApiError"/> class using the message and pointer from the given exception.
         /// </summary>
-        public OpenApiError(OpenApiException exception)
+        public OpenApiError(OpenApiException exception) : this(exception.Pointer, exception.Message)
         {
             Message = exception.Message;
             Pointer = exception.Pointer;

src/Microsoft.OpenApi/Validations/Rules/OpenApiContactRules.cs

@@ -33,19 +33,5 @@ public static class OpenApiContactRules
                     context.Exit();
                 });
 
-        /// <summary>
-        /// Url field MUST be url format.
-        /// </summary>
-        public static ValidationRule<OpenApiContact> UrlMustBeUrlFormat =>
-            new ValidationRule<OpenApiContact>(
-                (context, item) =>
-                {
-                    context.Enter("url");
-                    if (item != null && item.Url != null)
-                    {
-                        // TODO:
-                    }
-                    context.Exit();
-                });
     }
 }

src/Microsoft.OpenApi/Validations/Rules/OpenApiLicenseRules.cs

@@ -21,7 +21,7 @@ public static class OpenApiLicenseRules
                 (context, license) =>
                 {
                     context.Enter("name");
-                    if (String.IsNullOrEmpty(license.Name))
+                    if (license.Name == null)
                     {
                         context.CreateError(nameof(LicenseRequiredFields),ErrorReason.Required,
                             String.Format(SRResource.Validation_FieldIsRequired, "name", "license"));

src/Microsoft.OpenApi/Validations/Rules/OpenApiPathsRules.cs

@@ -24,13 +24,7 @@ public static class OpenApiPathsRules
                     {
                         context.Enter(pathName);
 
-                        if (string.IsNullOrEmpty(pathName))
-                        {
-                            // Add the error message
-                            // context.Add(...);
-                        }
-
-                        if (!pathName.StartsWith("/"))
+                         if (pathName == null || !pathName.StartsWith("/"))
                         {
                             context.CreateError(nameof(PathNameMustBeginWithSlash),ErrorReason.Format,
                                 string.Format(SRResource.Validation_PathItemMustBeginWithSlash, pathName));

src/Microsoft.OpenApi/Validations/Rules/OpenApiResponseRules.cs

@@ -22,7 +22,7 @@ public static class OpenApiResponseRules
                 {
                     // description
                     context.Enter("description");
-                    if (String.IsNullOrEmpty(response.Description))
+                    if (response.Description == null)
                     {
                         context.CreateError(nameof(ResponseRequiredFields),ErrorReason.Required,
                             String.Format(SRResource.Validation_FieldIsRequired, "description", "response"));

src/Microsoft.OpenApi/Validations/Rules/OpenApiServerRules.cs

@@ -21,7 +21,7 @@ public static class OpenApiServerRules
                 (context, server) =>
                 {
                     context.Enter("url");
-                    if (String.IsNullOrEmpty(server.Url))
+                    if (server.Url == null)
                     {
                         context.CreateError(nameof(ServerRequiredFields),ErrorReason.Required,
                             String.Format(SRResource.Validation_FieldIsRequired, "url", "server"));

src/Microsoft.OpenApi/Validations/Rules/OpenApiTagRules.cs

@@ -21,7 +21,7 @@ public static class OpenApiTagRules
                 (context, tag) =>
                 {
                     context.Enter("name");
-                    if (String.IsNullOrEmpty(tag.Name))
+                    if (tag.Name == null)
                     {
                         context.CreateError(nameof(TagRequiredFields),ErrorReason.Required,
                             String.Format(SRResource.Validation_FieldIsRequired, "name", "tag"));

test/Microsoft.OpenApi.Tests/Validations/ValidationRuleSetTests.cs

@@ -43,7 +43,7 @@ public void DefaultRuleSetPropertyReturnsTheCorrectRules()
             Assert.NotEmpty(rules);
 
             // Update the number if you add new default rule(s).
-            Assert.Equal(15, rules.Count);
+            Assert.Equal(14, rules.Count);
         }
     }
 }