use negation pattern

Author: SimonCropp

src/Microsoft.OpenApi.Readers/ParseNodes/MapNode.cs

@@ -30,7 +30,7 @@ public MapNode(ParsingContext context, string yamlString) :
         public MapNode(ParsingContext context, YamlNode node) : base(
             context)
         {
-            if (!(node is YamlMappingNode mapNode))
+            if (node is not YamlMappingNode mapNode)
             {
                 throw new OpenApiReaderException("Expected map.", Context);
             }

src/Microsoft.OpenApi.Readers/ParseNodes/OpenApiAnyConverter.cs

@@ -50,7 +50,7 @@ public static IOpenApiAny GetSpecificOpenApiAny(IOpenApiAny openApiAny, OpenApiS
                 return newObject;
             }
 
-            if (!(openApiAny is OpenApiString))
+            if (openApiAny is not OpenApiString)
             {
                 return openApiAny;
             }

src/Microsoft.OpenApi.Readers/ParseNodes/ParseNode.cs

@@ -24,7 +24,7 @@ protected ParseNode(ParsingContext parsingContext)
 
         public MapNode CheckMapNode(string nodeName)
         {
-            if (!(this is MapNode mapNode))
+            if (this is not MapNode mapNode)
             {
                 throw new OpenApiReaderException($"{nodeName} must be a map/object", Context);
             }

src/Microsoft.OpenApi.Readers/ParseNodes/ValueNode.cs

@@ -15,7 +15,7 @@ internal class ValueNode : ParseNode
         public ValueNode(ParsingContext context, YamlNode node) : base(
             context)
         {
-            if (!(node is YamlScalarNode scalarNode))
+            if (node is not YamlScalarNode scalarNode)
             {
                 throw new OpenApiReaderException("Expected a value.", node);
             }

src/Microsoft.OpenApi/Validations/Rules/RuleHelpers.cs

@@ -75,7 +75,7 @@ public static void ValidateDataTypeMismatch(
                 }
 
                 // If value is not a string and also not an object, there is a data mismatch.
-                if (!(value is OpenApiObject))
+                if (value is not OpenApiObject)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -115,7 +115,7 @@ public static void ValidateDataTypeMismatch(
                 }
 
                 // If value is not a string and also not an array, there is a data mismatch.
-                if (!(value is OpenApiArray))
+                if (value is not OpenApiArray)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -139,7 +139,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "integer" && format == "int32")
             {
-                if (!(value is OpenApiInteger))
+                if (value is not OpenApiInteger)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -151,7 +151,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "integer" && format == "int64")
             {
-                if (!(value is OpenApiLong))
+                if (value is not OpenApiLong)
                 {
                     context.CreateWarning(
                        ruleName,
@@ -161,9 +161,9 @@ public static void ValidateDataTypeMismatch(
                 return;
             }
 
-            if (type == "integer" && !(value is OpenApiInteger))
+            if (type == "integer" && value is not OpenApiInteger)
             {
-                if (!(value is OpenApiInteger))
+                if (value is not OpenApiInteger)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -175,7 +175,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "number" && format == "float")
             {
-                if (!(value is OpenApiFloat))
+                if (value is not OpenApiFloat)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -187,7 +187,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "number" && format == "double")
             {
-                if (!(value is OpenApiDouble))
+                if (value is not OpenApiDouble)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -199,7 +199,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "number")
             {
-                if (!(value is OpenApiDouble))
+                if (value is not OpenApiDouble)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -211,7 +211,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "string" && format == "byte")
             {
-                if (!(value is OpenApiByte))
+                if (value is not OpenApiByte)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -223,7 +223,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "string" && format == "date")
             {
-                if (!(value is OpenApiDate))
+                if (value is not OpenApiDate)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -235,7 +235,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "string" && format == "date-time")
             {
-                if (!(value is OpenApiDateTime))
+                if (value is not OpenApiDateTime)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -247,7 +247,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "string" && format == "password")
             {
-                if (!(value is OpenApiPassword))
+                if (value is not OpenApiPassword)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -259,7 +259,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "string")
             {
-                if (!(value is OpenApiString))
+                if (value is not OpenApiString)
                 {
                     context.CreateWarning(
                         ruleName,
@@ -271,7 +271,7 @@ public static void ValidateDataTypeMismatch(
 
             if (type == "boolean")
             {
-                if (!(value is OpenApiBoolean))
+                if (value is not OpenApiBoolean)
                 {
                     context.CreateWarning(
                         ruleName,

src/Microsoft.OpenApi/Validations/ValidationRule.cs

@@ -59,7 +59,7 @@ internal override void Evaluate(IValidationContext context, object item)
                 return;
             }
 
-            if (!(item is T))
+            if (item is not T)
             {
                 throw Error.Argument(string.Format(SRResource.InputItemShouldBeType, typeof(T).FullName));
             }

test/Microsoft.OpenApi.SmokeTests/ApiGurus.cs

@@ -62,7 +62,7 @@ public static IEnumerable<object[]> GetSchemas()
 
             JToken GetProp(JToken obj, string prop)
             {
-                if (!(obj is JObject jObj))
+                if (obj is not JObject jObj)
                     return null;
                 if (!jObj.TryGetValue(prop, out var jToken))
                     return null;