Skip to content

Commit ab2ddf0

Browse files
committed
fix: default settings in case of null value
Signed-off-by: Vincent Biret <[email protected]>
1 parent d1aedb4 commit ab2ddf0

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,12 +200,14 @@ public static T Parse<T>(string input,
200200
return Load<T>(stream, version, format, out diagnostic, settings);
201201
}
202202

203+
private static readonly OpenApiReaderSettings DefaultReaderSettings = new();
204+
203205
private static async Task<ReadResult> InternalLoadAsync(Stream input, string format, OpenApiReaderSettings settings, CancellationToken cancellationToken = default)
204206
{
205207
var reader = OpenApiReaderRegistry.GetReader(format);
206208
var readResult = await reader.ReadAsync(input, settings, cancellationToken);
207209

208-
if (settings.LoadExternalRefs)
210+
if (settings?.LoadExternalRefs ?? DefaultReaderSettings.LoadExternalRefs)
209211
{
210212
var diagnosticExternalRefs = await LoadExternalRefsAsync(readResult.OpenApiDocument, cancellationToken, settings, format);
211213
// Merge diagnostics of external reference
@@ -233,7 +235,7 @@ private static async Task<OpenApiDiagnostic> LoadExternalRefsAsync(OpenApiDocume
233235

234236
private static ReadResult InternalLoad(MemoryStream input, string format, OpenApiReaderSettings settings)
235237
{
236-
if (settings.LoadExternalRefs)
238+
if (settings?.LoadExternalRefs ?? DefaultReaderSettings.LoadExternalRefs)
237239
{
238240
throw new InvalidOperationException("Loading external references are not supported when using synchronous methods.");
239241
}

0 commit comments

Comments
 (0)